Title: [176240] trunk/Source/WebCore
Revision
176240
Author
[email protected]
Date
2014-11-17 17:49:33 -0800 (Mon, 17 Nov 2014)

Log Message

[iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
https://bugs.webkit.org/show_bug.cgi?id=138815
rdar://problem/18746203

Reviewed by Tim Horton.

The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.

We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
between WK1 and WK2 for now.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (176239 => 176240)


--- trunk/Source/WebCore/ChangeLog	2014-11-18 01:14:46 UTC (rev 176239)
+++ trunk/Source/WebCore/ChangeLog	2014-11-18 01:49:33 UTC (rev 176240)
@@ -1,3 +1,20 @@
+2014-11-17  Simon Fraser  <[email protected]>
+
+        [iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
+        https://bugs.webkit.org/show_bug.cgi?id=138815
+        rdar://problem/18746203
+
+        Reviewed by Tim Horton.
+
+        The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
+        so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.
+        
+        We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
+        between WK1 and WK2 for now.
+        
+        * page/FrameView.cpp:
+        (WebCore::FrameView::FrameView):
+
 2014-11-17  Chris Dumez  <[email protected]>
 
         Add initial layout testing coverage for timer throttling

Modified: trunk/Source/WebCore/page/FrameView.cpp (176239 => 176240)


--- trunk/Source/WebCore/page/FrameView.cpp	2014-11-18 01:14:46 UTC (rev 176239)
+++ trunk/Source/WebCore/page/FrameView.cpp	2014-11-18 01:49:33 UTC (rev 176240)
@@ -188,6 +188,10 @@
 #if PLATFORM(IOS)
     , m_useCustomFixedPositionLayoutRect(false)
     , m_useCustomSizeForResizeEvent(false)
+    , m_horizontalVelocity(0)
+    , m_verticalVelocity(0)
+    , m_scaleChangeRate(0)
+    , m_lastVelocityUpdateTime(0)
 #endif
     , m_hasOverrideViewportSize(false)
     , m_shouldAutoSize(false)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to