Title: [176299] trunk/Source/WebKit2
Revision
176299
Author
[email protected]
Date
2014-11-18 17:43:14 -0800 (Tue, 18 Nov 2014)

Log Message

Give clients a way to cancel preview popovers
https://bugs.webkit.org/show_bug.cgi?id=138855

Reviewed by Tim Horton.

Promote -[WKView _dismissActionMenuPopovers] from internal to private.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _dismissActionMenuPopovers]):
* UIProcess/API/mac/WKViewInternal.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (176298 => 176299)


--- trunk/Source/WebKit2/ChangeLog	2014-11-19 01:19:43 UTC (rev 176298)
+++ trunk/Source/WebKit2/ChangeLog	2014-11-19 01:43:14 UTC (rev 176299)
@@ -1,3 +1,17 @@
+2014-11-18  Conrad Shultz  <[email protected]>
+
+        Give clients a way to cancel preview popovers
+        https://bugs.webkit.org/show_bug.cgi?id=138855
+
+        Reviewed by Tim Horton.
+
+        Promote -[WKView _dismissActionMenuPopovers] from internal to private.
+
+        * UIProcess/API/Cocoa/WKViewPrivate.h:
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView _dismissActionMenuPopovers]):
+        * UIProcess/API/mac/WKViewInternal.h:
+
 2014-11-18  Chris Dumez  <[email protected]>
 
         Add a setting to toggle DOMTimer throttling support

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (176298 => 176299)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2014-11-19 01:19:43 UTC (rev 176298)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2014-11-19 01:43:14 UTC (rev 176299)
@@ -126,4 +126,6 @@
 - (void)_finishPreviewingURL:(NSURL *)url withPreviewView:(NSView *)previewView;
 #endif
 
+- (void)_dismissActionMenuPopovers;
+
 @end

Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (176298 => 176299)


--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-11-19 01:19:43 UTC (rev 176298)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-11-19 01:43:14 UTC (rev 176299)
@@ -3709,13 +3709,6 @@
 
 #endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
 
-- (void)_dismissActionMenuPopovers
-{
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
-    [_data->_actionMenuController dismissActionMenuPopovers];
-#endif
-}
-
 @end
 
 @implementation WKView (Private)
@@ -4211,6 +4204,13 @@
     return [self _actionMenuItemsForHitTestResult:hitTestResult withType:type defaultActionMenuItems:defaultMenuItems];
 }
 
+- (void)_dismissActionMenuPopovers
+{
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+    [_data->_actionMenuController dismissActionMenuPopovers];
+#endif
+}
+
 - (NSView *)_viewForPreviewingURL:(NSURL *)url initialFrameSize:(NSSize)initialFrameSize
 {
     return nil;

Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (176298 => 176299)


--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h	2014-11-19 01:19:43 UTC (rev 176298)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h	2014-11-19 01:43:14 UTC (rev 176299)
@@ -132,8 +132,6 @@
 - (void)_didPerformActionMenuHitTest:(const WebKit::ActionMenuHitTestResult&)hitTestResult userData:(API::Object*)userData;
 #endif
 
-- (void)_dismissActionMenuPopovers;
-
 @property (nonatomic, retain, setter=_setPrimaryTrackingArea:) NSTrackingArea *_primaryTrackingArea;
 
 @end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to