Title: [176320] trunk/Source/WebCore
- Revision
- 176320
- Author
- [email protected]
- Date
- 2014-11-19 09:26:31 -0800 (Wed, 19 Nov 2014)
Log Message
Simple line layout: RenderTreeAsText should use rangeForRenderer() when dumping simple line text.
https://bugs.webkit.org/show_bug.cgi?id=138847
Reviewed by Antti Koivisto.
This is in preparation to support multiple renderers for simple line layout.
Use rangeForRenderer() to get runs for a particular renderer as opposed to for the entire flow.
Not testable.
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176319 => 176320)
--- trunk/Source/WebCore/ChangeLog 2014-11-19 17:23:14 UTC (rev 176319)
+++ trunk/Source/WebCore/ChangeLog 2014-11-19 17:26:31 UTC (rev 176320)
@@ -1,3 +1,18 @@
+2014-11-19 Zalan Bujtas <[email protected]>
+
+ Simple line layout: RenderTreeAsText should use rangeForRenderer() when dumping simple line text.
+ https://bugs.webkit.org/show_bug.cgi?id=138847
+
+ Reviewed by Antti Koivisto.
+
+ This is in preparation to support multiple renderers for simple line layout.
+ Use rangeForRenderer() to get runs for a particular renderer as opposed to for the entire flow.
+
+ Not testable.
+
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+
2014-11-19 [email protected] <[email protected]>
[WinCairo] Compile error when CSS_SELECTORS_LEVEL4 is not enabled.
Modified: trunk/Source/WebCore/rendering/RenderTreeAsText.cpp (176319 => 176320)
--- trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2014-11-19 17:23:14 UTC (rev 176319)
+++ trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2014-11-19 17:26:31 UTC (rev 176320)
@@ -543,8 +543,7 @@
if (auto layout = text.simpleLineLayout()) {
ASSERT(!text.firstTextBox());
auto resolver = runResolver(downcast<RenderBlockFlow>(*text.parent()), *layout);
- for (auto it = resolver.begin(), end = resolver.end(); it != end; ++it) {
- auto run = *it;
+ for (const auto& run : resolver.rangeForRenderer(text)) {
writeIndent(ts, indent + 1);
writeSimpleLine(ts, text, run.rect(), run.text());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
