Title: [176427] trunk/Source/WebKit2
- Revision
- 176427
- Author
- [email protected]
- Date
- 2014-11-20 16:36:45 -0800 (Thu, 20 Nov 2014)
Log Message
Clients should be able to customize preview click behavior
https://bugs.webkit.org/show_bug.cgi?id=138940
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_handleClickInPreviewView:URL:.
* UIProcess/API/mac/WKView.mm:
(-[WKView _handleClickInPreviewView:URL:]):
Extracted from -[WKActionMenuController pagePreviewViewControllerWasClicked:].
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
Extract code to -[WKView _handleClickInPreviewView:URL:].
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (176426 => 176427)
--- trunk/Source/WebKit2/ChangeLog 2014-11-21 00:28:03 UTC (rev 176426)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-21 00:36:45 UTC (rev 176427)
@@ -1,3 +1,21 @@
+2014-11-20 Conrad Shultz <[email protected]>
+
+ Clients should be able to customize preview click behavior
+ https://bugs.webkit.org/show_bug.cgi?id=138940
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/API/Cocoa/WKViewPrivate.h:
+ Declare -_handleClickInPreviewView:URL:.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView _handleClickInPreviewView:URL:]):
+ Extracted from -[WKActionMenuController pagePreviewViewControllerWasClicked:].
+
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
+ Extract code to -[WKView _handleClickInPreviewView:URL:].
+
2014-11-20 Csaba Osztrogonác <[email protected]>
URTBF after r176420 to fix non Apple builds.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (176426 => 176427)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2014-11-21 00:28:03 UTC (rev 176426)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2014-11-21 00:36:45 UTC (rev 176427)
@@ -124,6 +124,7 @@
- (NSView *)_viewForPreviewingURL:(NSURL *)url initialFrameSize:(NSSize)initialFrameSize;
- (void)_finishPreviewingURL:(NSURL *)url withPreviewView:(NSView *)previewView;
+- (void)_handleClickInPreviewView:(NSView *)previewView URL:(NSURL *)url;
- (void)_dismissActionMenuPopovers;
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (176426 => 176427)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-11-21 00:28:03 UTC (rev 176426)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-11-21 00:36:45 UTC (rev 176427)
@@ -4220,6 +4220,11 @@
{
}
+- (void)_handleClickInPreviewView:(NSView *)previewView URL:(NSURL *)url
+{
+ [[NSWorkspace sharedWorkspace] openURL:url];
+}
+
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- (void)_setAutomaticallyAdjustsContentInsets:(BOOL)automaticallyAdjustsContentInsets
Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (176426 => 176427)
--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-21 00:28:03 UTC (rev 176426)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-21 00:36:45 UTC (rev 176427)
@@ -999,7 +999,7 @@
- (void)pagePreviewViewControllerWasClicked:(WKPagePreviewViewController *)pagePreviewViewController
{
if (NSURL *url = ""
- [[NSWorkspace sharedWorkspace] openURL:url];
+ [_wkView _handleClickInPreviewView:pagePreviewViewController.view URL:url];
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
