Title: [176430] trunk/Source/WebKit2
- Revision
- 176430
- Author
- [email protected]
- Date
- 2014-11-20 18:10:33 -0800 (Thu, 20 Nov 2014)
Log Message
Preview popover needs minimum and maximum sizes
https://bugs.webkit.org/show_bug.cgi?id=138943
-and corresponding-
rdar://problem/18904651
Reviewed by Tim Horton.
Quick follow-up to get the right screen.
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController largestPopoverSize]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (176429 => 176430)
--- trunk/Source/WebKit2/ChangeLog 2014-11-21 01:52:41 UTC (rev 176429)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-21 02:10:33 UTC (rev 176430)
@@ -7,6 +7,19 @@
Reviewed by Tim Horton.
+ Quick follow-up to get the right screen.
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController largestPopoverSize]):
+
+2014-11-20 Beth Dakin <[email protected]>
+
+ Preview popover needs minimum and maximum sizes
+ https://bugs.webkit.org/show_bug.cgi?id=138943
+ -and corresponding-
+ rdar://problem/18904651
+
+ Reviewed by Tim Horton.
+
This patch enforces minimum and maximum popover sizes. If the popover needs to be
sized up to be above the minimum, it will end up covering some of the
_hitTestResult, so we should compute a new origin rect based on the original
Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (176429 => 176430)
--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-21 01:52:41 UTC (rev 176429)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-21 02:10:33 UTC (rev 176430)
@@ -360,7 +360,7 @@
- (NSSize)largestPopoverSize
{
- NSSize screenSize = [[NSScreen mainScreen] frame].size;
+ NSSize screenSize = _wkView.window.screen.frame.size;
if (screenSize.width == 1280 && screenSize.height == 800)
return NSMakeSize(1240, 674);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
