Title: [176484] trunk/Source/WebCore
- Revision
- 176484
- Author
- [email protected]
- Date
- 2014-11-21 16:11:51 -0800 (Fri, 21 Nov 2014)
Log Message
AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
https://bugs.webkit.org/show_bug.cgi?id=138905
Reviewed by Mario Sanchez Prada.
The crash log indicates that m_renderer is null at the time we ask ancestorsOfType().
This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.
Unable to determine cause of crash or how to reproduce on demand.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176483 => 176484)
--- trunk/Source/WebCore/ChangeLog 2014-11-22 00:07:46 UTC (rev 176483)
+++ trunk/Source/WebCore/ChangeLog 2014-11-22 00:11:51 UTC (rev 176484)
@@ -1,3 +1,18 @@
+2014-11-21 Chris Fleizach <[email protected]>
+
+ AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
+ https://bugs.webkit.org/show_bug.cgi?id=138905
+
+ Reviewed by Mario Sanchez Prada.
+
+ The crash log indicates that m_renderer is null at the time we ask ancestorsOfType().
+ This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.
+
+ Unable to determine cause of crash or how to reproduce on demand.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
+
2014-11-21 Jer Noble <[email protected]>
[EME][Mac] Check the underlying error if the one returned by AVFoundation is AVErrorUnknown.
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (176483 => 176484)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-11-22 00:07:46 UTC (rev 176483)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-11-22 00:11:51 UTC (rev 176484)
@@ -1164,6 +1164,9 @@
ASSERT(m_initialized);
#endif
+ if (!m_renderer)
+ return true;
+
// Check first if any of the common reasons cause this element to be ignored.
// Then process other use cases that need to be applied to all the various roles
// that AccessibilityRenderObjects take on.
@@ -1192,7 +1195,7 @@
return accessibilityIgnoreAttachment();
// ignore popup menu items because AppKit does
- if (ancestorsOfType<RenderMenuList>(*m_renderer).first())
+ if (m_renderer && ancestorsOfType<RenderMenuList>(*m_renderer).first())
return true;
// find out if this element is inside of a label element.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
