Title: [176487] trunk/Source/WebKit2
- Revision
- 176487
- Author
- [email protected]
- Date
- 2014-11-21 16:55:45 -0800 (Fri, 21 Nov 2014)
Log Message
WebVideoFullscreenManagerProxy must clear pointers when invalidated
https://bugs.webkit.org/show_bug.cgi?id=138982
Reviewed by Jer Noble.
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
(WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and
WebVideoFullscreenChangeObserver to NULL.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (176486 => 176487)
--- trunk/Source/WebKit2/ChangeLog 2014-11-22 00:51:20 UTC (rev 176486)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-22 00:55:45 UTC (rev 176487)
@@ -1,3 +1,15 @@
+2014-11-21 Eric Carlson <[email protected]>
+
+ WebVideoFullscreenManagerProxy must clear pointers when invalidated
+ https://bugs.webkit.org/show_bug.cgi?id=138982
+
+ Reviewed by Jer Noble.
+
+ * UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
+ (WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
+ (WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and
+ WebVideoFullscreenChangeObserver to NULL.
+
2014-11-21 Timothy Horton <[email protected]>
Fix the build.
Modified: trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm (176486 => 176487)
--- trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm 2014-11-22 00:51:20 UTC (rev 176486)
+++ trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm 2014-11-22 00:55:45 UTC (rev 176487)
@@ -67,13 +67,16 @@
{
if (!m_page)
return;
- m_page->process().removeMessageReceiver(Messages::WebVideoFullscreenManagerProxy::messageReceiverName(), m_page->pageID());
+ invalidate();
}
void WebVideoFullscreenManagerProxy::invalidate()
{
WebVideoFullscreenInterfaceAVKit::invalidate();
+ setWebVideoFullscreenModel(nullptr);
+ setWebVideoFullscreenChangeObserver(nullptr);
+
m_page->process().removeMessageReceiver(Messages::WebVideoFullscreenManagerProxy::messageReceiverName(), m_page->pageID());
m_page = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
