Title: [176504] trunk/Source/WebCore
- Revision
- 176504
- Author
- [email protected]
- Date
- 2014-11-22 02:11:13 -0800 (Sat, 22 Nov 2014)
Log Message
Remove unused Document::ignoreAutofocus().
<https://webkit.org/b/139002>
Reviewed by Antti Koivisto.
No one ever actually changes this flag, so let's remove it.
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176503 => 176504)
--- trunk/Source/WebCore/ChangeLog 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/ChangeLog 2014-11-22 10:11:13 UTC (rev 176504)
@@ -1,3 +1,20 @@
+2014-11-22 Andreas Kling <[email protected]>
+
+ Remove unused Document::ignoreAutofocus().
+ <https://webkit.org/b/139002>
+
+ Reviewed by Antti Koivisto.
+
+ No one ever actually changes this flag, so let's remove it.
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::ignoreAutofocus): Deleted.
+ (WebCore::Document::setIgnoreAutofocus): Deleted.
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::shouldAutofocus):
+
2014-11-22 Csaba Osztrogonác <[email protected]>
URTBF after r176459 to fix GTK build.
Modified: trunk/Source/WebCore/dom/Document.cpp (176503 => 176504)
--- trunk/Source/WebCore/dom/Document.cpp 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-11-22 10:11:13 UTC (rev 176504)
@@ -421,7 +421,6 @@
, m_wellFormed(false)
, m_printing(false)
, m_paginatedForScreen(false)
- , m_ignoreAutofocus(false)
, m_compatibilityMode(DocumentCompatibilityMode::NoQuirksMode)
, m_compatibilityModeLocked(false)
, m_textColor(Color::black)
Modified: trunk/Source/WebCore/dom/Document.h (176503 => 176504)
--- trunk/Source/WebCore/dom/Document.h 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/dom/Document.h 2014-11-22 10:11:13 UTC (rev 176504)
@@ -752,11 +752,6 @@
UserActionElementSet& userActionElements() { return m_userActionElements; }
const UserActionElementSet& userActionElements() const { return m_userActionElements; }
- // The m_ignoreAutofocus flag specifies whether or not the document has been changed by the user enough
- // for WebCore to ignore the autofocus attribute on any form controls
- bool ignoreAutofocus() const { return m_ignoreAutofocus; };
- void setIgnoreAutofocus(bool shouldIgnore = true) { m_ignoreAutofocus = shouldIgnore; };
-
void removeFocusedNodeOfSubtree(Node*, bool amongChildrenOnly = false);
void hoveredElementDidDetach(Element*);
void elementInActiveChainDidDetach(Element*);
@@ -1421,8 +1416,6 @@
bool m_printing;
bool m_paginatedForScreen;
- bool m_ignoreAutofocus;
-
DocumentCompatibilityMode m_compatibilityMode;
bool m_compatibilityModeLocked; // This is cheaper than making setCompatibilityMode virtual.
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (176503 => 176504)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-11-22 10:11:13 UTC (rev 176504)
@@ -181,8 +181,6 @@
return false;
if (!element->inDocument() || !element->document().renderView())
return false;
- if (element->document().ignoreAutofocus())
- return false;
if (element->document().isSandboxed(SandboxAutomaticFeatures)) {
// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
element->document().addConsoleMessage(MessageSource::Security, MessageLevel::Error, ASCIILiteral("Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set."));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
