[webkit-changes] [176530] trunk/Source/WebKit2

[benjamin]

Title: [176530] trunk/Source/WebKit2

Revision

176530

Author

benja...@webkit.org

Date

2014-11-24 16:26:35 -0800 (Mon, 24 Nov 2014)

Log Message

[WK2] Remove some bad stuff from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=138896

Patch by Benjamin Poulain <bpoul...@apple.com> on 2014-11-24
Reviewed by Sam Weinig.

The state loadStateAtProcessExit does not seem to be used anywhere.

The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::processDidExit):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.

Modified Paths

• trunk/Source/WebKit2/ChangeLog
• trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp
• trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
• trunk/Source/WebKit2/UIProcess/WebPageProxy.h

Diff

Modified: trunk/Source/WebKit2/ChangeLog (176529 => 176530)

--- trunk/Source/WebKit2/ChangeLog	2014-11-25 00:20:35 UTC (rev 176529)
+++ trunk/Source/WebKit2/ChangeLog	2014-11-25 00:26:35 UTC (rev 176530)
@@ -1,3 +1,25 @@
+2014-11-24  Benjamin Poulain  <bpoul...@apple.com>
+
+        [WK2] Remove some bad stuff from WebPageProxy
+        https://bugs.webkit.org/show_bug.cgi?id=138896
+
+        Reviewed by Sam Weinig.
+
+        The state loadStateAtProcessExit does not seem to be used anywhere.
+
+        The state urlAtProcessExit only exists to forward the url from
+        WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
+        WebView::processDidExit().
+
+        * UIProcess/CoordinatedGraphics/WebView.cpp:
+        (WebKit::WebView::processDidExit):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::WebPageProxy):
+        (WebKit::WebPageProxy::resetStateAfterProcessExited):
+        * UIProcess/WebPageProxy.h:
+        (WebKit::WebPageProxy::urlAtProcessExit): Deleted.
+        (WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.
+
 2014-11-24  Ryuan Choi  <ryuan.c...@navercorp.com>
 
         [EFL] REGRESSION(176066): It made all performance tests fail

Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp (176529 => 176530)

--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp	2014-11-25 00:20:35 UTC (rev 176529)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp	2014-11-25 00:26:35 UTC (rev 176530)
@@ -34,6 +34,8 @@
 #include "CoordinatedLayerTreeHostProxy.h"
 #include "NotImplemented.h"
 #include "ViewState.h"
+#include "WebBackForwardList.h"
+#include "WebBackForwardListItem.h"
 #include "WebContextMenuProxy.h"
 #include "WebPageProxy.h"
 
@@ -345,7 +347,7 @@
 
 void WebView::processDidExit()
 {
-    m_client.webProcessCrashed(this, m_page->urlAtProcessExit());
+    m_client.webProcessCrashed(this, m_page->backForwardList()->currentItem()->url());
 }
 
 void WebView::didRelaunchProcess()

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (176529 => 176530)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-11-25 00:20:35 UTC (rev 176529)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-11-25 00:26:35 UTC (rev 176530)
@@ -284,7 +284,6 @@
     , m_viewState(ViewState::NoFlags)
     , m_viewWasEverInWindow(false)
     , m_backForwardList(WebBackForwardList::create(*this))
-    , m_loadStateAtProcessExit(FrameLoadState::State::Finished)
 #if PLATFORM(MAC) && !USE(ASYNC_NSTEXTINPUTCLIENT)
     , m_temporarilyClosedComposition(false)
 #endif
@@ -4545,11 +4544,6 @@
     m_isValid = false;
     m_isPageSuspended = false;
 
-    if (m_mainFrame) {
-        m_urlAtProcessExit = m_mainFrame->url();
-        m_loadStateAtProcessExit = m_mainFrame->frameLoadState().m_state;
-    }
-
     m_pageClient.processDidExit();
 
     resetState(ResetStateReason::WebProcessExited);

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (176529 => 176530)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-11-25 00:20:35 UTC (rev 176529)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-11-25 00:26:35 UTC (rev 176530)
@@ -756,9 +756,6 @@
 
     bool isValid() const;
 
-    const String& urlAtProcessExit() const { return m_urlAtProcessExit; }
-    FrameLoadState::State loadStateAtProcessExit() const { return m_loadStateAtProcessExit; }
-
 #if ENABLE(DRAG_SUPPORT)
     WebCore::DragOperation currentDragOperation() const { return m_currentDragOperation; }
     bool currentDragIsOverFileInput() const { return m_currentDragIsOverFileInput; }
@@ -1420,9 +1417,6 @@
 
     String m_toolTip;
 
-    String m_urlAtProcessExit;
-    FrameLoadState::State m_loadStateAtProcessExit;
-
     EditorState m_editorState;
 #if PLATFORM(MAC) && !USE(ASYNC_NSTEXTINPUTCLIENT)
     bool m_temporarilyClosedComposition; // Editor state changed from hasComposition to !hasComposition, but that was only with shouldIgnoreCompositionSelectionChange yet.

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes