Title: [176560] trunk/Tools
Revision
176560
Author
[email protected]
Date
2014-11-28 01:50:18 -0800 (Fri, 28 Nov 2014)

Log Message

[EFL] Add warning if CMake version is too old for building with ninja.
https://bugs.webkit.org/show_bug.cgi?id=139055

Patch by Bartlomiej Gajda <[email protected]> on 2014-11-28
Reviewed by Gyuyoung Kim.

CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.

* efl/install-dependencies:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (176559 => 176560)


--- trunk/Tools/ChangeLog	2014-11-28 09:10:41 UTC (rev 176559)
+++ trunk/Tools/ChangeLog	2014-11-28 09:50:18 UTC (rev 176560)
@@ -1,3 +1,15 @@
+2014-11-28  Bartlomiej Gajda  <[email protected]>
+
+        [EFL] Add warning if CMake version is too old for building with ninja.
+        https://bugs.webkit.org/show_bug.cgi?id=139055
+
+        Reviewed by Gyuyoung Kim.
+
+        CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
+        that version in their repositories.
+
+        * efl/install-dependencies:
+
 2014-11-28  Andrzej Badowski  <[email protected]>
 
         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.

Modified: trunk/Tools/efl/install-dependencies (176559 => 176560)


--- trunk/Tools/efl/install-dependencies	2014-11-28 09:10:41 UTC (rev 176559)
+++ trunk/Tools/efl/install-dependencies	2014-11-28 09:50:18 UTC (rev 176560)
@@ -14,11 +14,34 @@
     exit 1
 }
 
+function checkCmakeVersion() {
+    CMAKE_VERSION=`cmake --version`
+
+    VERSION=`echo "$CMAKE_VERSION" | awk '{split($3,num,".");
+    if (!(num[1]>2 || num[2]>8 || num[3]>=10))
+        printf $3}'`
+
+    if [ -n "${VERSION}" ]; then
+        echo "Warning: CMake version detected (${VERSION}) is lower then 2.8.10."
+        echo "  This will probably cause errors, as older version didn't support CMAKE_NINJA_FORCE_RESPONSE_FILE,"
+        echo "  which is needed now for building. (look at: https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001809.html )"
+        echo ""
+
+        if [ -f "/etc/issue" ]; then
+            ubuntu_version=`cat /etc/issue`
+            if [[ $ubuntu_version == *Ubuntu\ 12.04* ]]; then
+                echo "  For Ubuntu 12.04 or 12.10 You might consider adding ppa from https://launchpad.net/~kalakris/+archive/ubuntu/cmake"
+            fi
+        fi
+    fi
+}
+
 function checkInstaller {
     # apt-get - Debian based distributions
     apt-get --version &> /dev/null
     if [ $? -eq 0 ]; then
         installDependenciesWithApt
+        checkCmakeVersion;
         exit 0
     fi
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to