Title: [176569] trunk/Source/WebKit2
Revision
176569
Author
[email protected]
Date
2014-11-28 14:09:01 -0800 (Fri, 28 Nov 2014)

Log Message

DataDetectors PageOverlay callbacks are never called
https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>

Reviewed by Anders Carlsson.

* Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (176568 => 176569)


--- trunk/Source/WebKit2/ChangeLog	2014-11-28 18:39:13 UTC (rev 176568)
+++ trunk/Source/WebKit2/ChangeLog	2014-11-28 22:09:01 UTC (rev 176569)
@@ -1,3 +1,16 @@
+2014-11-26  Timothy Horton  <[email protected]>
+
+        DataDetectors PageOverlay callbacks are never called
+        https://bugs.webkit.org/show_bug.cgi?id=139067
+        <rdar://problem/19086676>
+
+        Reviewed by Anders Carlsson.
+
+        * Shared/mac/ActionMenuHitTestResult.mm:
+        (WebKit::ActionMenuHitTestResult::encode):
+        (WebKit::ActionMenuHitTestResult::decode):
+        Encode/decode the PageOverlay ID.
+
 2014-11-28  Simon Fraser  <[email protected]>
 
         Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries

Modified: trunk/Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm (176568 => 176569)


--- trunk/Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm	2014-11-28 18:39:13 UTC (rev 176568)
+++ trunk/Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm	2014-11-28 22:09:01 UTC (rev 176569)
@@ -61,6 +61,7 @@
         IPC::encode(encoder, reinterpret_cast<CFDataRef>(data.get()));
 
         encoder << detectedDataBoundingBox;
+        encoder << detectedDataOriginatingPageOverlay;
 
         bool hasTextIndicator = detectedDataTextIndicator;
         encoder << hasTextIndicator;
@@ -113,6 +114,9 @@
         if (!decoder.decode(actionMenuHitTestResult.detectedDataBoundingBox))
             return false;
 
+        if (!decoder.decode(actionMenuHitTestResult.detectedDataOriginatingPageOverlay))
+            return false;
+
         bool hasTextIndicator;
         if (!decoder.decode(hasTextIndicator))
             return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to