Title: [176697] trunk/Source
Revision
176697
Author
[email protected]
Date
2014-12-02 16:32:33 -0800 (Tue, 02 Dec 2014)

Log Message

Remove a SnowLeopard-era quirk for QuickLook
https://bugs.webkit.org/show_bug.cgi?id=139208
<rdar://problem/19121822>

Reviewed by Alexey Proskuryakov.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* loader/FrameLoaderClient.h:
* platform/mac/QuickLookMac.h: Removed.
* platform/mac/QuickLookMac.mm: Removed.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

Removed Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (176696 => 176697)


--- trunk/Source/WebCore/ChangeLog	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/ChangeLog	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1,3 +1,20 @@
+2014-12-02  Tim Horton  <[email protected]>
+
+        Remove a SnowLeopard-era quirk for QuickLook
+        https://bugs.webkit.org/show_bug.cgi?id=139208
+        <rdar://problem/19121822>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCore.exp.in:
+        * WebCore.xcodeproj/project.pbxproj:
+        * loader/EmptyClients.h:
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::subresourceCachePolicy):
+        * loader/FrameLoaderClient.h:
+        * platform/mac/QuickLookMac.h: Removed.
+        * platform/mac/QuickLookMac.mm: Removed.
+
 2014-12-02  Anders Carlsson  <[email protected]>
 
         Begin stubbing out a StorageNamespaceProvider class

Modified: trunk/Source/WebCore/WebCore.exp.in (176696 => 176697)


--- trunk/Source/WebCore/WebCore.exp.in	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-12-03 00:32:33 UTC (rev 176697)
@@ -242,7 +242,6 @@
 __ZN7WebCore12PrintContext9spoolRectERNS_15GraphicsContextERKNS_7IntRectE
 __ZN7WebCore12PrintContextC1EPNS_5FrameE
 __ZN7WebCore12PrintContextD1Ev
-__ZN7WebCore12QuickLookMac42computeNeedsQuickLookResourceCachingQuirksEv
 __ZN7WebCore12RenderObject16paintingRootRectERNS_10LayoutRectE
 __ZN7WebCore12RenderObject19scrollRectToVisibleERKNS_10LayoutRectERKNS_15ScrollAlignmentES6_
 __ZN7WebCore12RenderWidget9setWidgetEN3WTF10PassRefPtrINS_6WidgetEEE

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (176696 => 176697)


--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1615,8 +1615,6 @@
 		45BAC2B01360BBAB005DA258 /* IconURL.h in Headers */ = {isa = PBXBuildFile; fileRef = 45BAC2AF1360BBAB005DA258 /* IconURL.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		45FEA5CF156DDE8C00654101 /* Decimal.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 45FEA5CD156DDE8C00654101 /* Decimal.cpp */; };
 		45FEA5D0156DDE8C00654101 /* Decimal.h in Headers */ = {isa = PBXBuildFile; fileRef = 45FEA5CE156DDE8C00654101 /* Decimal.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 4643782F19F720EF001E38B3 /* QuickLookMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4643783019F720EF001E38B3 /* QuickLookMac.mm */; };
 		4689F1AF1267BAE100E8D380 /* FileMetadata.h in Headers */ = {isa = PBXBuildFile; fileRef = 4689F1AE1267BAE100E8D380 /* FileMetadata.h */; };
 		490707E61219C04300D90E51 /* ANGLEWebKitBridge.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */; };
 		490707E71219C04300D90E51 /* ANGLEWebKitBridge.h in Headers */ = {isa = PBXBuildFile; fileRef = 490707E51219C04300D90E51 /* ANGLEWebKitBridge.h */; };
@@ -8711,8 +8709,6 @@
 		45BAC2AF1360BBAB005DA258 /* IconURL.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IconURL.h; sourceTree = "<group>"; };
 		45FEA5CD156DDE8C00654101 /* Decimal.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Decimal.cpp; sourceTree = "<group>"; };
 		45FEA5CE156DDE8C00654101 /* Decimal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Decimal.h; sourceTree = "<group>"; };
-		4643782F19F720EF001E38B3 /* QuickLookMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QuickLookMac.h; sourceTree = "<group>"; };
-		4643783019F720EF001E38B3 /* QuickLookMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = QuickLookMac.mm; sourceTree = "<group>"; };
 		4689F1AE1267BAE100E8D380 /* FileMetadata.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileMetadata.h; path = platform/FileMetadata.h; sourceTree = "<group>"; };
 		490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ANGLEWebKitBridge.cpp; sourceTree = "<group>"; };
 		490707E51219C04300D90E51 /* ANGLEWebKitBridge.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ANGLEWebKitBridge.h; sourceTree = "<group>"; };
@@ -16508,8 +16504,6 @@
 				BC94D1070C274F88006BC617 /* PlatformScreenMac.mm */,
 				29E4D8E016B0959800C84704 /* PlatformSpeechSynthesizerMac.mm */,
 				0081FEFE16B0A2B6008AAA7A /* PublicSuffixMac.mm */,
-				4643782F19F720EF001E38B3 /* QuickLookMac.h */,
-				4643783019F720EF001E38B3 /* QuickLookMac.mm */,
 				BCAE1FA512939DB7004CB026 /* ScrollAnimatorMac.h */,
 				BC51156D12B1749C00C96754 /* ScrollAnimatorMac.mm */,
 				BC8B853C0E7C7F1100AB6984 /* ScrollbarThemeMac.h */,
@@ -25727,7 +25721,6 @@
 				442AF7A9102CDDEA008FD4D3 /* QuickLook.h in Headers */,
 				CE1252391A166FA000864480 /* QuickLookSPI.h in Headers */,
 				A10DBF4718F92317000D70C6 /* QuickLookHandleClient.h in Headers */,
-				4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */,
 				072AE1E8183C0741000A5988 /* QuickTimePluginReplacement.h in Headers */,
 				379E371713736A6600B9E919 /* QuotedPrintable.h in Headers */,
 				5A574F29131DB96D00471B88 /* QuotesData.h in Headers */,
@@ -29212,7 +29205,6 @@
 				CDEE393717974259001D7580 /* PublicURLManager.cpp in Sources */,
 				550A0BC9085F6039007353D6 /* QualifiedName.cpp in Sources */,
 				442AF7AA102CDDEA008FD4D3 /* QuickLook.mm in Sources */,
-				4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */,
 				072AE1E6183C0741000A5988 /* QuickTimePluginReplacement.mm in Sources */,
 				379E371613736A6600B9E919 /* QuotedPrintable.cpp in Sources */,
 				5A574F28131DB96D00471B88 /* QuotesData.cpp in Sources */,

Modified: trunk/Source/WebCore/loader/EmptyClients.h (176696 => 176697)


--- trunk/Source/WebCore/loader/EmptyClients.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -403,10 +403,6 @@
     virtual void didRequestAutocomplete(PassRefPtr<FormState>) override { }
 #endif
 
-#if PLATFORM(MAC)
-    virtual bool needsQuickLookResourceCachingQuirks() const override { return false; }
-#endif
-
     virtual bool isEmptyFrameLoaderClient() override { return true; }
 };
 

Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (176696 => 176697)


--- trunk/Source/WebCore/loader/FrameLoader.cpp	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2014-12-03 00:32:33 UTC (rev 176697)
@@ -2152,11 +2152,6 @@
         return CachePolicyRevalidate;
 
     const ResourceRequest& request(documentLoader()->request());
-#if PLATFORM(MAC)
-    if (request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post") && m_client.needsQuickLookResourceCachingQuirks())
-        return CachePolicyRevalidate;
-#endif
-
     if (request.cachePolicy() == ReturnCacheDataElseLoad)
         return CachePolicyHistoryBuffer;
 

Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (176696 => 176697)


--- trunk/Source/WebCore/loader/FrameLoaderClient.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -283,10 +283,6 @@
 
         virtual void registerForIconNotification(bool listen = true) = 0;
 
-#if PLATFORM(MAC)
-        virtual bool needsQuickLookResourceCachingQuirks() const = 0;
-#endif
-
 #if PLATFORM(COCOA)
         // Allow an accessibility object to retrieve a Frame parent if there's no PlatformWidget.
         virtual RemoteAXObjectRef accessibilityRemoteObject() = 0;

Deleted: trunk/Source/WebCore/platform/mac/QuickLookMac.h (176696 => 176697)


--- trunk/Source/WebCore/platform/mac/QuickLookMac.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/platform/mac/QuickLookMac.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1,38 +0,0 @@
-/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef QuickLookMac_h
-#define QuickLookMac_h
-
-namespace WebCore {
-
-class QuickLookMac {
-public:
-    WEBCORE_EXPORT static bool computeNeedsQuickLookResourceCachingQuirks();
-};
-
-} // namespace WebCore
-
-#endif // QuickLookMac_h

Deleted: trunk/Source/WebCore/platform/mac/QuickLookMac.mm (176696 => 176697)


--- trunk/Source/WebCore/platform/mac/QuickLookMac.mm	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/platform/mac/QuickLookMac.mm	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1,51 +0,0 @@
-/*
- * Copyright (C) 2006, 2007, 2008, 2014 Apple, Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import "config.h"
-#import "QuickLookMac.h"
-
-#import "RuntimeApplicationChecks.h"
-
-namespace WebCore {
-
-bool QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
-{
-    if (applicationIsSafari())
-        return false;
-
-    NSArray *frameworks = [NSBundle allFrameworks];
-
-    if (!frameworks)
-        return false;
-
-    for (NSBundle *bundle in frameworks) {
-        NSString *bundleID = [bundle bundleIdentifier];
-        if (bundleID && [bundleID caseInsensitiveCompare:@"com.apple.QuickLookUIFramework"] == NSOrderedSame)
-            return true;
-    }
-    return false;
-}
-
-} // namespace WebCore

Modified: trunk/Source/WebKit/mac/ChangeLog (176696 => 176697)


--- trunk/Source/WebKit/mac/ChangeLog	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1,5 +1,16 @@
 2014-12-02  Tim Horton  <[email protected]>
 
+        Remove a SnowLeopard-era quirk for QuickLook
+        https://bugs.webkit.org/show_bug.cgi?id=139208
+        <rdar://problem/19121822>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebCoreSupport/WebFrameLoaderClient.h:
+        * WebCoreSupport/WebFrameLoaderClient.mm:
+
+2014-12-02  Tim Horton  <[email protected]>
+
         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
         https://bugs.webkit.org/show_bug.cgi?id=139204
 

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (176696 => 176697)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -239,10 +239,6 @@
     virtual void didCreateQuickLookHandle(WebCore::QuickLookHandle&) override;
 #endif
 
-#if PLATFORM(MAC)
-    virtual bool needsQuickLookResourceCachingQuirks() const override;
-#endif
-
     virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;
 
     RetainPtr<WebFrame> m_webFrame;

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (176696 => 176697)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm	2014-12-03 00:32:33 UTC (rev 176697)
@@ -2249,14 +2249,6 @@
 }
 #endif
 
-#if PLATFORM(MAC)
-bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
-{
-    static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
-    return shouldUseQuickLookResourceCachingQuirks;
-}
-#endif
-
 void WebFrameLoaderClient::contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter> contentFilter)
 {
     m_webFrame->_private->contentFilterForBlockedLoad = WTF::move(contentFilter);

Modified: trunk/Source/WebKit2/ChangeLog (176696 => 176697)


--- trunk/Source/WebKit2/ChangeLog	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1,3 +1,27 @@
+2014-12-02  Tim Horton  <[email protected]>
+
+        Remove a SnowLeopard-era quirk for QuickLook
+        https://bugs.webkit.org/show_bug.cgi?id=139208
+        <rdar://problem/19121822>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Shared/WebProcessCreationParameters.cpp:
+        (WebKit::WebProcessCreationParameters::encode):
+        (WebKit::WebProcessCreationParameters::decode):
+        * Shared/WebProcessCreationParameters.h:
+        * UIProcess/mac/WebContextMac.mm:
+        (WebKit::WebContext::platformInitializeWebProcess):
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::WebProcess):
+        * WebProcess/WebProcess.h:
+        (WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+
 2014-12-02  Beth Dakin  <[email protected]>
 
         Build fix.

Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (176696 => 176697)


--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-12-03 00:32:33 UTC (rev 176697)
@@ -108,7 +108,6 @@
 #if PLATFORM(COCOA)
     encoder << presenterApplicationPid;
     encoder << accessibilityEnhancedUserInterfaceEnabled;
-    encoder << needsQuickLookResourceCachingQuirks;
     encoder << nsURLCacheMemoryCapacity;
     encoder << nsURLCacheDiskCapacity;
     encoder << acceleratedCompositingPort;
@@ -237,8 +236,6 @@
         return false;
     if (!decoder.decode(parameters.accessibilityEnhancedUserInterfaceEnabled))
         return false;
-    if (!decoder.decode(parameters.needsQuickLookResourceCachingQuirks))
-        return false;
     if (!decoder.decode(parameters.nsURLCacheMemoryCapacity))
         return false;
     if (!decoder.decode(parameters.nsURLCacheDiskCapacity))

Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (176696 => 176697)


--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -126,7 +126,6 @@
     pid_t presenterApplicationPid;
 
     bool accessibilityEnhancedUserInterfaceEnabled;
-    bool needsQuickLookResourceCachingQuirks;
 
     uint64_t nsURLCacheMemoryCapacity;
     uint64_t nsURLCacheDiskCapacity;

Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (176696 => 176697)


--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-12-03 00:32:33 UTC (rev 176697)
@@ -167,11 +167,8 @@
 
 #if PLATFORM(MAC)
     parameters.accessibilityEnhancedUserInterfaceEnabled = [[NSApp accessibilityAttributeValue:@"AXEnhancedUserInterface"] boolValue];
-    static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
-    parameters.needsQuickLookResourceCachingQuirks = shouldUseQuickLookResourceCachingQuirks;
 #else
     parameters.accessibilityEnhancedUserInterfaceEnabled = false;
-    parameters.needsQuickLookResourceCachingQuirks = false;
 #endif
 
     NSURLCache *urlCache = [NSURLCache sharedURLCache];

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (176696 => 176697)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-12-03 00:32:33 UTC (rev 176697)
@@ -1642,11 +1642,4 @@
 }
 #endif
 
-#if PLATFORM(MAC)
-bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
-{
-    return WebProcess::shared().needsQuickLookResourceCachingQuirks();
-}
-#endif
-
 } // namespace WebKit

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (176696 => 176697)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -231,10 +231,6 @@
     virtual void didCreateQuickLookHandle(WebCore::QuickLookHandle&) override;
 #endif
 
-#if PLATFORM(MAC)
-    virtual bool needsQuickLookResourceCachingQuirks() const override;
-#endif
-
 #if ENABLE(CONTENT_FILTERING)
     virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;
 #endif

Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (176696 => 176697)


--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2014-12-03 00:32:33 UTC (rev 176697)
@@ -161,9 +161,6 @@
     , m_compositingRenderServerPort(MACH_PORT_NULL)
     , m_clearResourceCachesDispatchGroup(0)
 #endif
-#if PLATFORM(MAC)
-    , m_needsQuickLookResourceCachingQuirks(false)
-#endif
     , m_fullKeyboardAccessEnabled(false)
     , m_textCheckerState()
     , m_iconDatabaseProxy(new WebIconDatabaseProxy(this))

Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (176696 => 176697)


--- trunk/Source/WebKit2/WebProcess/WebProcess.h	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h	2014-12-03 00:32:33 UTC (rev 176697)
@@ -118,10 +118,6 @@
     mach_port_t compositingRenderServerPort() const { return m_compositingRenderServerPort; }
 #endif
 
-#if PLATFORM(MAC)
-    bool needsQuickLookResourceCachingQuirks() const { return m_needsQuickLookResourceCachingQuirks; }
-#endif
-
     bool shouldPlugInAutoStartFromOrigin(WebPage&, const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
     void plugInDidStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
     void plugInDidReceiveUserInteraction(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
@@ -323,9 +319,6 @@
     dispatch_group_t m_clearResourceCachesDispatchGroup;
     bool m_shouldForceScreenFontSubstitution;
 #endif
-#if PLATFORM(MAC)
-    bool m_needsQuickLookResourceCachingQuirks;
-#endif
 
     bool m_fullKeyboardAccessEnabled;
 

Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm (176696 => 176697)


--- trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2014-12-03 00:32:33 UTC (rev 176697)
@@ -195,9 +195,6 @@
     MemoryPressureHandler::ReliefLogger::setLoggingEnabled(parameters.shouldEnableMemoryPressureReliefLogging);
 
     setEnhancedAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled);
-#if PLATFORM(MAC)
-    m_needsQuickLookResourceCachingQuirks = parameters.needsQuickLookResourceCachingQuirks;
-#endif
 
 #if USE(APPKIT)
     [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to