Title: [176734] trunk/Source/WebCore
- Revision
- 176734
- Author
- [email protected]
- Date
- 2014-12-03 12:03:06 -0800 (Wed, 03 Dec 2014)
Log Message
Subtitle menu should only appear when useful.
https://bugs.webkit.org/show_bug.cgi?id=139133
Patch by Jeremy Jones <[email protected]> on 2014-12-03
Reviewed by Eric Carlson.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
(-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176733 => 176734)
--- trunk/Source/WebCore/ChangeLog 2014-12-03 19:59:27 UTC (rev 176733)
+++ trunk/Source/WebCore/ChangeLog 2014-12-03 20:03:06 UTC (rev 176734)
@@ -1,3 +1,14 @@
+2014-12-03 Jeremy Jones <[email protected]>
+
+ Subtitle menu should only appear when useful.
+ https://bugs.webkit.org/show_bug.cgi?id=139133
+
+ Reviewed by Eric Carlson.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
+ (-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.
+
2014-12-03 Joanmarie Diggs <[email protected]>
AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (176733 => 176734)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2014-12-03 19:59:27 UTC (rev 176733)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2014-12-03 20:03:06 UTC (rev 176734)
@@ -385,7 +385,7 @@
- (BOOL)hasAudioMediaSelectionOptions
{
- return [[self audioMediaSelectionOptions] count] > 0;
+ return [[self audioMediaSelectionOptions] count] > 1;
}
+ (NSSet *)keyPathsForValuesAffectingHasAudioMediaSelectionOptions
@@ -395,7 +395,8 @@
- (BOOL)hasLegibleMediaSelectionOptions
{
- return [[self legibleMediaSelectionOptions] count] > 0;
+ const NSUInteger numDefaultLegibleOptions = 2;
+ return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions;
}
+ (NSSet *)keyPathsForValuesAffectingHasLegibleMediaSelectionOptions
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
