Title: [176800] trunk/Tools
Revision
176800
Author
[email protected]
Date
2014-12-04 09:18:14 -0800 (Thu, 04 Dec 2014)

Log Message

http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
https://bugs.webkit.org/show_bug.cgi?id=139243

Reviewed by Anders Carlsson.

We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
chance to allow untrusted certificates.

* WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
Set up more client objects for secondary windows. We may be able to share some of the
code with main view creation function, but it's not exactly the same (notably, we
do not focus a secondary window when it's done loading).

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (176799 => 176800)


--- trunk/Tools/ChangeLog	2014-12-04 17:11:04 UTC (rev 176799)
+++ trunk/Tools/ChangeLog	2014-12-04 17:18:14 UTC (rev 176800)
@@ -1,3 +1,18 @@
+2014-12-03  Alexey Proskuryakov  <[email protected]>
+
+        http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
+        https://bugs.webkit.org/show_bug.cgi?id=139243
+
+        Reviewed by Anders Carlsson.
+
+        We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
+        chance to allow untrusted certificates.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
+        Set up more client objects for secondary windows. We may be able to share some of the
+        code with main view creation function, but it's not exactly the same (notably, we
+        do not focus a secondary window when it's done loading).
+
 2014-12-03  Joanmarie Diggs  <[email protected]>
 
         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed

Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (176799 => 176800)


--- trunk/Tools/WebKitTestRunner/TestController.cpp	2014-12-04 17:11:04 UTC (rev 176799)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2014-12-04 17:18:14 UTC (rev 176800)
@@ -265,6 +265,61 @@
     };
     WKPageSetPageUIClient(newPage, &otherPageUIClient.base);
 
+    WKPageLoaderClientV5 pageLoaderClient = {
+        { 5, clientInfo },
+        0, // didStartProvisionalLoadForFrame
+        0, // didReceiveServerRedirectForProvisionalLoadForFrame
+        0, // didFailProvisionalLoadWithErrorForFrame
+        0, // didCommitLoadForFrame,
+        0, // didFinishDocumentLoadForFrame
+        0, // didFinishLoadForFrame,
+        0, // didFailLoadWithErrorForFrame
+        0, // didSameDocumentNavigationForFrame
+        0, // didReceiveTitleForFrame
+        0, // didFirstLayoutForFrame
+        0, // didFirstVisuallyNonEmptyLayoutForFrame
+        0, // didRemoveFrameFromHierarchy
+        0, // didFailToInitializePlugin
+        0, // didDisplayInsecureContentForFrame
+        canAuthenticateAgainstProtectionSpaceInFrame,
+        didReceiveAuthenticationChallengeInFrame,
+        0, // didStartProgress
+        0, // didChangeProgress
+        0, // didFinishProgress
+        0, // didBecomeUnresponsive
+        0, // didBecomeResponsive
+        processDidCrash,
+        0, // didChangeBackForwardList
+        0, // shouldGoToBackForwardListItem
+        0, // didRunInsecureContentForFrame
+        0, // didDetectXSSForFrame
+        0, // didNewFirstVisuallyNonEmptyLayout_unavailable
+        0, // willGoToBackForwardListItem
+        0, // interactionOccurredWhileProcessUnresponsive
+        0, // pluginDidFail_deprecatedForUseWithV1
+        0, // didReceiveIntentForFrame
+        0, // registerIntentServiceForFrame
+        0, // didLayout
+        0, // pluginLoadPolicy_deprecatedForUseWithV2
+        0, // pluginDidFail
+        pluginLoadPolicy, // pluginLoadPolicy
+        0, // webGLLoadPolicy
+        0, // resolveWebGLLoadPolicy
+        0, // shouldKeepCurrentBackForwardListItemInList
+    };
+    WKPageSetPageLoaderClient(view->page(), &pageLoaderClient.base);
+
+    WKPagePolicyClientV1 pagePolicyClient = {
+        { 1, clientInfo },
+        0, // decidePolicyForNavigationAction_deprecatedForUseWithV0
+        0, // decidePolicyForNewWindowAction
+        0, // decidePolicyForResponse_deprecatedForUseWithV0
+        0, // unableToImplementPolicy
+        decidePolicyForNavigationAction,
+        decidePolicyForResponse,
+    };
+    WKPageSetPagePolicyClient(view->page(), &pagePolicyClient.base);
+
     view->didInitializeClients();
 
     WKRetain(newPage);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to