Title: [176815] trunk
- Revision
- 176815
- Author
- [email protected]
- Date
- 2014-12-04 13:56:04 -0800 (Thu, 04 Dec 2014)
Log Message
Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
https://bugs.webkit.org/show_bug.cgi?id=138898
Reviewed by Mark Rowe.
Source/WebInspectorUI:
In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
we will copy all resources (for Tests) and still do the combine and
optimize phase for normal Production inspection resources.
* Scripts/copy-user-interface-resources.pl:
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (176814 => 176815)
--- trunk/LayoutTests/ChangeLog 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/LayoutTests/ChangeLog 2014-12-04 21:56:04 UTC (rev 176815)
@@ -1,3 +1,12 @@
+2014-12-04 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
+ https://bugs.webkit.org/show_bug.cgi?id=138898
+
+ Reviewed by Mark Rowe.
+
+ * platform/mac/TestExpectations:
+
2014-12-04 Eva Balazsfalvi <[email protected]>
[EFL][WebGL] Remove junk webgl layout tests from TestExpectations
Modified: trunk/LayoutTests/platform/mac/TestExpectations (176814 => 176815)
--- trunk/LayoutTests/platform/mac/TestExpectations 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-12-04 21:56:04 UTC (rev 176815)
@@ -1413,19 +1413,17 @@
# FIXME: Needs bugzilla (<rdar://problem/18273139>)
[ Yosemite+ ] storage/websql/sql-error-codes.html [ Failure ]
-# Some inspector tests fail when run from Production builds due to missing test resources.
-# FIXME: Needs bugzilla (<rdar://problem/16200275>)
# Also, these tests are flaky in Debug/Release builds, <https://bugs.webkit.org/show_bug.cgi?id=138636>
# and <https://bugs.webkit.org/show_bug.cgi?id=129817>.
-[ Yosemite+ ] inspector/css/matched-style-properties.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/css/pseudo-element-matches.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/css/selector-specificity.html [ Pass Failure Crash ]
+[ Yosemite+ ] inspector/css/matched-style-properties.html [ Pass Failure ]
+[ Yosemite+ ] inspector/css/pseudo-element-matches.html [ Pass Failure ]
+[ Yosemite+ ] inspector/css/selector-specificity.html [ Pass Failure ]
[ Yosemite+ ] inspector/dom/content-flow-content-removal.html [ Skip ]
[ Yosemite+ ] inspector/dom/content-flow-list.html [ Skip ]
-[ Yosemite+ ] inspector/event-listener-set.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/event-listener.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/model/parse-script-syntax-tree.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/protocol-promise-result.html [ Pass Failure Crash ]
+[ Yosemite+ ] inspector/event-listener-set.html [ Pass Failure ]
+[ Yosemite+ ] inspector/event-listener.html [ Pass Failure ]
+[ Yosemite+ ] inspector/model/parse-script-syntax-tree.html [ Pass Failure ]
+[ Yosemite+ ] inspector/protocol-promise-result.html [ Pass Failure ]
[ Yosemite+ ] inspector/test-harness-trivially-works.html [ Skip ]
# Specific to Yosemite's font fallback
Modified: trunk/Source/WebInspectorUI/ChangeLog (176814 => 176815)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 21:56:04 UTC (rev 176815)
@@ -1,3 +1,16 @@
+2014-12-04 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
+ https://bugs.webkit.org/show_bug.cgi?id=138898
+
+ Reviewed by Mark Rowe.
+
+ In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
+ we will copy all resources (for Tests) and still do the combine and
+ optimize phase for normal Production inspection resources.
+
+ * Scripts/copy-user-interface-resources.pl:
+
2014-12-03 Joseph Pecoraro <[email protected]>
Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
Modified: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (176814 => 176815)
--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2014-12-04 21:56:04 UTC (rev 176815)
@@ -111,6 +111,13 @@
# Copy over dynamically loaded files from other frameworks, even if we aren't combining resources.
copy(File::Spec->catfile($ENV{'_javascript_CORE_PRIVATE_HEADERS_DIR'}, 'InspectorBackendCommands.js'), File::Spec->catfile($protocolDir, 'InspectorBackendCommands.js')) or die "Copy of InspectorBackendCommands.js failed: $!";
+if (defined $ENV{'FORCE_TOOL_INSTALL'} && ($ENV{'FORCE_TOOL_INSTALL'} eq 'YES')) {
+ # Copy all files over individually to ensure we have Test.html / Test.js and files included from Test.html.
+ # We may then proceed to include combined & optimized resources which will output mostly to different paths
+ # but overwrite Main.html / Main.js with optimized versions.
+ ditto($uiRoot, $targetResourcePath);
+}
+
if (defined $ENV{'COMBINE_INSPECTOR_RESOURCES'} && ($ENV{'COMBINE_INSPECTOR_RESOURCES'} eq 'YES')) {
my $combineResourcesCmd = File::Spec->catfile($scriptsRoot, 'combine-resources.pl');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
