Title: [176819] trunk/Source/WebInspectorUI
- Revision
- 176819
- Author
- [email protected]
- Date
- 2014-12-04 14:56:01 -0800 (Thu, 04 Dec 2014)
Log Message
Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
https://bugs.webkit.org/show_bug.cgi?id=139268
Patch by Joseph Pecoraro <[email protected]> on 2014-12-04
Reviewed by Brian Burg.
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.createColumnScopeBar):
Users of createColumnScopeBar pass a Map object now instead of a dictionary.
Iterate over the map appropriately.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (176818 => 176819)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 22:48:24 UTC (rev 176818)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 22:56:01 UTC (rev 176819)
@@ -1,5 +1,17 @@
2014-12-04 Joseph Pecoraro <[email protected]>
+ Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
+ https://bugs.webkit.org/show_bug.cgi?id=139268
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.createColumnScopeBar):
+ Users of createColumnScopeBar pass a Map object now instead of a dictionary.
+ Iterate over the map appropriately.
+
+2014-12-04 Joseph Pecoraro <[email protected]>
+
Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
https://bugs.webkit.org/show_bug.cgi?id=138898
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (176818 => 176819)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2014-12-04 22:48:24 UTC (rev 176818)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2014-12-04 22:56:01 UTC (rev 176819)
@@ -73,17 +73,17 @@
FiltersDidChange: "timelinedatagrid-filters-did-change"
};
-WebInspector.TimelineDataGrid.createColumnScopeBar = function(prefix, dictionary)
+WebInspector.TimelineDataGrid.createColumnScopeBar = function(prefix, map)
{
prefix = prefix + "-timeline-data-grid-";
- var scopeBarItems = Object.keys(dictionary).map(function(key) {
+ var scopeBarItems = [];
+ for (var [key, value] of map) {
var id = prefix + key;
- var label = dictionary[key];
- var item = new WebInspector.ScopeBarItem(id, label);
+ var item = new WebInspector.ScopeBarItem(id, value);
item.value = key;
- return item;
- });
+ scopeBarItems.push(item);
+ }
scopeBarItems.unshift(new WebInspector.ScopeBarItem(prefix + "type-all", WebInspector.UIString("All"), true));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
