Title: [176853] trunk/Source/WebInspectorUI
- Revision
- 176853
- Author
- [email protected]
- Date
- 2014-12-05 10:48:05 -0800 (Fri, 05 Dec 2014)
Log Message
Web Inspector: Uncaught Exceptions when attempting to show Content Flow
https://bugs.webkit.org/show_bug.cgi?id=139276
Patch by Joseph Pecoraro <[email protected]> on 2014-12-05
Reviewed by Brian Burg.
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
LegacyJavaScriptProfileObject no longer exists, these references should be removed.
* UserInterface/Views/FolderizedTreeElement.js:
(WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
This sort function references "this" and needed to be bound.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (176852 => 176853)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-05 18:46:56 UTC (rev 176852)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-05 18:48:05 UTC (rev 176853)
@@ -1,3 +1,19 @@
+2014-12-05 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Uncaught Exceptions when attempting to show Content Flow
+ https://bugs.webkit.org/show_bug.cgi?id=139276
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ContentView.js:
+ (WebInspector.ContentView):
+ (WebInspector.ContentView.isViewable):
+ LegacyJavaScriptProfileObject no longer exists, these references should be removed.
+
+ * UserInterface/Views/FolderizedTreeElement.js:
+ (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
+ This sort function references "this" and needed to be bound.
+
2014-12-04 Joseph Pecoraro <[email protected]>
Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (176852 => 176853)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2014-12-05 18:46:56 UTC (rev 176852)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2014-12-05 18:48:05 UTC (rev 176853)
@@ -69,9 +69,6 @@
if (representedObject instanceof WebInspector.LogObject)
return new WebInspector.LogContentView(representedObject);
- if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
- return new WebInspector.LegacyJavaScriptProfileView(representedObject);
-
if (representedObject instanceof WebInspector.ContentFlow)
return new WebInspector.ContentFlowDOMTreeContentView(representedObject);
@@ -127,8 +124,6 @@
return true;
if (representedObject instanceof WebInspector.LogObject)
return true;
- if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
- return true;
if (representedObject instanceof WebInspector.ContentFlow)
return true;
if (typeof representedObject === "string" || representedObject instanceof String)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js (176852 => 176853)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2014-12-05 18:46:56 UTC (rev 176852)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2014-12-05 18:48:05 UTC (rev 176853)
@@ -237,7 +237,7 @@
_insertChildTreeElement: function(parentTreeElement, childTreeElement)
{
console.assert(!childTreeElement.parent);
- parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements));
+ parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements.bind(this)));
},
_removeTreeElement: function(childTreeElement, suppressOnDeselect, suppressSelectSibling)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
