Title: [176903] trunk
- Revision
- 176903
- Author
- [email protected]
- Date
- 2014-12-05 21:14:12 -0800 (Fri, 05 Dec 2014)
Log Message
Directional single quotation marks are not rotated in vertical text
https://bugs.webkit.org/show_bug.cgi?id=138526
Source/WebCore:
Reviewed by Darin Adler.
In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.
Test: fast/text/vertical-quotation-marks.html
* platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):
LayoutTests:
Compare vertical and horizontal renderings.
Reviewed by Darin Adler.
* fast/text/vertical-quotation-marks-expected.html: Added.
* fast/text/vertical-quotation-marks.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (176902 => 176903)
--- trunk/LayoutTests/ChangeLog 2014-12-06 05:09:11 UTC (rev 176902)
+++ trunk/LayoutTests/ChangeLog 2014-12-06 05:14:12 UTC (rev 176903)
@@ -1,3 +1,15 @@
+2014-12-05 Myles C. Maxfield <[email protected]>
+
+ Directional single quotation marks are not rotated in vertical text
+ https://bugs.webkit.org/show_bug.cgi?id=138526
+
+ Compare vertical and horizontal renderings.
+
+ Reviewed by Darin Adler.
+
+ * fast/text/vertical-quotation-marks-expected.html: Added.
+ * fast/text/vertical-quotation-marks.html: Added.
+
2014-12-05 Dhi Aurrahman <[email protected]>
Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
Added: trunk/LayoutTests/fast/text/vertical-quotation-marks-expected.html (0 => 176903)
--- trunk/LayoutTests/fast/text/vertical-quotation-marks-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/vertical-quotation-marks-expected.html 2014-12-06 05:14:12 UTC (rev 176903)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<div style="line-height: 50px; -webkit-transform-origin: left bottom; -webkit-transform: rotate(90deg) translateX(-50px); display: inline-block">
+What’s going‘ on?
+</div>
+</body>
+</html
Added: trunk/LayoutTests/fast/text/vertical-quotation-marks.html (0 => 176903)
--- trunk/LayoutTests/fast/text/vertical-quotation-marks.html (rev 0)
+++ trunk/LayoutTests/fast/text/vertical-quotation-marks.html 2014-12-06 05:14:12 UTC (rev 176903)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<div style="line-height: 50px; -webkit-writing-mode:vertical-rl;">
+What’s going‘ on?
+</div>
+</body>
+</html
Modified: trunk/Source/WebCore/ChangeLog (176902 => 176903)
--- trunk/Source/WebCore/ChangeLog 2014-12-06 05:09:11 UTC (rev 176902)
+++ trunk/Source/WebCore/ChangeLog 2014-12-06 05:14:12 UTC (rev 176903)
@@ -1,3 +1,18 @@
+2014-12-05 Myles C. Maxfield <[email protected]>
+
+ Directional single quotation marks are not rotated in vertical text
+ https://bugs.webkit.org/show_bug.cgi?id=138526
+
+ Reviewed by Darin Adler.
+
+ In vertical text, directional single quotation marks are not rotated along with
+ the rest of the letters.
+
+ Test: fast/text/vertical-quotation-marks.html
+
+ * platform/graphics/FontGlyphs.cpp:
+ (WebCore::shouldIgnoreRotation):
+
2014-12-05 Dhi Aurrahman <[email protected]>
Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
Modified: trunk/Source/WebCore/platform/graphics/FontGlyphs.cpp (176902 => 176903)
--- trunk/Source/WebCore/platform/graphics/FontGlyphs.cpp 2014-12-06 05:09:11 UTC (rev 176902)
+++ trunk/Source/WebCore/platform/graphics/FontGlyphs.cpp 2014-12-06 05:14:12 UTC (rev 176903)
@@ -145,8 +145,7 @@
if (isInRange(character, 0x01100, 0x011FF) || isInRange(character, 0x01401, 0x0167F) || isInRange(character, 0x01800, 0x018FF))
return true;
- if (character == 0x02016 || character == 0x02018 || character == 0x02019 || character == 0x02020 || character == 0x02021
- || character == 0x2030 || character == 0x02031)
+ if (character == 0x02016 || character == 0x02020 || character == 0x02021 || character == 0x2030 || character == 0x02031)
return true;
if (isInRange(character, 0x0203B, 0x0203D) || character == 0x02042 || character == 0x02044 || character == 0x02047
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
