Title: [176916] trunk/Source/WebCore
- Revision
- 176916
- Author
- [email protected]
- Date
- 2014-12-06 15:35:06 -0800 (Sat, 06 Dec 2014)
Log Message
URTBF after r176915.
DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
such as GTK, EFL, Apple Windows.
Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
guard, so there is no reason to define it for non COCOA platforms.
* platform/graphics/GraphicsLayerUpdater.cpp:
* platform/graphics/GraphicsLayerUpdater.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176915 => 176916)
--- trunk/Source/WebCore/ChangeLog 2014-12-06 21:44:36 UTC (rev 176915)
+++ trunk/Source/WebCore/ChangeLog 2014-12-06 23:35:06 UTC (rev 176916)
@@ -1,3 +1,20 @@
+2014-12-06 Csaba Osztrogonác <[email protected]>
+
+ URTBF after r176915.
+
+ DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
+ only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
+ is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
+
+ That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
+ such as GTK, EFL, Apple Windows.
+
+ Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
+ guard, so there is no reason to define it for non COCOA platforms.
+
+ * platform/graphics/GraphicsLayerUpdater.cpp:
+ * platform/graphics/GraphicsLayerUpdater.h:
+
2014-12-06 Anders Carlsson <[email protected]>
Fix build with newer versions of clang.
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp (176915 => 176916)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp 2014-12-06 21:44:36 UTC (rev 176915)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp 2014-12-06 23:35:06 UTC (rev 176916)
@@ -69,6 +69,7 @@
#endif
}
+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
void GraphicsLayerUpdater::displayRefreshFired(double timestamp)
{
UNUSED_PARAM(timestamp);
@@ -77,6 +78,7 @@
if (m_client)
m_client->flushLayersSoon(this);
}
+#endif
#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
PassRefPtr<DisplayRefreshMonitor> GraphicsLayerUpdater::createDisplayRefreshMonitor(PlatformDisplayID displayID) const
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h (176915 => 176916)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h 2014-12-06 21:44:36 UTC (rev 176915)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h 2014-12-06 23:35:06 UTC (rev 176916)
@@ -59,7 +59,9 @@
#endif
private:
+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
virtual void displayRefreshFired(double timestamp) override;
+#endif
GraphicsLayerUpdaterClient* m_client;
bool m_scheduled;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
