Title: [176923] trunk/Tools
- Revision
- 176923
- Author
- [email protected]
- Date
- 2014-12-07 08:23:31 -0800 (Sun, 07 Dec 2014)
Log Message
Remove the option to automatically update the GObject DOM bindings symbols file
https://bugs.webkit.org/show_bug.cgi?id=139366
Reviewed by Martin Robinson.
It's currently broken, because symbols now need to be in a
specific order. Now that the symbols file only contains stable
API, it's not a problem to manually update it every time new API
is added.
* gtk/check-for-webkitdom-api-breaks:
(read_expected_api):
(check_api):
(write_expected_api): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (176922 => 176923)
--- trunk/Tools/ChangeLog 2014-12-07 16:11:01 UTC (rev 176922)
+++ trunk/Tools/ChangeLog 2014-12-07 16:23:31 UTC (rev 176923)
@@ -1,5 +1,22 @@
2014-12-07 Carlos Garcia Campos <[email protected]>
+ Remove the option to automatically update the GObject DOM bindings symbols file
+ https://bugs.webkit.org/show_bug.cgi?id=139366
+
+ Reviewed by Martin Robinson.
+
+ It's currently broken, because symbols now need to be in a
+ specific order. Now that the symbols file only contains stable
+ API, it's not a problem to manually update it every time new API
+ is added.
+
+ * gtk/check-for-webkitdom-api-breaks:
+ (read_expected_api):
+ (check_api):
+ (write_expected_api): Deleted.
+
+2014-12-07 Carlos Garcia Campos <[email protected]>
+
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831
Modified: trunk/Tools/gtk/check-for-webkitdom-api-breaks (176922 => 176923)
--- trunk/Tools/gtk/check-for-webkitdom-api-breaks 2014-12-07 16:11:01 UTC (rev 176922)
+++ trunk/Tools/gtk/check-for-webkitdom-api-breaks 2014-12-07 16:23:31 UTC (rev 176923)
@@ -16,7 +16,6 @@
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-import argparse
import common
import os
import sys
@@ -35,11 +34,7 @@
with open(EXPECTED_API_PATH) as file_handle:
return set(file_handle.readlines())
-def write_expected_api(new_expected_api):
- with open(EXPECTED_API_PATH, 'w') as file_handle:
- file_handle.writelines(new_expected_api)
-
-def check_api(options, expected_api, built_api):
+def check_api(expected_api, built_api):
missing_api = expected_api.difference(built_api)
new_api = built_api.difference(expected_api)
@@ -57,22 +52,12 @@
# DOM bindings API varies depending on the compilation options.
# So this shouldn't be made fatal until we figure out a way to handle it.
# See https://bugs.webkit.org/show_bug.cgi?id=121481
- sys.stderr.write("Re-add the missing API and rerun the %s.\n" % __file__)
return 0
if new_api:
- if options.reset_results:
- sys.stdout.write("Resetting expected API\n")
- write_expected_api(built_api)
- else:
- sys.stdout.write("API compatible changes found in GObject DOM bindings.\n")
- sys.stdout.write("To update the symbols file, run %s --reset-results.\n" % __file__)
+ sys.stdout.write("API compatible changes found in GObject DOM bindings.\n")
return 0
if __name__ == '__main__':
- parser = argparse.ArgumentParser(description='Detect API breakage in the WebKitGTK+ GObject DOM bindings.')
- parser.add_argument('--reset-results', action='',
- help='When specified, rest the expected results file with the built results.')
- options = parser.parse_args()
- sys.exit(check_api(options, read_expected_api(), read_built_api()))
+ sys.exit(check_api(read_expected_api(), read_built_api()))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
