Title: [177057] trunk/Source/WebKit2
- Revision
- 177057
- Author
- g.czajkow...@samsung.com
- Date
- 2014-12-10 05:00:05 -0800 (Wed, 10 Dec 2014)
Log Message
[EFL][[WK2] test_ewk2_text_checker is failed
https://bugs.webkit.org/show_bug.cgi?id=132982
Reviewed by Gyuyoung Kim.
Insert misspelled word to the input field using execCommand instead of
input.value attribute change which stops spell check, tracked by
https://bugs.webkit.org/show_bug.cgi?id=139473.
Since text checker API tests do not verify spellchecker itself (it's being
tested by LayoutTests/editing/spelling) but rather opportunity for overriding
its functionality this patch unskips those tests in order to API coverage.
* PlatformEfl.cmake:
Unskip test_ewk2_text_checker
* UIProcess/API/efl/tests/resources/spelling_test.html:
Use document.execCommand("InsertText", false, "aa ") instead of
input.value = "aa " to trigger spellchecker.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (177056 => 177057)
--- trunk/Source/WebKit2/ChangeLog 2014-12-10 12:51:17 UTC (rev 177056)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-10 13:00:05 UTC (rev 177057)
@@ -1,3 +1,25 @@
+2014-12-10 Grzegorz Czajkowski <g.czajkow...@samsung.com>
+
+ [EFL][[WK2] test_ewk2_text_checker is failed
+ https://bugs.webkit.org/show_bug.cgi?id=132982
+
+ Reviewed by Gyuyoung Kim.
+
+ Insert misspelled word to the input field using execCommand instead of
+ input.value attribute change which stops spell check, tracked by
+ https://bugs.webkit.org/show_bug.cgi?id=139473.
+
+ Since text checker API tests do not verify spellchecker itself (it's being
+ tested by LayoutTests/editing/spelling) but rather opportunity for overriding
+ its functionality this patch unskips those tests in order to API coverage.
+
+ * PlatformEfl.cmake:
+ Unskip test_ewk2_text_checker
+
+ * UIProcess/API/efl/tests/resources/spelling_test.html:
+ Use document.execCommand("InsertText", false, "aa ") instead of
+ input.value = "aa " to trigger spellchecker.
+
2014-12-10 Carlos Alberto Lopez Perez <clo...@igalia.com>
REGRESSION(r177038): [SOUP] [GTK] Debug build broken
Modified: trunk/Source/WebKit2/PlatformEfl.cmake (177056 => 177057)
--- trunk/Source/WebKit2/PlatformEfl.cmake 2014-12-10 12:51:17 UTC (rev 177056)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2014-12-10 13:00:05 UTC (rev 177057)
@@ -517,6 +517,7 @@
test_ewk2_settings
test_ewk2_ssl
test_ewk2_storage_manager
+ test_ewk2_text_checker
test_ewk2_view
test_ewk2_window_features
)
@@ -526,7 +527,6 @@
# webkit.org/b/107422: test_ewk2_auth_request
# webkit.org/b/132980: test_ewk2_context_menu
# webkit.org/b/132981: test_ewk2_download_job
-# webkit.org/b/132982: test_ewk2_text_checker
if (ENABLE_API_TESTS)
foreach (testName ${EWK2UnitTests_BINARIES})
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/spelling_test.html (177056 => 177057)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/spelling_test.html 2014-12-10 12:51:17 UTC (rev 177056)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/spelling_test.html 2014-12-10 13:00:05 UTC (rev 177057)
@@ -12,7 +12,7 @@
document.getElementById("input").focus();
// 'Space' notifies WebKit that word has been inserted.
- document.getElementById("input").value = "aa ";
+ document.execCommand("InsertText", false, "aa ");
}
</SCRIPT>
</HEAD>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
