Title: [177076] trunk/LayoutTests
- Revision
- 177076
- Author
- [email protected]
- Date
- 2014-12-10 10:08:29 -0800 (Wed, 10 Dec 2014)
Log Message
[WK1] new http/tests/notifications/legacy/notification-request-permission-then-navigate.html test is crashing
https://bugs.webkit.org/show_bug.cgi?id=139494
Reviewed by Alexey Proskuryakov.
Call window.open() after the page has been loaded because our test infrastructure
asserts that testRunner.waitUntilDone() must have been called *before* window.open()
is called. Since testRunner.waitUntilDone() is called is js-test-post.js, calling
window.open() after page load fixes the issue.
* http/tests/notifications/legacy/notification-request-permission-then-navigate.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (177075 => 177076)
--- trunk/LayoutTests/ChangeLog 2014-12-10 17:42:55 UTC (rev 177075)
+++ trunk/LayoutTests/ChangeLog 2014-12-10 18:08:29 UTC (rev 177076)
@@ -1,3 +1,17 @@
+2014-12-10 Chris Dumez <[email protected]>
+
+ [WK1] new http/tests/notifications/legacy/notification-request-permission-then-navigate.html test is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=139494
+
+ Reviewed by Alexey Proskuryakov.
+
+ Call window.open() after the page has been loaded because our test infrastructure
+ asserts that testRunner.waitUntilDone() must have been called *before* window.open()
+ is called. Since testRunner.waitUntilDone() is called is js-test-post.js, calling
+ window.open() after page load fixes the issue.
+
+ * http/tests/notifications/legacy/notification-request-permission-then-navigate.html:
+
2014-12-09 Gustavo Noronha Silva <[email protected]>
[GTK][WK2] Add HTML5 Notifications support
Modified: trunk/LayoutTests/http/tests/notifications/legacy/notification-request-permission-then-navigate.html (177075 => 177076)
--- trunk/LayoutTests/http/tests/notifications/legacy/notification-request-permission-then-navigate.html 2014-12-10 17:42:55 UTC (rev 177075)
+++ trunk/LayoutTests/http/tests/notifications/legacy/notification-request-permission-then-navigate.html 2014-12-10 18:08:29 UTC (rev 177076)
@@ -4,7 +4,7 @@
<script src=""
<script src=""
</head>
-<body>
+<body _onload_="runTest()">
<script>
description("Tests that we are not crashing when a permission request is answered after navigating");
jsTestIsAsync = true;
@@ -19,7 +19,10 @@
finishJSTest();
});
-target = window.open('resources/request-permission-then-navigate.html');
+function runTest()
+{
+ target = window.open('resources/request-permission-then-navigate.html');
+}
</script>
<script src=""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
