Title: [177164] trunk/Source/WebKit2
- Revision
- 177164
- Author
- [email protected]
- Date
- 2014-12-11 11:28:13 -0800 (Thu, 11 Dec 2014)
Log Message
Web Inspector: Inspector Process crash when navigating to non-inspectable page
https://bugs.webkit.org/show_bug.cgi?id=139508
Patch by Joseph Pecoraro <[email protected]> on 2014-12-11
Reviewed by Zalan Bujtas.
The Inspector Process can still receive InspectorFrontendHost messages
even though the backend connection has been invalidated and cleared.
Only send messages if the connection exists.
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::sendMessageToBackend):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (177163 => 177164)
--- trunk/Source/WebKit2/ChangeLog 2014-12-11 19:26:59 UTC (rev 177163)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-11 19:28:13 UTC (rev 177164)
@@ -1,3 +1,18 @@
+2014-12-11 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Inspector Process crash when navigating to non-inspectable page
+ https://bugs.webkit.org/show_bug.cgi?id=139508
+
+ Reviewed by Zalan Bujtas.
+
+ The Inspector Process can still receive InspectorFrontendHost messages
+ even though the backend connection has been invalidated and cleared.
+ Only send messages if the connection exists.
+
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::openInNewTab):
+ (WebKit::WebInspectorUI::sendMessageToBackend):
+
2014-12-11 Yongjun Zhang <[email protected]>
WebKit2 should expose FirstVisuallyNonEmptyLayout rendering milestone.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (177163 => 177164)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2014-12-11 19:26:59 UTC (rev 177163)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2014-12-11 19:28:13 UTC (rev 177164)
@@ -184,7 +184,8 @@
void WebInspectorUI::openInNewTab(const String& url)
{
- m_backendConnection->send(Messages::WebInspector::OpenInNewTab(url), 0);
+ if (m_backendConnection)
+ m_backendConnection->send(Messages::WebInspector::OpenInNewTab(url), 0);
}
void WebInspectorUI::save(const WTF::String& filename, const WTF::String& content, bool base64Encoded, bool forceSaveAs)
@@ -244,7 +245,8 @@
void WebInspectorUI::sendMessageToBackend(const String& message)
{
- m_backendConnection->send(Messages::WebInspector::SendMessageToBackend(message), 0);
+ if (m_backendConnection)
+ m_backendConnection->send(Messages::WebInspector::SendMessageToBackend(message), 0);
}
void WebInspectorUI::evaluateCommandOnLoad(const String& command, const String& argument)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
