Title: [177232] trunk/Source/WebCore
- Revision
- 177232
- Author
- benja...@webkit.org
- Date
- 2014-12-12 13:05:07 -0800 (Fri, 12 Dec 2014)
Log Message
Remove the concept of simple selector from the parser
https://bugs.webkit.org/show_bug.cgi?id=139575
Patch by Benjamin Poulain <bpoul...@apple.com> on 2014-12-12
Reviewed by Mark Lam.
We have complete support for nested selector list, we no longer
need the old concept of simple selector.
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::isSimple): Deleted.
* css/CSSParserValues.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177231 => 177232)
--- trunk/Source/WebCore/ChangeLog 2014-12-12 21:01:10 UTC (rev 177231)
+++ trunk/Source/WebCore/ChangeLog 2014-12-12 21:05:07 UTC (rev 177232)
@@ -1,3 +1,17 @@
+2014-12-12 Benjamin Poulain <bpoul...@apple.com>
+
+ Remove the concept of simple selector from the parser
+ https://bugs.webkit.org/show_bug.cgi?id=139575
+
+ Reviewed by Mark Lam.
+
+ We have complete support for nested selector list, we no longer
+ need the old concept of simple selector.
+
+ * css/CSSParserValues.cpp:
+ (WebCore::CSSParserSelector::isSimple): Deleted.
+ * css/CSSParserValues.h:
+
2014-12-12 Antti Koivisto <an...@apple.com>
FontGlyphs::glyphDataAndPageForCharacter cleanups
Modified: trunk/Source/WebCore/css/CSSParserValues.cpp (177231 => 177232)
--- trunk/Source/WebCore/css/CSSParserValues.cpp 2014-12-12 21:01:10 UTC (rev 177231)
+++ trunk/Source/WebCore/css/CSSParserValues.cpp 2014-12-12 21:05:07 UTC (rev 177232)
@@ -281,26 +281,6 @@
m_selector->setPseudoClassType(pseudoType.pseudoClass);
}
-bool CSSParserSelector::isSimple() const
-{
- if (m_selector->selectorList() || m_selector->matchesPseudoElement())
- return false;
-
- if (!m_tagHistory)
- return true;
-
- if (m_selector->match() == CSSSelector::Tag) {
- // We can't check against anyQName() here because namespace may not be nullAtom.
- // Example:
- // @namespace "http://www.w3.org/2000/svg";
- // svg:not(:root) { ...
- if (m_selector->tagQName().localName() == starAtom)
- return m_tagHistory->isSimple();
- }
-
- return false;
-}
-
static bool selectorListMatchesPseudoElement(const CSSSelectorList* selectorList)
{
if (!selectorList)
Modified: trunk/Source/WebCore/css/CSSParserValues.h (177231 => 177232)
--- trunk/Source/WebCore/css/CSSParserValues.h 2014-12-12 21:01:10 UTC (rev 177231)
+++ trunk/Source/WebCore/css/CSSParserValues.h 2014-12-12 21:05:07 UTC (rev 177232)
@@ -218,7 +218,6 @@
#endif
}
- bool isSimple() const;
bool hasShadowDescendant() const;
bool matchesPseudoElement() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
