Title: [177256] trunk/Tools
- Revision
- 177256
- Author
- [email protected]
- Date
- 2014-12-13 01:22:55 -0800 (Sat, 13 Dec 2014)
Log Message
[EFL] MiniBrowser's window_create may return NULL
https://bugs.webkit.org/show_bug.cgi?id=139585
Reviewed by Gyuyoung Kim.
Move NULL checking before using object which window_create
returns.
* MiniBrowser/efl/main.c:
(elm_main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (177255 => 177256)
--- trunk/Tools/ChangeLog 2014-12-13 01:44:27 UTC (rev 177255)
+++ trunk/Tools/ChangeLog 2014-12-13 09:22:55 UTC (rev 177256)
@@ -1,3 +1,16 @@
+2014-12-13 Grzegorz Czajkowski <[email protected]>
+
+ [EFL] MiniBrowser's window_create may return NULL
+ https://bugs.webkit.org/show_bug.cgi?id=139585
+
+ Reviewed by Gyuyoung Kim.
+
+ Move NULL checking before using object which window_create
+ returns.
+
+ * MiniBrowser/efl/main.c:
+ (elm_main):
+
2014-12-12 Alexey Proskuryakov <[email protected]>
Layout Test http/tests/loading/307-after-303-after-post.html is flaky
Modified: trunk/Tools/MiniBrowser/efl/main.c (177255 => 177256)
--- trunk/Tools/MiniBrowser/efl/main.c 2014-12-13 01:44:27 UTC (rev 177255)
+++ trunk/Tools/MiniBrowser/efl/main.c 2014-12-13 09:22:55 UTC (rev 177256)
@@ -2422,19 +2422,17 @@
if (window_size_string)
parse_window_size(window_size_string, &window_width, &window_height);
+ window = window_create(NULL, 0, 0);
+ if (!window)
+ return quit(EINA_FALSE, "ERROR: could not create browser window.\n");
+
if (args < argc) {
char *url = ""
- window = window_create(NULL, 0, 0);
ewk_view_url_set(window->ewk_view, url);
free(url);
- } else {
- window = window_create(NULL, 0, 0);
+ } else
ewk_view_url_set(window->ewk_view, DEFAULT_URL);
- }
- if (!window)
- return quit(EINA_FALSE, "ERROR: could not create browser window.\n");
-
windows = eina_list_append(windows, window);
elm_run();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
