Diff
Modified: trunk/Source/WTF/ChangeLog (177259 => 177260)
--- trunk/Source/WTF/ChangeLog 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WTF/ChangeLog 2014-12-14 09:34:28 UTC (rev 177260)
@@ -1,5 +1,12 @@
2014-12-14 Andreas Kling <[email protected]>
+ Minor follow-up tweaks suggested by Darin on bug 139587.
+
+ * wtf/text/WTFString.h:
+ (WTF::String::String):
+
+2014-12-14 Andreas Kling <[email protected]>
+
Replace PassRef with Ref/Ref&& across the board.
<https://webkit.org/b/139587>
Modified: trunk/Source/WTF/wtf/text/WTFString.h (177259 => 177260)
--- trunk/Source/WTF/wtf/text/WTFString.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2014-12-14 09:34:28 UTC (rev 177260)
@@ -115,7 +115,7 @@
String(StringImpl& impl) : m_impl(&impl) { }
String(StringImpl* impl) : m_impl(impl) { }
String(PassRefPtr<StringImpl> impl) : m_impl(impl) { }
- String(Ref<StringImpl>&& impl) : m_impl(std::forward<Ref<StringImpl>>(impl)) { }
+ String(Ref<StringImpl>&& impl) : m_impl(WTF::move(impl)) { }
String(RefPtr<StringImpl>&& impl) : m_impl(impl) { }
// Construct a string from a constant string literal.
Modified: trunk/Source/WebCore/ChangeLog (177259 => 177260)
--- trunk/Source/WebCore/ChangeLog 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/ChangeLog 2014-12-14 09:34:28 UTC (rev 177260)
@@ -1,5 +1,16 @@
2014-12-14 Andreas Kling <[email protected]>
+ Minor follow-up tweaks suggested by Darin on bug 139587.
+
+ * css/CSSFunctionValue.h:
+ (WebCore::CSSFunctionValue::create):
+ * platform/graphics/Font.cpp:
+ (WebCore::retrieveOrAddCachedFontGlyphs):
+ (WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): Deleted.
+ * rendering/RenderScrollbarPart.h:
+
+2014-12-14 Andreas Kling <[email protected]>
+
Replace PassRef with Ref/Ref&& across the board.
<https://webkit.org/b/139587>
Modified: trunk/Source/WebCore/css/CSSFunctionValue.h (177259 => 177260)
--- trunk/Source/WebCore/css/CSSFunctionValue.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/css/CSSFunctionValue.h 2014-12-14 09:34:28 UTC (rev 177260)
@@ -40,7 +40,7 @@
return adoptRef(*new CSSFunctionValue(function));
}
- static Ref<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
+ static Ref<CSSFunctionValue> create(const String& name, PassRefPtr<CSSValueList> args)
{
return adoptRef(*new CSSFunctionValue(name, args));
}
@@ -53,7 +53,7 @@
private:
explicit CSSFunctionValue(CSSParserFunction*);
- CSSFunctionValue(String, PassRefPtr<CSSValueList>);
+ CSSFunctionValue(const String& , PassRefPtr<CSSValueList>);
String m_name;
RefPtr<CSSValueList> m_args;
Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (177259 => 177260)
--- trunk/Source/WebCore/platform/graphics/Font.cpp 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2014-12-14 09:34:28 UTC (rev 177260)
@@ -215,10 +215,6 @@
struct FontGlyphsCacheEntry {
WTF_MAKE_FAST_ALLOCATED;
public:
- FontGlyphsCacheEntry(FontGlyphsCacheKey&& k, Ref<FontGlyphs>&& g)
- : key(WTF::move(k))
- , glyphs(WTF::move(g))
- { }
FontGlyphsCacheKey key;
Ref<FontGlyphs> glyphs;
};
@@ -310,7 +306,7 @@
return addResult.iterator->value->glyphs.get();
std::unique_ptr<FontGlyphsCacheEntry>& newEntry = addResult.iterator->value;
- newEntry = std::make_unique<FontGlyphsCacheEntry>(WTF::move(key), FontGlyphs::create(fontSelector));
+ newEntry = std::make_unique<FontGlyphsCacheEntry>({WTF::move(key), FontGlyphs::create(fontSelector)});
Ref<FontGlyphs> glyphs = newEntry->glyphs.get();
static const unsigned unreferencedPruneInterval = 50;
Modified: trunk/Source/WebCore/rendering/RenderScrollbarPart.h (177259 => 177260)
--- trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-12-14 09:34:28 UTC (rev 177260)
@@ -35,7 +35,7 @@
class RenderScrollbarPart final : public RenderBlock {
public:
- RenderScrollbarPart(Document&, Ref<RenderStyle>&&, RenderScrollbar* = 0, ScrollbarPart = NoPart);
+ RenderScrollbarPart(Document&, Ref<RenderStyle>&&, RenderScrollbar* = nullptr, ScrollbarPart = NoPart);
virtual ~RenderScrollbarPart();
