Title: [177265] trunk/LayoutTests
- Revision
- 177265
- Author
- [email protected]
- Date
- 2014-12-14 11:02:40 -0800 (Sun, 14 Dec 2014)
Log Message
fast/images/animated-gif-body-outside-viewport.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139599
Reviewed by Alexey Proskuryakov.
Update fast/images/animated-gif-body-outside-viewport.html to use
shouldBecomeEqual() instead of a setTimeout() + shouldBe() to fix
the flakiness.
* fast/images/animated-gif-body-outside-viewport-expected.txt:
* fast/images/animated-gif-body-outside-viewport.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (177264 => 177265)
--- trunk/LayoutTests/ChangeLog 2014-12-14 12:23:31 UTC (rev 177264)
+++ trunk/LayoutTests/ChangeLog 2014-12-14 19:02:40 UTC (rev 177265)
@@ -1,3 +1,18 @@
+2014-12-14 Chris Dumez <[email protected]>
+
+ fast/images/animated-gif-body-outside-viewport.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=139599
+
+ Reviewed by Alexey Proskuryakov.
+
+ Update fast/images/animated-gif-body-outside-viewport.html to use
+ shouldBecomeEqual() instead of a setTimeout() + shouldBe() to fix
+ the flakiness.
+
+ * fast/images/animated-gif-body-outside-viewport-expected.txt:
+ * fast/images/animated-gif-body-outside-viewport.html:
+ * platform/mac-wk1/TestExpectations:
+
2014-12-14 Ryosuke Niwa <[email protected]>
REGRESSION(r160182): Fragment parser doesn't close a form element with a close tag
Modified: trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport-expected.txt (177264 => 177265)
--- trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport-expected.txt 2014-12-14 12:23:31 UTC (rev 177264)
+++ trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport-expected.txt 2014-12-14 19:02:40 UTC (rev 177265)
@@ -3,9 +3,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS isBackgroundAnimated is false
+PASS isBackgroundAnimated() became false
Scroll down so that the body becomes visible.
-PASS isBackgroundAnimated is true
+PASS isBackgroundAnimated() became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport.html (177264 => 177265)
--- trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport.html 2014-12-14 12:23:31 UTC (rev 177264)
+++ trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport.html 2014-12-14 19:02:40 UTC (rev 177265)
@@ -5,26 +5,22 @@
</head>
<body style="background-image: url('resources/animated.gif'); background-repeat: repeat; position: relative; left: 0px; top: 700px; width: 200px; height: 200px" _onload_="runTest()">
<script>
+description("Make sure the background image of a body element that is outside the viewport is not animated");
jsTestIsAsync = true;
-function checkBackgroundAnimated() {
- isBackgroundAnimated = !internals.hasPausedImageAnimations(document.body);
- shouldBeTrue("isBackgroundAnimated");
- finishJSTest();
+function isBackgroundAnimated()
+{
+ return !internals.hasPausedImageAnimations(document.body);
}
-function checkBackgroundNotAnimated() {
- isBackgroundAnimated = !internals.hasPausedImageAnimations(document.body);
- description("Make sure the background image of a body element that is outside the viewport is not animated");
- shouldBeFalse("isBackgroundAnimated");
-
+function scrollDown() {
debug("Scroll down so that the body becomes visible.");
window.scrollBy(0, 600);
- setTimeout(checkBackgroundAnimated, 0);
+ shouldBecomeEqual("isBackgroundAnimated()", "true", finishJSTest);
}
function imageLoaded() {
- setTimeout(checkBackgroundNotAnimated, 200);
+ shouldBecomeEqual("isBackgroundAnimated()", "false", scrollDown);
}
function runTest() {
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (177264 => 177265)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2014-12-14 12:23:31 UTC (rev 177264)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2014-12-14 19:02:40 UTC (rev 177265)
@@ -28,8 +28,6 @@
webkit.org/b/112533 media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Timeout ]
-webkit.org/b/139599 fast/images/animated-gif-body-outside-viewport.html [ Pass Failure ]
-
### END OF (1) Failures with bug reports
########################################
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
