Title: [177322] trunk/Source/WebInspectorUI
- Revision
- 177322
- Author
- [email protected]
- Date
- 2014-12-15 16:01:31 -0800 (Mon, 15 Dec 2014)
Log Message
Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
https://bugs.webkit.org/show_bug.cgi?id=139610
Patch by Joseph Pecoraro <[email protected]> on 2014-12-15
Reviewed by Timothy Hatcher.
The CSSStyleDeclarationTextEditor for Computed Style Properties always has
empty DOMNodeStyles text. However we would not reset contents if properties
changed and the actualy content was empty. So once empty, we could never
recover. In fact, we should always refresh for Computed Styles.
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (177321 => 177322)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-16 00:00:53 UTC (rev 177321)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-16 00:01:31 UTC (rev 177322)
@@ -1,3 +1,18 @@
+2014-12-15 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
+ https://bugs.webkit.org/show_bug.cgi?id=139610
+
+ Reviewed by Timothy Hatcher.
+
+ The CSSStyleDeclarationTextEditor for Computed Style Properties always has
+ empty DOMNodeStyles text. However we would not reset contents if properties
+ changed and the actualy content was empty. So once empty, we could never
+ recover. In fact, we should always refresh for Computed Styles.
+
+ * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+ (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
+
2014-12-08 Joseph Pecoraro <[email protected]>
Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (177321 => 177322)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2014-12-16 00:00:53 UTC (rev 177321)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2014-12-16 00:01:31 UTC (rev 177322)
@@ -726,7 +726,7 @@
return;
// Reset the content if the text is different and we are not focused.
- if (!this.focused && this._style.text !== this._formattedContent()) {
+ if (!this.focused && (!this._style.text || this._style.text !== this._formattedContent())) {
this._resetContent();
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
