Title: [177326] trunk/Source
- Revision
- 177326
- Author
- [email protected]
- Date
- 2014-12-15 17:30:07 -0800 (Mon, 15 Dec 2014)
Log Message
Speculative build fix.
Source/WebCore:
* platform/spi/mac/LookupSPI.h:
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
* WebView/WebViewInternal.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177325 => 177326)
--- trunk/Source/WebCore/ChangeLog 2014-12-16 01:19:28 UTC (rev 177325)
+++ trunk/Source/WebCore/ChangeLog 2014-12-16 01:30:07 UTC (rev 177326)
@@ -4,6 +4,12 @@
* platform/spi/mac/LookupSPI.h:
+2014-12-15 Beth Dakin <[email protected]>
+
+ Speculative build fix.
+
+ * platform/spi/mac/LookupSPI.h:
+
2014-12-15 Jer Noble <[email protected]>
Switching src of <video> with clipping layer results in empty black square.
Modified: trunk/Source/WebCore/platform/spi/mac/LookupSPI.h (177325 => 177326)
--- trunk/Source/WebCore/platform/spi/mac/LookupSPI.h 2014-12-16 01:19:28 UTC (rev 177325)
+++ trunk/Source/WebCore/platform/spi/mac/LookupSPI.h 2014-12-16 01:30:07 UTC (rev 177326)
@@ -48,10 +48,14 @@
#endif // !USE(APPLE_INTERNAL_SDK)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+
@interface LULookupDefinitionModule (AnimationController)
+ (id<NSImmediateActionAnimationController>)lookupAnimationControllerForTerm:(NSAttributedString *)term atLocation:(NSPoint)screenPoint options:(NSDictionary *)options;
@end
+#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+
#endif // PLATFORM(MAC)
Modified: trunk/Source/WebKit/mac/ChangeLog (177325 => 177326)
--- trunk/Source/WebKit/mac/ChangeLog 2014-12-16 01:19:28 UTC (rev 177325)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-16 01:30:07 UTC (rev 177326)
@@ -1,5 +1,13 @@
2014-12-15 Beth Dakin <[email protected]>
+ Speculative build fix.
+
+ * WebView/WebView.mm:
+ (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
+ * WebView/WebViewInternal.h:
+
+2014-12-15 Beth Dakin <[email protected]>
+
Make lookup an immediate action instead of an action menu item
https://bugs.webkit.org/show_bug.cgi?id=139661
-and corresponding-
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (177325 => 177326)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2014-12-16 01:19:28 UTC (rev 177325)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2014-12-16 01:30:07 UTC (rev 177326)
@@ -8611,6 +8611,33 @@
{
return _private->immediateActionController;
}
+
+- (id)_animationControllerForDictionaryLookupPopupInfo:(const DictionaryPopupInfo&)dictionaryPopupInfo
+{
+ if (!dictionaryPopupInfo.attributedString)
+ return nil;
+
+ NSPoint textBaselineOrigin = dictionaryPopupInfo.origin;
+
+ // Convert to screen coordinates.
+ textBaselineOrigin = [self.window convertRectToScreen:NSMakeRect(textBaselineOrigin.x, textBaselineOrigin.y, 0, 0)].origin;
+
+ if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose()) {
+ if (!_private->hasInitializedLookupObserver) {
+ [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_dictionaryLookupPopoverWillClose:) name:getLUNotificationPopoverWillClose() object:nil];
+ _private->hasInitializedLookupObserver = YES;
+ }
+
+ RetainPtr<NSMutableDictionary> mutableOptions = adoptNS([dictionaryPopupInfo.options mutableCopy]);
+ if (!mutableOptions)
+ mutableOptions = adoptNS([[NSMutableDictionary alloc] init]);
+ [mutableOptions setObject:@YES forKey:getLUTermOptionDisableSearchTermIndicator()];
+ [self _setTextIndicator:dictionaryPopupInfo.textIndicator.get() fadeOut:NO animationCompletionHandler:[] { }];
+ return [getLULookupDefinitionModuleClass() lookupAnimationControllerForTerm:dictionaryPopupInfo.attributedString.get() atLocation:textBaselineOrigin options:mutableOptions.get()];
+ }
+
+ return [getLULookupDefinitionModuleClass() lookupAnimationControllerForTerm:dictionaryPopupInfo.attributedString.get() atLocation:textBaselineOrigin options:dictionaryPopupInfo.options.get()];
+}
#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- (void)_setTextIndicator:(TextIndicator *)textIndicator fadeOut:(BOOL)fadeOut animationCompletionHandler:(std::function<void ()>)completionHandler
@@ -8659,33 +8686,6 @@
[getLULookupDefinitionModuleClass() showDefinitionForTerm:dictionaryPopupInfo.attributedString.get() atLocation:textBaselineOrigin options:dictionaryPopupInfo.options.get()];
}
-- (id)_animationControllerForDictionaryLookupPopupInfo:(const DictionaryPopupInfo&)dictionaryPopupInfo
-{
- if (!dictionaryPopupInfo.attributedString)
- return nil;
-
- NSPoint textBaselineOrigin = dictionaryPopupInfo.origin;
-
- // Convert to screen coordinates.
- textBaselineOrigin = [self.window convertRectToScreen:NSMakeRect(textBaselineOrigin.x, textBaselineOrigin.y, 0, 0)].origin;
-
- if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose()) {
- if (!_private->hasInitializedLookupObserver) {
- [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_dictionaryLookupPopoverWillClose:) name:getLUNotificationPopoverWillClose() object:nil];
- _private->hasInitializedLookupObserver = YES;
- }
-
- RetainPtr<NSMutableDictionary> mutableOptions = adoptNS([dictionaryPopupInfo.options mutableCopy]);
- if (!mutableOptions)
- mutableOptions = adoptNS([[NSMutableDictionary alloc] init]);
- [mutableOptions setObject:@YES forKey:getLUTermOptionDisableSearchTermIndicator()];
- [self _setTextIndicator:dictionaryPopupInfo.textIndicator.get() fadeOut:NO animationCompletionHandler:[] { }];
- return [getLULookupDefinitionModuleClass() lookupAnimationControllerForTerm:dictionaryPopupInfo.attributedString.get() atLocation:textBaselineOrigin options:mutableOptions.get()];
- }
-
- return [getLULookupDefinitionModuleClass() lookupAnimationControllerForTerm:dictionaryPopupInfo.attributedString.get() atLocation:textBaselineOrigin options:dictionaryPopupInfo.options.get()];
-}
-
- (void)_dictionaryLookupPopoverWillClose:(NSNotification *)notification
{
[self _setTextIndicator:nullptr fadeOut:NO animationCompletionHandler:[] { }];
Modified: trunk/Source/WebKit/mac/WebView/WebViewInternal.h (177325 => 177326)
--- trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2014-12-16 01:19:28 UTC (rev 177325)
+++ trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2014-12-16 01:30:07 UTC (rev 177326)
@@ -262,8 +262,8 @@
- (void)_setTextIndicator:(WebCore::TextIndicator*)textIndicator fadeOut:(BOOL)fadeOut animationCompletionHandler:(std::function<void ()>)completionHandler;
- (void)_clearTextIndicator;
- (void)_showDictionaryLookupPopup:(const DictionaryPopupInfo&)dictionaryPopupInfo;
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- (id)_animationControllerForDictionaryLookupPopupInfo:(const DictionaryPopupInfo&)dictionaryPopupInfo;
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- (WebActionMenuController *)_actionMenuController;
- (WebImmediateActionController *)_immediateActionController;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
