Title: [177331] trunk/Source/WebInspectorUI
- Revision
- 177331
- Author
- [email protected]
- Date
- 2014-12-15 19:25:09 -0800 (Mon, 15 Dec 2014)
Log Message
Web Inspector: Clicking on the expand object arrow should always expand an object
https://bugs.webkit.org/show_bug.cgi?id=139382
Patch by Nikita Vasilyev <[email protected]> on 2014-12-15
Reviewed by Joseph Pecoraro.
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._click): Deleted.
stopPropagation was preventing the object expansion from happening as expecting.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (177330 => 177331)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-16 02:19:52 UTC (rev 177330)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-16 03:25:09 UTC (rev 177331)
@@ -1,3 +1,15 @@
+2014-12-15 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Clicking on the expand object arrow should always expand an object
+ https://bugs.webkit.org/show_bug.cgi?id=139382
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/LogContentView.js:
+ (WebInspector.LogContentView):
+ (WebInspector.LogContentView.prototype._click): Deleted.
+ stopPropagation was preventing the object expansion from happening as expecting.
+
2014-12-15 Joseph Pecoraro <[email protected]>
Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (177330 => 177331)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2014-12-16 02:19:52 UTC (rev 177330)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2014-12-16 03:25:09 UTC (rev 177331)
@@ -40,7 +40,6 @@
this.messagesElement.addEventListener("focus", this._didFocus.bind(this));
this.messagesElement.addEventListener("blur", this._didBlur.bind(this));
this.messagesElement.addEventListener("keydown", this._keyDown.bind(this));
- this.messagesElement.addEventListener("click", this._click.bind(this), true);
this.messagesElement.addEventListener("dragstart", this._ondragstart.bind(this), true);
this.element.appendChild(this.messagesElement);
@@ -411,7 +410,6 @@
var message = wrapper.messageElement;
if (this._targetInMessageCanBeSelected(event.target, message)) {
var sameWrapper = wrapper === this._mouseDownWrapper;
- this._mouseInteractionShouldPreventClickPropagation = !this._isMessageSelected(message);
this._updateMessagesSelection(message, sameWrapper ? this._mouseDownCommandKey : false, sameWrapper ? this._mouseDownShiftKey : true);
}
} else if (!selection.isCollapsed) {
@@ -431,15 +429,6 @@
delete this._mouseDownCommandKey;
},
- _click: function(event)
- {
- if (!this._mouseInteractionShouldPreventClickPropagation)
- return;
-
- event.stopPropagation();
- delete this._mouseInteractionShouldPreventClickPropagation;
- },
-
_ondragstart: function(event)
{
if (event.target.enclosingNodeOrSelfWithClass(WebInspector.DOMTreeOutline.StyleClassName)) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
