Title: [177433] trunk/Source/WebInspectorUI
- Revision
- 177433
- Author
- [email protected]
- Date
- 2014-12-16 19:56:23 -0800 (Tue, 16 Dec 2014)
Log Message
Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
https://bugs.webkit.org/show_bug.cgi?id=139720
Patch by Matt Baker <[email protected]> on 2014-12-16
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
but docking buttons/context menu still function.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (177432 => 177433)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-17 03:55:35 UTC (rev 177432)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-17 03:56:23 UTC (rev 177433)
@@ -1,3 +1,14 @@
+2014-12-16 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
+ https://bugs.webkit.org/show_bug.cgi?id=139720
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
+ but docking buttons/context menu still function.
+
2014-12-15 Nikita Vasilyev <[email protected]>
Web Inspector: Clicking on the expand object arrow should always expand an object
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (177432 => 177433)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-12-17 03:55:35 UTC (rev 177432)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-12-17 03:56:23 UTC (rev 177433)
@@ -1363,8 +1363,10 @@
// Ignore dragging on the top of the toolbar on Mac where the inspector content fills the entire window.
if (WebInspector.Platform.name === "mac" && WebInspector.Platform.version.release >= 10) {
const windowDragHandledTitleBarHeight = 22;
- if (event.pageY < windowDragHandledTitleBarHeight)
+ if (event.pageY < windowDragHandledTitleBarHeight) {
+ event.preventDefault();
return;
+ }
}
var lastScreenX = event.screenX;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
