Title: [177444] trunk/Source/WebCore
Revision
177444
Author
[email protected]
Date
2014-12-17 08:33:31 -0800 (Wed, 17 Dec 2014)

Log Message

Addressing more post-review comments in r177035

* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (177443 => 177444)


--- trunk/Source/WebCore/ChangeLog	2014-12-17 12:03:18 UTC (rev 177443)
+++ trunk/Source/WebCore/ChangeLog	2014-12-17 16:33:31 UTC (rev 177444)
@@ -1,3 +1,12 @@
+2014-12-16  Myles C. Maxfield  <[email protected]>
+
+        Addressing more post-review comments in r177035
+
+        * accessibility/AccessibilitySlider.cpp:
+        (WebCore::AccessibilitySliderThumb::elementRect):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setupDateTimeChooserParameters):
+
 2014-12-17  Zan Dobersek  <[email protected]>
 
         [TexMap] Sprinkle range-based for-loops where still possible

Modified: trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp (177443 => 177444)


--- trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp	2014-12-17 12:03:18 UTC (rev 177443)
+++ trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp	2014-12-17 16:33:31 UTC (rev 177444)
@@ -159,7 +159,7 @@
     RenderObject* sliderRenderer = m_parent->renderer();
     if (!sliderRenderer || !sliderRenderer->isSlider())
         return LayoutRect();
-    if (RenderElement* thumbRenderer = downcast<HTMLInputElement>(sliderRenderer->node())->sliderThumbElement()->renderer())
+    if (auto* thumbRenderer = downcast<RenderSlider>(*sliderRenderer).element().renderer())
         return thumbRenderer->absoluteBoundingBoxRect();
     return LayoutRect();
 }

Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (177443 => 177444)


--- trunk/Source/WebCore/html/HTMLInputElement.cpp	2014-12-17 12:03:18 UTC (rev 177443)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp	2014-12-17 16:33:31 UTC (rev 177444)
@@ -1877,7 +1877,7 @@
         parameters.stepBase = 0;
     }
 
-    if (RenderObject* renderer = this->renderer())
+    if (RenderElement* renderer = this->renderer())
         parameters.anchorRectInRootView = document().view()->contentsToRootView(renderer->absoluteBoundingBoxRect());
     else
         parameters.anchorRectInRootView = IntRect();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to