Title: [177448] trunk/Source
Revision
177448
Author
[email protected]
Date
2014-12-17 10:26:51 -0800 (Wed, 17 Dec 2014)

Log Message

[Win] Correct DebugSuffix builds under MSBuild
https://bugs.webkit.org/show_bug.cgi?id=139733
<rdar://problem/19276880>

Reviewed by Simon Fraser.

../_javascript_Core:

* _javascript_Core.vcxproj/_javascript_Core.proj: Make sure to use the
'_debug' suffix when building the DebugSuffix target.

../WebKit:

* WebKit.vcxproj/WebKit.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.

../WTF:

* WTF.vcxproj/WTF.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (177447 => 177448)


--- trunk/Source/_javascript_Core/ChangeLog	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-12-17 18:26:51 UTC (rev 177448)
@@ -1,3 +1,14 @@
+2014-12-17  Brent Fulgham  <[email protected]>
+
+        [Win] Correct DebugSuffix builds under MSBuild
+        https://bugs.webkit.org/show_bug.cgi?id=139733
+        <rdar://problem/19276880>
+
+        Reviewed by Simon Fraser.
+
+        * _javascript_Core.vcxproj/_javascript_Core.proj: Make sure to use the
+        '_debug' suffix when building the DebugSuffix target.
+
 2014-12-16  Enrica Casucci  <[email protected]>
 
         Fix iOS builders for 8.0

Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj (177447 => 177448)


--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2014-12-17 18:26:51 UTC (rev 177448)
@@ -4,9 +4,11 @@
   <!-- normalize configuration case -->
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Release'">
 	<CONFIG>Production</CONFIG>
+    <DebugSuffix></DebugSuffix>
   </PropertyGroup>
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Debug'">
 	<CONFIG>DebugSuffix</CONFIG>
+    <DebugSuffix>_debug</DebugSuffix>
   </PropertyGroup>
 
   <!-- Wrapper to build _javascript_Core for both win32 and x64. -->
@@ -83,10 +85,10 @@
     <CreateItem Include="$(ConfigurationBuildDir)\bin64\*.pdb">
       <Output TaskParameter="Include" ItemName="Bin64SymbolFiles" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin32\_javascript_Core.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin32\_javascript_Core$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin32DLLFiles" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin64\_javascript_Core.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin64\_javascript_Core$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin64DLLFiles" />
     </CreateItem>
     <CreateItem Include="$(ConfigurationBuildDir)\bin32\*.resources">

Modified: trunk/Source/WTF/ChangeLog (177447 => 177448)


--- trunk/Source/WTF/ChangeLog	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/WTF/ChangeLog	2014-12-17 18:26:51 UTC (rev 177448)
@@ -1,3 +1,14 @@
+2014-12-17  Brent Fulgham  <[email protected]>
+
+        [Win] Correct DebugSuffix builds under MSBuild
+        https://bugs.webkit.org/show_bug.cgi?id=139733
+        <rdar://problem/19276880>
+
+        Reviewed by Simon Fraser.
+
+        * WTF.vcxproj/WTF.proj: Make sure to use the '_debug' suffix
+        when building the DebugSuffix target.
+
 2014-12-17  Anders Carlsson  <[email protected]>
 
         Make Ref::copyRef const and ref-qualified

Modified: trunk/Source/WTF/WTF.vcxproj/WTF.proj (177447 => 177448)


--- trunk/Source/WTF/WTF.vcxproj/WTF.proj	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.proj	2014-12-17 18:26:51 UTC (rev 177448)
@@ -4,9 +4,11 @@
   <!-- normalize configuration case -->
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Release'">
 	<CONFIG>Production</CONFIG>
+    <DebugSuffix></DebugSuffix>
   </PropertyGroup>
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Debug'">
 	<CONFIG>DebugSuffix</CONFIG>
+    <DebugSuffix>_debug</DebugSuffix>
   </PropertyGroup>
 
   <!-- Wrapper to build WTF for both win32 and x64. -->
@@ -68,10 +70,10 @@
     <CreateItem Include="$(ConfigurationBuildDir)\bin64\*">
        <Output TaskParameter="Include" ItemName="Bin64Files" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin32\WTF.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin32\WTF$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin32DLLFiles" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin64\WTF.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin64\WTF$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin64DLLFiles" />
     </CreateItem>
     <CreateItem Include="$(ConfigurationBuildDir)\bin32\*.pdb">

Modified: trunk/Source/WebKit/ChangeLog (177447 => 177448)


--- trunk/Source/WebKit/ChangeLog	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/WebKit/ChangeLog	2014-12-17 18:26:51 UTC (rev 177448)
@@ -1,3 +1,14 @@
+2014-12-17  Brent Fulgham  <[email protected]>
+
+        [Win] Correct DebugSuffix builds under MSBuild
+        https://bugs.webkit.org/show_bug.cgi?id=139733
+        <rdar://problem/19276880>
+
+        Reviewed by Simon Fraser.
+
+        * WebKit.vcxproj/WebKit.proj: Make sure to use the '_debug' suffix
+        when building the DebugSuffix target.
+
 2014-12-17  [email protected]  <[email protected]>
 
         [Win] Link errors.

Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj (177447 => 177448)


--- trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2014-12-17 18:12:00 UTC (rev 177447)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2014-12-17 18:26:51 UTC (rev 177448)
@@ -4,9 +4,11 @@
   <!-- normalize configuration case -->
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Release'">
 	<CONFIG>Production</CONFIG>
+    <DebugSuffix></DebugSuffix>
   </PropertyGroup>
   <PropertyGroup Condition="'$(CONFIGURATION)'=='Debug'">
 	<CONFIG>DebugSuffix</CONFIG>
+    <DebugSuffix>_debug</DebugSuffix>
   </PropertyGroup>
 
   <!-- Wrapper to build WebKit for both win32 and x64. -->
@@ -77,10 +79,10 @@
     <CreateItem Include="$(ConfigurationBuildDir)\bin64\*">
       <Output TaskParameter="Include" ItemName="Bin64Files" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin32\WebKit.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin32\WebKit$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin32DLLFiles" />
     </CreateItem>
-    <CreateItem Include="$(ConfigurationBuildDir)\bin64\WebKit.dll">
+    <CreateItem Include="$(ConfigurationBuildDir)\bin64\WebKit$(DebugSuffix).dll">
       <Output TaskParameter="Include" ItemName="Bin64DLLFiles" />
     </CreateItem>
     <CreateItem Include="$(ConfigurationBuildDir)\bin32\*.resources">
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to