Title: [177473] trunk/Source/WebKit2
- Revision
- 177473
- Author
- [email protected]
- Date
- 2014-12-17 16:15:19 -0800 (Wed, 17 Dec 2014)
Log Message
Page previews are sometimes sized much smaller than it seems they should be
https://bugs.webkit.org/show_bug.cgi?id=139754
-and corresponding-
rdar://problem/19286550
Reviewed by Tim Horton.
Increase the minimum size and add in a missing else!!
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (177472 => 177473)
--- trunk/Source/WebKit2/ChangeLog 2014-12-18 00:00:26 UTC (rev 177472)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-18 00:15:19 UTC (rev 177473)
@@ -1,3 +1,16 @@
+2014-12-17 Beth Dakin <[email protected]>
+
+ Page previews are sometimes sized much smaller than it seems they should be
+ https://bugs.webkit.org/show_bug.cgi?id=139754
+ -and corresponding-
+ rdar://problem/19286550
+
+ Reviewed by Tim Horton.
+
+ Increase the minimum size and add in a missing else!!
+ * UIProcess/mac/WKImmediateActionController.mm:
+ (-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]):
+
2014-12-17 Anders Carlsson <[email protected]>
Ref-ify WebPageProxy and WebProcessProxy creation functions
Modified: trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm (177472 => 177473)
--- trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2014-12-18 00:00:26 UTC (rev 177472)
+++ trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2014-12-18 00:15:19 UTC (rev 177473)
@@ -376,7 +376,7 @@
{
static const CGFloat preferredPopoverToViewScale = 0.75;
static const NSSize screenPadding = {40, 40};
- static const NSSize smallestPopoverSize = NSMakeSize(500, 300);
+ static const NSSize smallestPopoverSize = NSMakeSize(500, 500);
const NSSize effectivePadding = NSMakeSize(screenPadding.width + previewPadding.width, screenPadding.height + previewPadding.height);
@@ -419,7 +419,8 @@
NSSize computedTargetSize;
if ((maxVerticalTargetSizePreservingAspectRatio.width * maxVerticalTargetSizePreservingAspectRatio.height) > (maxHortizontalTargetSizePreservingAspectRatio.width * maxHortizontalTargetSizePreservingAspectRatio.height))
computedTargetSize = maxVerticalTargetSizePreservingAspectRatio;
- computedTargetSize = maxHortizontalTargetSizePreservingAspectRatio;
+ else
+ computedTargetSize = maxHortizontalTargetSizePreservingAspectRatio;
// Now make sure what we've computed isn't too small.
if (computedTargetSize.width < smallestPopoverSize.width && computedTargetSize.height < smallestPopoverSize.height) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
