Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (177483 => 177484)
--- trunk/Source/WebKit/mac/ChangeLog 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-18 02:09:50 UTC (rev 177484)
@@ -1,3 +1,23 @@
+2014-12-17 Anders Carlsson <[email protected]>
+
+ Get rid of an ugly #define hack in WebFrameLoaderClient
+ https://bugs.webkit.org/show_bug.cgi?id=139761
+
+ Reviewed by Dan Bernstein.
+
+ Also replace @private with @package in all public headers, for consistency.
+
+ * History/WebBackForwardList.h:
+ * History/WebHistory.h:
+ * Misc/WebDownload.h:
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ * WebView/WebArchive.h:
+ * WebView/WebDataSource.h:
+ * WebView/WebFrame.h:
+ * WebView/WebFrameView.h:
+ * WebView/WebPreferences.h:
+ * WebView/WebResource.h:
+
2014-12-17 Dan Bernstein <[email protected]>
<rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
Modified: trunk/Source/WebKit/mac/History/WebBackForwardList.h (177483 => 177484)
--- trunk/Source/WebKit/mac/History/WebBackForwardList.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/History/WebBackForwardList.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -41,7 +41,7 @@
structure.
*/
@interface WebBackForwardList : NSObject {
-@private
+@package
WebBackForwardListPrivate *_private;
}
Modified: trunk/Source/WebKit/mac/History/WebHistory.h (177483 => 177484)
--- trunk/Source/WebKit/mac/History/WebHistory.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/History/WebHistory.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -60,7 +60,7 @@
by WebKit.
*/
@interface WebHistory : NSObject {
-@private
+@package
WebHistoryPrivate *_historyPrivate;
}
Modified: trunk/Source/WebKit/mac/Misc/WebDownload.h (177483 => 177484)
--- trunk/Source/WebKit/mac/Misc/WebDownload.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/Misc/WebDownload.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -55,7 +55,7 @@
@interface WebDownload : NSURLDownload
{
-@private
+@package
WebDownloadInternal *_webInternal;
}
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (177483 => 177484)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-12-18 02:09:50 UTC (rev 177484)
@@ -28,11 +28,6 @@
#import "WebFrameLoaderClient.h"
-// Terrible hack; lets us get at the WebFrame private structure.
-#define private public
-#import "WebFrame.h"
-#undef private
-
#import "DOMElementInternal.h"
#import "DOMHTMLFormElementInternal.h"
#import "WebBackForwardList.h"
Modified: trunk/Source/WebKit/mac/WebView/WebArchive.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebArchive.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebArchive.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -46,7 +46,7 @@
*/
@interface WebArchive : NSObject <NSCoding, NSCopying>
{
- @private
+@package
WebArchivePrivate *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebDataSource.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebDataSource.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebDataSource.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -46,7 +46,7 @@
*/
@interface WebDataSource : NSObject
{
-@private
+@package
void *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebFrame.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -47,7 +47,7 @@
*/
@interface WebFrame : NSObject
{
-@private
+@package
WebFramePrivate *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebFrameView.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebFrameView.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebFrameView.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -46,7 +46,7 @@
*/
@interface WebFrameView : NSView
{
-@private
+@package
WebFrameViewPrivate *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -72,7 +72,7 @@
*/
@interface WebPreferences: NSObject <NSCoding>
{
-@private
+@package
WebPreferencesPrivate *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebResource.h (177483 => 177484)
--- trunk/Source/WebKit/mac/WebView/WebResource.h 2014-12-18 02:02:46 UTC (rev 177483)
+++ trunk/Source/WebKit/mac/WebView/WebResource.h 2014-12-18 02:09:50 UTC (rev 177484)
@@ -38,7 +38,7 @@
*/
@interface WebResource : NSObject <NSCoding, NSCopying>
{
-@private
+@package
WebResourcePrivate *_private;
}