Title: [177500] trunk/Source/WebCore
- Revision
- 177500
- Author
- [email protected]
- Date
- 2014-12-18 09:44:09 -0800 (Thu, 18 Dec 2014)
Log Message
Internals methods return 0 instead of false when they fail
https://bugs.webkit.org/show_bug.cgi?id=139766
Reviewed by Darin Adler.
Some Internals method explicitly return 0 although
they expect boolean value.
No new tests, no behavior change.
* testing/Internals.cpp:
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::hasGrammarMarker):
Return false instead of 0.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177499 => 177500)
--- trunk/Source/WebCore/ChangeLog 2014-12-18 17:21:03 UTC (rev 177499)
+++ trunk/Source/WebCore/ChangeLog 2014-12-18 17:44:09 UTC (rev 177500)
@@ -1,3 +1,22 @@
+2014-12-18 Grzegorz Czajkowski <[email protected]>
+
+ Internals methods return 0 instead of false when they fail
+ https://bugs.webkit.org/show_bug.cgi?id=139766
+
+ Reviewed by Darin Adler.
+
+ Some Internals method explicitly return 0 although
+ they expect boolean value.
+
+ No new tests, no behavior change.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::hasSpellingMarker):
+ (WebCore::Internals::hasAutocorrectedMarker):
+ (WebCore::Internals::isOverwriteModeEnabled):
+ (WebCore::Internals::hasGrammarMarker):
+ Return false instead of 0.
+
2014-12-18 Chris Dumez <[email protected]>
[iOS] Log why cached resources are being revalidated using FeatureCounter API
Modified: trunk/Source/WebCore/testing/Internals.cpp (177499 => 177500)
--- trunk/Source/WebCore/testing/Internals.cpp 2014-12-18 17:21:03 UTC (rev 177499)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-12-18 17:44:09 UTC (rev 177500)
@@ -1335,7 +1335,7 @@
{
Document* document = contextDocument();
if (!document || !document->frame())
- return 0;
+ return false;
updateEditorUINowIfScheduled();
@@ -1346,7 +1346,7 @@
{
Document* document = contextDocument();
if (!document || !document->frame())
- return 0;
+ return false;
updateEditorUINowIfScheduled();
@@ -1431,7 +1431,7 @@
{
Document* document = contextDocument();
if (!document || !document->frame())
- return 0;
+ return false;
return document->frame()->editor().isOverwriteModeEnabled();
}
@@ -1561,7 +1561,7 @@
{
Document* document = contextDocument();
if (!document || !document->frame())
- return 0;
+ return false;
return document->frame()->editor().selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
