Diff
Modified: trunk/Source/WebCore/ChangeLog (177558 => 177559)
--- trunk/Source/WebCore/ChangeLog 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/ChangeLog 2014-12-19 03:11:36 UTC (rev 177559)
@@ -1,3 +1,88 @@
+2014-12-18 Andreas Kling <[email protected]>
+
+ Ref-ify various Document-related things.
+ <https://webkit.org/b/139796>
+
+ Reviewed by Anders Carlsson.
+
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLDocument createDocumentFragmentWithText:]):
+ * dom/CDATASection.cpp:
+ (WebCore::CDATASection::create):
+ (WebCore::CDATASection::virtualCreate):
+ * dom/CDATASection.h:
+ * dom/Comment.cpp:
+ (WebCore::Comment::create):
+ * dom/Comment.h:
+ * dom/Document.cpp:
+ (WebCore::Document::create):
+ (WebCore::Document::createDocumentFragment):
+ (WebCore::Document::createTextNode):
+ (WebCore::Document::createComment):
+ (WebCore::Document::createEditingTextNode):
+ (WebCore::Document::createCSSStyleDeclaration):
+ (WebCore::Document::createElement):
+ (WebCore::Document::createRange):
+ (WebCore::Document::createParser):
+ (WebCore::Document::cloneNodeInternal):
+ (WebCore::Document::cloneDocumentWithoutChildren):
+ * dom/Document.h:
+ (WebCore::Document::create):
+ (WebCore::Document::createXHTML):
+ (WebCore::Document::createNonRenderedPlaceholder):
+ * dom/DocumentFragment.cpp:
+ (WebCore::DocumentFragment::create):
+ * dom/DocumentFragment.h:
+ * dom/DocumentType.h:
+ * dom/EntityReference.cpp:
+ (WebCore::EntityReference::create):
+ * dom/EntityReference.h:
+ * dom/Text.cpp:
+ (WebCore::Text::create):
+ (WebCore::Text::createEditingText):
+ (WebCore::Text::splitText):
+ (WebCore::Text::virtualCreate):
+ (WebCore::Text::createWithLengthLimit):
+ * dom/Text.h:
+ * editing/markup.cpp:
+ (WebCore::replaceChildrenWithText):
+ * html/FTPDirectoryDocument.cpp:
+ (WebCore::FTPDirectoryDocument::createParser):
+ * html/FTPDirectoryDocument.h:
+ * html/HTMLDocument.cpp:
+ (WebCore::HTMLDocument::createParser):
+ (WebCore::HTMLDocument::cloneDocumentWithoutChildren):
+ * html/HTMLDocument.h:
+ (WebCore::HTMLDocument::create):
+ (WebCore::HTMLDocument::createSynthesizedDocument):
+ * html/ImageDocument.cpp:
+ (WebCore::ImageDocument::createParser):
+ * html/ImageDocument.h:
+ * html/MediaDocument.cpp:
+ (WebCore::MediaDocument::createParser):
+ * html/MediaDocument.h:
+ * html/PluginDocument.cpp:
+ (WebCore::PluginDocument::createParser):
+ * html/PluginDocument.h:
+ * html/TextDocument.cpp:
+ (WebCore::TextDocument::createParser):
+ * html/TextDocument.h:
+ * html/parser/HTMLConstructionSite.cpp:
+ (WebCore::HTMLConstructionSite::insertTextNode):
+ * html/parser/HTMLDocumentParser.h:
+ (WebCore::HTMLDocumentParser::create):
+ * loader/SinkDocument.cpp:
+ (WebCore::SinkDocument::createParser):
+ * loader/SinkDocument.h:
+ * svg/SVGDocument.cpp:
+ (WebCore::SVGDocument::cloneDocumentWithoutChildren):
+ * svg/SVGDocument.h:
+ * xml/parser/XMLDocumentParser.h:
+ (WebCore::XMLDocumentParser::create):
+ * xml/parser/XMLDocumentParserLibxml2.cpp:
+ (WebCore::XMLParserContext::createStringParser):
+ (WebCore::XMLParserContext::createMemoryParser):
+
2014-12-18 Anders Carlsson <[email protected]>
Use MachSendRight in WebKit2
Modified: trunk/Source/WebCore/bindings/objc/DOMHTML.mm (177558 => 177559)
--- trunk/Source/WebCore/bindings/objc/DOMHTML.mm 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/bindings/objc/DOMHTML.mm 2014-12-19 03:11:36 UTC (rev 177559)
@@ -152,7 +152,7 @@
- (DOMDocumentFragment *)createDocumentFragmentWithText:(NSString *)text
{
// FIXME: Since this is not a contextual fragment, it won't handle whitespace properly.
- return kit(createFragmentFromText(*core(self)->createRange().get(), text).get());
+ return kit(createFragmentFromText(core(self)->createRange(), text).get());
}
@end
Modified: trunk/Source/WebCore/dom/CDATASection.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/CDATASection.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/CDATASection.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -31,9 +31,9 @@
{
}
-RefPtr<CDATASection> CDATASection::create(Document& document, const String& data)
+Ref<CDATASection> CDATASection::create(Document& document, const String& data)
{
- return adoptRef(new CDATASection(document, data));
+ return adoptRef(*new CDATASection(document, data));
}
String CDATASection::nodeName() const
@@ -56,7 +56,7 @@
return false;
}
-RefPtr<Text> CDATASection::virtualCreate(const String& data)
+Ref<Text> CDATASection::virtualCreate(const String& data)
{
return create(document(), data);
}
Modified: trunk/Source/WebCore/dom/CDATASection.h (177558 => 177559)
--- trunk/Source/WebCore/dom/CDATASection.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/CDATASection.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -29,7 +29,7 @@
class CDATASection final : public Text {
public:
- static RefPtr<CDATASection> create(Document&, const String&);
+ static Ref<CDATASection> create(Document&, const String&);
private:
CDATASection(Document&, const String&);
@@ -38,7 +38,7 @@
virtual NodeType nodeType() const override;
virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
virtual bool childTypeAllowed(NodeType) const override;
- virtual RefPtr<Text> virtualCreate(const String&) override;
+ virtual Ref<Text> virtualCreate(const String&) override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/Comment.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/Comment.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Comment.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -31,14 +31,14 @@
{
}
-RefPtr<Comment> Comment::create(Document& document, const String& text)
+Ref<Comment> Comment::create(Document& document, const String& text)
{
- return adoptRef(new Comment(document, text));
+ return adoptRef(*new Comment(document, text));
}
-RefPtr<Comment> Comment::create(ScriptExecutionContext& context, const String& text)
+Ref<Comment> Comment::create(ScriptExecutionContext& context, const String& text)
{
- return adoptRef(new Comment(downcast<Document>(context), text));
+ return adoptRef(*new Comment(downcast<Document>(context), text));
}
String Comment::nodeName() const
Modified: trunk/Source/WebCore/dom/Comment.h (177558 => 177559)
--- trunk/Source/WebCore/dom/Comment.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Comment.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -29,8 +29,8 @@
class Comment final : public CharacterData {
public:
- static RefPtr<Comment> create(Document&, const String&);
- static RefPtr<Comment> create(ScriptExecutionContext&, const String&);
+ static Ref<Comment> create(Document&, const String&);
+ static Ref<Comment> create(ScriptExecutionContext&, const String&);
private:
Comment(Document&, const String&);
Modified: trunk/Source/WebCore/dom/Document.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/Document.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -564,11 +564,11 @@
}
#endif
-RefPtr<Document> Document::create(ScriptExecutionContext& context)
+Ref<Document> Document::create(ScriptExecutionContext& context)
{
- RefPtr<Document> document = adoptRef(new Document(nullptr, URL()));
+ Ref<Document> document = adoptRef(*new Document(nullptr, URL()));
document->setSecurityOrigin(context.securityOrigin());
- return document.release();
+ return document;
}
Document::~Document()
@@ -860,17 +860,17 @@
return createElement(QualifiedName(nullAtom, name, nullAtom), false);
}
-RefPtr<DocumentFragment> Document::createDocumentFragment()
+Ref<DocumentFragment> Document::createDocumentFragment()
{
return DocumentFragment::create(document());
}
-RefPtr<Text> Document::createTextNode(const String& data)
+Ref<Text> Document::createTextNode(const String& data)
{
return Text::create(*this, data);
}
-RefPtr<Comment> Document::createComment(const String& data)
+Ref<Comment> Document::createComment(const String& data)
{
return Comment::create(*this, data);
}
@@ -910,15 +910,15 @@
return EntityReference::create(*this, name);
}
-RefPtr<Text> Document::createEditingTextNode(const String& text)
+Ref<Text> Document::createEditingTextNode(const String& text)
{
return Text::createEditingText(*this, text);
}
-RefPtr<CSSStyleDeclaration> Document::createCSSStyleDeclaration()
+Ref<CSSStyleDeclaration> Document::createCSSStyleDeclaration()
{
Ref<MutableStyleProperties> propertySet(MutableStyleProperties::create());
- return propertySet->ensureCSSStyleDeclaration();
+ return *propertySet->ensureCSSStyleDeclaration();
}
RefPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionCode& ec)
@@ -1031,7 +1031,7 @@
}
// FIXME: This should really be in a possible ElementFactory class.
-RefPtr<Element> Document::createElement(const QualifiedName& name, bool createdByParser)
+Ref<Element> Document::createElement(const QualifiedName& name, bool createdByParser)
{
RefPtr<Element> element;
@@ -1053,7 +1053,7 @@
// <image> uses imgTag so we need a special rule.
ASSERT((name.matches(imageTag) && element->tagQName().matches(imgTag) && element->tagQName().prefix() == name.prefix()) || name == element->tagQName());
- return element.release();
+ return element.releaseNonNull();
}
bool Document::cssRegionsEnabled() const
@@ -1652,7 +1652,7 @@
return m_frame ? &m_frame->settings() : nullptr;
}
-RefPtr<Range> Document::createRange()
+Ref<Range> Document::createRange()
{
return Range::create(*this);
}
@@ -2218,7 +2218,7 @@
renderView()->style().setRTLOrdering(VisualOrder);
}
-RefPtr<DocumentParser> Document::createParser()
+Ref<DocumentParser> Document::createParser()
{
// FIXME: this should probably pass the frame instead
return XMLDocumentParser::create(*this, view());
@@ -3163,20 +3163,20 @@
RefPtr<Node> Document::cloneNodeInternal(Document&, CloningOperation type)
{
- RefPtr<Document> clone = cloneDocumentWithoutChildren();
+ Ref<Document> clone = cloneDocumentWithoutChildren();
clone->cloneDataFromDocument(*this);
switch (type) {
case CloningOperation::OnlySelf:
case CloningOperation::SelfWithTemplateContent:
break;
case CloningOperation::Everything:
- cloneChildNodes(clone.get());
+ cloneChildNodes(clone.ptr());
break;
}
- return clone;
+ return WTF::move(clone);
}
-RefPtr<Document> Document::cloneDocumentWithoutChildren() const
+Ref<Document> Document::cloneDocumentWithoutChildren() const
{
return isXHTMLDocument() ? createXHTML(nullptr, url()) : create(nullptr, url());
}
Modified: trunk/Source/WebCore/dom/Document.h (177558 => 177559)
--- trunk/Source/WebCore/dom/Document.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Document.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -257,19 +257,19 @@
class Document : public ContainerNode, public TreeScope, public ScriptExecutionContext {
public:
- static RefPtr<Document> create(Frame* frame, const URL& url)
+ static Ref<Document> create(Frame* frame, const URL& url)
{
- return adoptRef(new Document(frame, url));
+ return adoptRef(*new Document(frame, url));
}
- static RefPtr<Document> createXHTML(Frame* frame, const URL& url)
+ static Ref<Document> createXHTML(Frame* frame, const URL& url)
{
- return adoptRef(new Document(frame, url, XHTMLDocumentClass));
+ return adoptRef(*new Document(frame, url, XHTMLDocumentClass));
}
- static RefPtr<Document> createNonRenderedPlaceholder(Frame* frame, const URL& url)
+ static Ref<Document> createNonRenderedPlaceholder(Frame* frame, const URL& url)
{
- return adoptRef(new Document(frame, url, DefaultDocumentClass, NonRenderedPlaceholder));
+ return adoptRef(*new Document(frame, url, DefaultDocumentClass, NonRenderedPlaceholder));
}
- static RefPtr<Document> create(ScriptExecutionContext&);
+ static Ref<Document> create(ScriptExecutionContext&);
virtual ~Document();
@@ -422,9 +422,9 @@
bool hasManifest() const;
virtual RefPtr<Element> createElement(const AtomicString& tagName, ExceptionCode&);
- WEBCORE_EXPORT RefPtr<DocumentFragment> createDocumentFragment();
- WEBCORE_EXPORT RefPtr<Text> createTextNode(const String& data);
- RefPtr<Comment> createComment(const String& data);
+ WEBCORE_EXPORT Ref<DocumentFragment> createDocumentFragment();
+ WEBCORE_EXPORT Ref<Text> createTextNode(const String& data);
+ Ref<Comment> createComment(const String& data);
RefPtr<CDATASection> createCDATASection(const String& data, ExceptionCode&);
RefPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionCode&);
RefPtr<Attr> createAttribute(const String& name, ExceptionCode&);
@@ -433,7 +433,7 @@
RefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, true, ec); }
RefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionCode&);
WEBCORE_EXPORT RefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
- WEBCORE_EXPORT RefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
+ WEBCORE_EXPORT Ref<Element> createElement(const QualifiedName&, bool createdByParser);
bool cssRegionsEnabled() const;
bool cssCompositingEnabled() const;
@@ -582,7 +582,7 @@
float deviceScaleFactor() const;
- WEBCORE_EXPORT RefPtr<Range> createRange();
+ WEBCORE_EXPORT Ref<Range> createRange();
RefPtr<NodeIterator> createNodeIterator(Node* root, unsigned whatToShow,
PassRefPtr<NodeFilter>, bool expandEntityReferences, ExceptionCode&);
@@ -591,8 +591,8 @@
PassRefPtr<NodeFilter>, bool expandEntityReferences, ExceptionCode&);
// Special support for editing
- RefPtr<CSSStyleDeclaration> createCSSStyleDeclaration();
- RefPtr<Text> createEditingTextNode(const String&);
+ Ref<CSSStyleDeclaration> createCSSStyleDeclaration();
+ Ref<Text> createEditingTextNode(const String&);
void recalcStyle(Style::Change = Style::NoChange);
WEBCORE_EXPORT void updateStyleIfNeeded();
@@ -689,7 +689,7 @@
CSSStyleSheet& elementSheet();
- virtual RefPtr<DocumentParser> createParser();
+ virtual Ref<DocumentParser> createParser();
DocumentParser* parser() const { return m_parser.get(); }
ScriptableDocumentParser* scriptableDocumentParser() const;
@@ -1287,7 +1287,7 @@
void clearXMLVersion() { m_xmlVersion = String(); }
- virtual RefPtr<Document> cloneDocumentWithoutChildren() const;
+ virtual Ref<Document> cloneDocumentWithoutChildren() const;
private:
friend class Node;
Modified: trunk/Source/WebCore/dom/DocumentFragment.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/DocumentFragment.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/DocumentFragment.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -36,14 +36,14 @@
{
}
-RefPtr<DocumentFragment> DocumentFragment::create(Document& document)
+Ref<DocumentFragment> DocumentFragment::create(Document& document)
{
- return adoptRef(new DocumentFragment(document, Node::CreateDocumentFragment));
+ return adoptRef(*new DocumentFragment(document, Node::CreateDocumentFragment));
}
-RefPtr<DocumentFragment> DocumentFragment::create(ScriptExecutionContext& context)
+Ref<DocumentFragment> DocumentFragment::create(ScriptExecutionContext& context)
{
- return adoptRef(new DocumentFragment(downcast<Document>(context), Node::CreateDocumentFragment));
+ return adoptRef(*new DocumentFragment(downcast<Document>(context), Node::CreateDocumentFragment));
}
String DocumentFragment::nodeName() const
Modified: trunk/Source/WebCore/dom/DocumentFragment.h (177558 => 177559)
--- trunk/Source/WebCore/dom/DocumentFragment.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/DocumentFragment.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -33,8 +33,8 @@
class DocumentFragment : public ContainerNode {
public:
- static RefPtr<DocumentFragment> create(Document&);
- static RefPtr<DocumentFragment> create(ScriptExecutionContext&);
+ static Ref<DocumentFragment> create(Document&);
+ static Ref<DocumentFragment> create(ScriptExecutionContext&);
void parseHTML(const String&, Element* contextElement, ParserContentPolicy = AllowScriptingContent);
bool parseXML(const String&, Element* contextElement, ParserContentPolicy = AllowScriptingContent);
Modified: trunk/Source/WebCore/dom/DocumentType.h (177558 => 177559)
--- trunk/Source/WebCore/dom/DocumentType.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/DocumentType.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -32,9 +32,9 @@
class DocumentType final : public Node {
public:
- static RefPtr<DocumentType> create(Document& document, const String& name, const String& publicId, const String& systemId)
+ static Ref<DocumentType> create(Document& document, const String& name, const String& publicId, const String& systemId)
{
- return adoptRef(new DocumentType(document, name, publicId, systemId));
+ return adoptRef(*new DocumentType(document, name, publicId, systemId));
}
// FIXME: We return null entities and notations. Current implementation of NamedNodeMap doesn't work without an associated Element yet.
Modified: trunk/Source/WebCore/dom/EntityReference.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/EntityReference.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/EntityReference.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -31,9 +31,9 @@
{
}
-RefPtr<EntityReference> EntityReference::create(Document& document, const String& entityName)
+Ref<EntityReference> EntityReference::create(Document& document, const String& entityName)
{
- return adoptRef(new EntityReference(document, entityName));
+ return adoptRef(*new EntityReference(document, entityName));
}
String EntityReference::nodeName() const
Modified: trunk/Source/WebCore/dom/EntityReference.h (177558 => 177559)
--- trunk/Source/WebCore/dom/EntityReference.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/EntityReference.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -28,7 +28,7 @@
class EntityReference final : public ContainerNode {
public:
- static RefPtr<EntityReference> create(Document&, const String& entityName);
+ static Ref<EntityReference> create(Document&, const String& entityName);
private:
EntityReference(Document&, const String& entityName);
Modified: trunk/Source/WebCore/dom/Text.cpp (177558 => 177559)
--- trunk/Source/WebCore/dom/Text.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Text.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -38,19 +38,19 @@
namespace WebCore {
-RefPtr<Text> Text::create(Document& document, const String& data)
+Ref<Text> Text::create(Document& document, const String& data)
{
- return adoptRef(new Text(document, data, CreateText));
+ return adoptRef(*new Text(document, data, CreateText));
}
-RefPtr<Text> Text::create(ScriptExecutionContext& context, const String& data)
+Ref<Text> Text::create(ScriptExecutionContext& context, const String& data)
{
- return adoptRef(new Text(downcast<Document>(context), data, CreateText));
+ return adoptRef(*new Text(downcast<Document>(context), data, CreateText));
}
-RefPtr<Text> Text::createEditingText(Document& document, const String& data)
+Ref<Text> Text::createEditingText(Document& document, const String& data)
{
- return adoptRef(new Text(document, data, CreateEditingText));
+ return adoptRef(*new Text(document, data, CreateEditingText));
}
Text::~Text()
@@ -71,13 +71,13 @@
EventQueueScope scope;
String oldStr = data();
- RefPtr<Text> newText = virtualCreate(oldStr.substring(offset));
+ Ref<Text> newText = virtualCreate(oldStr.substring(offset));
setDataWithoutUpdate(oldStr.substring(0, offset));
dispatchModifiedEvent(oldStr);
if (parentNode())
- parentNode()->insertBefore(newText.get(), nextSibling(), ec);
+ parentNode()->insertBefore(newText.ptr(), nextSibling(), ec);
if (ec)
return 0;
@@ -87,7 +87,7 @@
if (renderer())
renderer()->setTextWithOffset(dataImpl(), 0, oldStr.length());
- return newText.release();
+ return WTF::move(newText);
}
static const Text* earliestLogicallyAdjacentTextNode(const Text* text)
@@ -203,21 +203,20 @@
return false;
}
-RefPtr<Text> Text::virtualCreate(const String& data)
+Ref<Text> Text::virtualCreate(const String& data)
{
return create(document(), data);
}
-RefPtr<Text> Text::createWithLengthLimit(Document& document, const String& data, unsigned start, unsigned lengthLimit)
+Ref<Text> Text::createWithLengthLimit(Document& document, const String& data, unsigned start, unsigned lengthLimit)
{
unsigned dataLength = data.length();
if (!start && dataLength <= lengthLimit)
return create(document, data);
- RefPtr<Text> result = Text::create(document, String());
+ Ref<Text> result = Text::create(document, String());
result->parserAppendData(data, start, lengthLimit);
-
return result;
}
Modified: trunk/Source/WebCore/dom/Text.h (177558 => 177559)
--- trunk/Source/WebCore/dom/Text.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/dom/Text.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -35,10 +35,10 @@
public:
static const unsigned defaultLengthLimit = 1 << 16;
- static RefPtr<Text> create(Document&, const String&);
- static RefPtr<Text> create(ScriptExecutionContext&, const String&);
- static RefPtr<Text> createWithLengthLimit(Document&, const String&, unsigned positionInString, unsigned lengthLimit = defaultLengthLimit);
- static RefPtr<Text> createEditingText(Document&, const String&);
+ static Ref<Text> create(Document&, const String&);
+ static Ref<Text> create(ScriptExecutionContext&, const String&);
+ static Ref<Text> createWithLengthLimit(Document&, const String&, unsigned positionInString, unsigned lengthLimit = defaultLengthLimit);
+ static Ref<Text> createEditingText(Document&, const String&);
virtual ~Text();
@@ -67,7 +67,7 @@
virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
virtual bool childTypeAllowed(NodeType) const override;
- virtual RefPtr<Text> virtualCreate(const String&);
+ virtual Ref<Text> virtualCreate(const String&);
#ifndef NDEBUG
virtual void formatForDebugger(char* buffer, unsigned length) const override;
Modified: trunk/Source/WebCore/editing/markup.cpp (177558 => 177559)
--- trunk/Source/WebCore/editing/markup.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/editing/markup.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -994,15 +994,15 @@
return;
}
- RefPtr<Text> textNode = Text::create(containerNode->document(), text);
+ Ref<Text> textNode = Text::create(containerNode->document(), text);
if (hasOneChild(containerNode)) {
- containerNode->replaceChild(textNode.release(), containerNode->firstChild(), ec);
+ containerNode->replaceChild(WTF::move(textNode), containerNode->firstChild(), ec);
return;
}
containerNode->removeChildren();
- containerNode->appendChild(textNode.release(), ec);
+ containerNode->appendChild(WTF::move(textNode), ec);
}
}
Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -48,9 +48,9 @@
class FTPDirectoryDocumentParser final : public HTMLDocumentParser {
public:
- static RefPtr<FTPDirectoryDocumentParser> create(HTMLDocument& document)
+ static Ref<FTPDirectoryDocumentParser> create(HTMLDocument& document)
{
- return adoptRef(new FTPDirectoryDocumentParser(document));
+ return adoptRef(*new FTPDirectoryDocumentParser(document));
}
virtual void append(PassRefPtr<StringImpl>) override;
@@ -432,7 +432,7 @@
#endif
}
-RefPtr<DocumentParser> FTPDirectoryDocument::createParser()
+Ref<DocumentParser> FTPDirectoryDocument::createParser()
{
return FTPDirectoryDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/FTPDirectoryDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -40,7 +40,7 @@
private:
FTPDirectoryDocument(Frame*, const URL&);
- virtual RefPtr<DocumentParser> createParser() override;
+ virtual Ref<DocumentParser> createParser() override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/HTMLDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -224,7 +224,7 @@
{
}
-RefPtr<DocumentParser> HTMLDocument::createParser()
+Ref<DocumentParser> HTMLDocument::createParser()
{
return HTMLDocumentParser::create(*this);
}
@@ -342,7 +342,7 @@
return is<HTMLFrameSetElement>(body());
}
-RefPtr<Document> HTMLDocument::cloneDocumentWithoutChildren() const
+Ref<Document> HTMLDocument::cloneDocumentWithoutChildren() const
{
return create(nullptr, url());
}
Modified: trunk/Source/WebCore/html/HTMLDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/HTMLDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/HTMLDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -31,14 +31,14 @@
class HTMLDocument : public Document, public CachedResourceClient {
public:
- static RefPtr<HTMLDocument> create(Frame* frame, const URL& url)
+ static Ref<HTMLDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new HTMLDocument(frame, url, HTMLDocumentClass));
+ return adoptRef(*new HTMLDocument(frame, url, HTMLDocumentClass));
}
- static RefPtr<HTMLDocument> createSynthesizedDocument(Frame* frame, const URL& url)
+ static Ref<HTMLDocument> createSynthesizedDocument(Frame* frame, const URL& url)
{
- return adoptRef(new HTMLDocument(frame, url, HTMLDocumentClass, Synthesized));
+ return adoptRef(*new HTMLDocument(frame, url, HTMLDocumentClass, Synthesized));
}
virtual ~HTMLDocument();
@@ -89,8 +89,8 @@
virtual RefPtr<Element> createElement(const AtomicString& tagName, ExceptionCode&) override;
virtual bool isFrameSet() const override;
- virtual RefPtr<DocumentParser> createParser() override;
- virtual RefPtr<Document> cloneDocumentWithoutChildren() const override final;
+ virtual Ref<DocumentParser> createParser() override;
+ virtual Ref<Document> cloneDocumentWithoutChildren() const override final;
DocumentOrderedMap m_documentNamedItem;
DocumentOrderedMap m_windowNamedItem;
Modified: trunk/Source/WebCore/html/ImageDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/ImageDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/ImageDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -54,7 +54,7 @@
#if !PLATFORM(IOS)
class ImageEventListener final : public EventListener {
public:
- static RefPtr<ImageEventListener> create(ImageDocument& document) { return adoptRef(new ImageEventListener(document)); }
+ static Ref<ImageEventListener> create(ImageDocument& document) { return adoptRef(*new ImageEventListener(document)); }
private:
ImageEventListener(ImageDocument& document)
@@ -72,9 +72,9 @@
class ImageDocumentParser final : public RawDataDocumentParser {
public:
- static RefPtr<ImageDocumentParser> create(ImageDocument& document)
+ static Ref<ImageDocumentParser> create(ImageDocument& document)
{
- return adoptRef(new ImageDocumentParser(document));
+ return adoptRef(*new ImageDocumentParser(document));
}
private:
@@ -202,7 +202,7 @@
lockCompatibilityMode();
}
-RefPtr<DocumentParser> ImageDocument::createParser()
+Ref<DocumentParser> ImageDocument::createParser()
{
return ImageDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/html/ImageDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/ImageDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/ImageDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -34,9 +34,9 @@
class ImageDocument final : public HTMLDocument {
public:
- static RefPtr<ImageDocument> create(Frame& frame, const URL& url)
+ static Ref<ImageDocument> create(Frame& frame, const URL& url)
{
- return adoptRef(new ImageDocument(frame, url));
+ return adoptRef(*new ImageDocument(frame, url));
}
WEBCORE_EXPORT HTMLImageElement* imageElement() const;
@@ -54,7 +54,7 @@
private:
ImageDocument(Frame&, const URL&);
- virtual RefPtr<DocumentParser> createParser() override;
+ virtual Ref<DocumentParser> createParser() override;
LayoutSize imageSize();
Modified: trunk/Source/WebCore/html/MediaDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/MediaDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/MediaDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -52,9 +52,9 @@
// FIXME: Share more code with PluginDocumentParser.
class MediaDocumentParser final : public RawDataDocumentParser {
public:
- static RefPtr<MediaDocumentParser> create(MediaDocument& document)
+ static Ref<MediaDocumentParser> create(MediaDocument& document)
{
- return adoptRef(new MediaDocumentParser(document));
+ return adoptRef(*new MediaDocumentParser(document));
}
private:
@@ -153,7 +153,7 @@
ASSERT(!m_replaceMediaElementTimer.isActive());
}
-RefPtr<DocumentParser> MediaDocument::createParser()
+Ref<DocumentParser> MediaDocument::createParser()
{
return MediaDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/html/MediaDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/MediaDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/MediaDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -34,9 +34,9 @@
class MediaDocument final : public HTMLDocument {
public:
- static RefPtr<MediaDocument> create(Frame* frame, const URL& url)
+ static Ref<MediaDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new MediaDocument(frame, url));
+ return adoptRef(*new MediaDocument(frame, url));
}
virtual ~MediaDocument();
@@ -46,7 +46,7 @@
private:
MediaDocument(Frame*, const URL&);
- virtual RefPtr<DocumentParser> createParser() override;
+ virtual Ref<DocumentParser> createParser() override;
virtual void defaultEventHandler(Event*) override;
Modified: trunk/Source/WebCore/html/PluginDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/PluginDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/PluginDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -46,9 +46,9 @@
// FIXME: Share more code with MediaDocumentParser.
class PluginDocumentParser final : public RawDataDocumentParser {
public:
- static RefPtr<PluginDocumentParser> create(PluginDocument& document)
+ static Ref<PluginDocumentParser> create(PluginDocument& document)
{
- return adoptRef(new PluginDocumentParser(document));
+ return adoptRef(*new PluginDocumentParser(document));
}
private:
@@ -148,7 +148,7 @@
lockCompatibilityMode();
}
-RefPtr<DocumentParser> PluginDocument::createParser()
+Ref<DocumentParser> PluginDocument::createParser()
{
return PluginDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/html/PluginDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/PluginDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/PluginDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -34,9 +34,9 @@
class PluginDocument final : public HTMLDocument {
public:
- static RefPtr<PluginDocument> create(Frame* frame, const URL& url)
+ static Ref<PluginDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new PluginDocument(frame, url));
+ return adoptRef(*new PluginDocument(frame, url));
}
void setPluginElement(PassRefPtr<HTMLPlugInElement>);
@@ -53,7 +53,7 @@
private:
PluginDocument(Frame*, const URL&);
- virtual RefPtr<DocumentParser> createParser() override;
+ virtual Ref<DocumentParser> createParser() override;
void setShouldLoadPluginManually(bool loadManually) { m_shouldLoadPluginManually = loadManually; }
Modified: trunk/Source/WebCore/html/TextDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/TextDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/TextDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -36,7 +36,7 @@
lockCompatibilityMode();
}
-RefPtr<DocumentParser> TextDocument::createParser()
+Ref<DocumentParser> TextDocument::createParser()
{
return TextDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/html/TextDocument.h (177558 => 177559)
--- trunk/Source/WebCore/html/TextDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/TextDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -31,15 +31,15 @@
class TextDocument final : public HTMLDocument {
public:
- static RefPtr<TextDocument> create(Frame* frame, const URL& url)
+ static Ref<TextDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new TextDocument(frame, url));
+ return adoptRef(*new TextDocument(frame, url));
}
private:
TextDocument(Frame*, const URL&);
- virtual RefPtr<DocumentParser> createParser() override;
+ virtual Ref<DocumentParser> createParser() override;
};
}
Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (177558 => 177559)
--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -553,7 +553,7 @@
}
while (currentPosition < characters.length()) {
- RefPtr<Text> textNode = Text::createWithLengthLimit(task.parent->document(), shouldUseAtomicString ? AtomicString(characters).string() : characters, currentPosition, lengthLimit);
+ Ref<Text> textNode = Text::createWithLengthLimit(task.parent->document(), shouldUseAtomicString ? AtomicString(characters).string() : characters, currentPosition, lengthLimit);
// If we have a whole string of unbreakable characters the above could lead to an infinite loop. Exceeding the length limit is the lesser evil.
if (!textNode->length()) {
String substring = characters.substring(currentPosition);
@@ -562,7 +562,7 @@
currentPosition += textNode->length();
ASSERT(currentPosition <= characters.length());
- task.child = textNode.release();
+ task.child = WTF::move(textNode);
executeTask(task);
}
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.h (177558 => 177559)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -62,9 +62,9 @@
class HTMLDocumentParser : public ScriptableDocumentParser, HTMLScriptRunnerHost, CachedResourceClient {
WTF_MAKE_FAST_ALLOCATED;
public:
- static RefPtr<HTMLDocumentParser> create(HTMLDocument& document)
+ static Ref<HTMLDocumentParser> create(HTMLDocument& document)
{
- return adoptRef(new HTMLDocumentParser(document));
+ return adoptRef(*new HTMLDocumentParser(document));
}
virtual ~HTMLDocumentParser();
@@ -93,9 +93,9 @@
void forcePlaintextForTextDocument();
private:
- static RefPtr<HTMLDocumentParser> create(DocumentFragment& fragment, Element* contextElement, ParserContentPolicy parserContentPolicy)
+ static Ref<HTMLDocumentParser> create(DocumentFragment& fragment, Element* contextElement, ParserContentPolicy parserContentPolicy)
{
- return adoptRef(new HTMLDocumentParser(fragment, contextElement, parserContentPolicy));
+ return adoptRef(*new HTMLDocumentParser(fragment, contextElement, parserContentPolicy));
}
// DocumentParser
Modified: trunk/Source/WebCore/html/parser/TextDocumentParser.h (177558 => 177559)
--- trunk/Source/WebCore/html/parser/TextDocumentParser.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/html/parser/TextDocumentParser.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -32,9 +32,9 @@
class TextDocumentParser final : public HTMLDocumentParser {
public:
- static PassRefPtr<TextDocumentParser> create(HTMLDocument& document)
+ static Ref<TextDocumentParser> create(HTMLDocument& document)
{
- return adoptRef(new TextDocumentParser(document));
+ return adoptRef(*new TextDocumentParser(document));
}
virtual ~TextDocumentParser();
Modified: trunk/Source/WebCore/loader/SinkDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/loader/SinkDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/loader/SinkDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -32,9 +32,9 @@
class SinkDocumentParser final : public RawDataDocumentParser {
public:
- static RefPtr<SinkDocumentParser> create(SinkDocument& document)
+ static Ref<SinkDocumentParser> create(SinkDocument& document)
{
- return adoptRef(new SinkDocumentParser(document));
+ return adoptRef(*new SinkDocumentParser(document));
}
private:
@@ -56,7 +56,7 @@
lockCompatibilityMode();
}
-RefPtr<DocumentParser> SinkDocument::createParser()
+Ref<DocumentParser> SinkDocument::createParser()
{
return SinkDocumentParser::create(*this);
}
Modified: trunk/Source/WebCore/loader/SinkDocument.h (177558 => 177559)
--- trunk/Source/WebCore/loader/SinkDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/loader/SinkDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -32,15 +32,15 @@
class SinkDocument final : public HTMLDocument {
public:
- static RefPtr<SinkDocument> create(Frame* frame, const URL& url)
+ static Ref<SinkDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new SinkDocument(frame, url));
+ return adoptRef(*new SinkDocument(frame, url));
}
private:
SinkDocument(Frame*, const URL&);
- virtual RefPtr<DocumentParser> createParser();
+ virtual Ref<DocumentParser> createParser();
};
Modified: trunk/Source/WebCore/svg/SVGDocument.cpp (177558 => 177559)
--- trunk/Source/WebCore/svg/SVGDocument.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/svg/SVGDocument.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -76,7 +76,7 @@
}
}
-RefPtr<Document> SVGDocument::cloneDocumentWithoutChildren() const
+Ref<Document> SVGDocument::cloneDocumentWithoutChildren() const
{
return create(nullptr, url());
}
Modified: trunk/Source/WebCore/svg/SVGDocument.h (177558 => 177559)
--- trunk/Source/WebCore/svg/SVGDocument.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/svg/SVGDocument.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -32,9 +32,9 @@
class SVGDocument final : public Document {
public:
- static RefPtr<SVGDocument> create(Frame* frame, const URL& url)
+ static Ref<SVGDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new SVGDocument(frame, url));
+ return adoptRef(*new SVGDocument(frame, url));
}
SVGSVGElement* rootElement() const;
@@ -47,7 +47,7 @@
private:
SVGDocument(Frame*, const URL&);
- virtual RefPtr<Document> cloneDocumentWithoutChildren() const override;
+ virtual Ref<Document> cloneDocumentWithoutChildren() const override;
FloatPoint m_translate;
};
Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.h (177558 => 177559)
--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2014-12-19 03:11:36 UTC (rev 177559)
@@ -52,8 +52,8 @@
class XMLParserContext : public RefCounted<XMLParserContext> {
public:
- static PassRefPtr<XMLParserContext> createMemoryParser(xmlSAXHandlerPtr, void* userData, const CString& chunk);
- static PassRefPtr<XMLParserContext> createStringParser(xmlSAXHandlerPtr, void* userData);
+ static RefPtr<XMLParserContext> createMemoryParser(xmlSAXHandlerPtr, void* userData, const CString& chunk);
+ static Ref<XMLParserContext> createStringParser(xmlSAXHandlerPtr, void* userData);
~XMLParserContext();
xmlParserCtxtPtr context() const { return m_context; }
@@ -68,13 +68,13 @@
class XMLDocumentParser : public ScriptableDocumentParser, public CachedResourceClient {
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassRefPtr<XMLDocumentParser> create(Document& document, FrameView* view)
+ static Ref<XMLDocumentParser> create(Document& document, FrameView* view)
{
- return adoptRef(new XMLDocumentParser(document, view));
+ return adoptRef(*new XMLDocumentParser(document, view));
}
- static PassRefPtr<XMLDocumentParser> create(DocumentFragment& fragment, Element* element, ParserContentPolicy parserContentPolicy)
+ static Ref<XMLDocumentParser> create(DocumentFragment& fragment, Element* element, ParserContentPolicy parserContentPolicy)
{
- return adoptRef(new XMLDocumentParser(fragment, element, parserContentPolicy));
+ return adoptRef(*new XMLDocumentParser(fragment, element, parserContentPolicy));
}
~XMLDocumentParser();
Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (177558 => 177559)
--- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-12-19 03:11:36 UTC (rev 177559)
@@ -508,7 +508,7 @@
static bool didInit = false;
-PassRefPtr<XMLParserContext> XMLParserContext::createStringParser(xmlSAXHandlerPtr handlers, void* userData)
+Ref<XMLParserContext> XMLParserContext::createStringParser(xmlSAXHandlerPtr handlers, void* userData)
{
if (!didInit) {
xmlInitParser();
@@ -526,12 +526,12 @@
switchToUTF16(parser);
- return adoptRef(new XMLParserContext(parser));
+ return adoptRef(*new XMLParserContext(parser));
}
// Chunk should be encoded in UTF-8
-PassRefPtr<XMLParserContext> XMLParserContext::createMemoryParser(xmlSAXHandlerPtr handlers, void* userData, const CString& chunk)
+RefPtr<XMLParserContext> XMLParserContext::createMemoryParser(xmlSAXHandlerPtr handlers, void* userData, const CString& chunk)
{
if (!didInit) {
xmlInitParser();
@@ -562,7 +562,7 @@
parser->str_xml_ns = xmlDictLookup(parser->dict, XML_XML_NAMESPACE, 36);
parser->_private = userData;
- return adoptRef(new XMLParserContext(parser));
+ return adoptRef(*new XMLParserContext(parser));
}
// --------------------------------
Modified: trunk/Source/WebKit/mac/ChangeLog (177558 => 177559)
--- trunk/Source/WebKit/mac/ChangeLog 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-19 03:11:36 UTC (rev 177559)
@@ -1,3 +1,13 @@
+2014-12-18 Andreas Kling <[email protected]>
+
+ Ref-ify various Document-related things.
+ <https://webkit.org/b/139796>
+
+ Reviewed by Anders Carlsson.
+
+ * WebView/WebFrame.mm:
+ (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
+
2014-12-18 Beth Dakin <[email protected]>
Need to re-enable action menus
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (177558 => 177559)
--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2014-12-19 03:11:36 UTC (rev 177559)
@@ -913,7 +913,7 @@
- (void)_replaceSelectionWithNode:(DOMNode *)node selectReplacement:(BOOL)selectReplacement smartReplace:(BOOL)smartReplace matchStyle:(BOOL)matchStyle
{
- DOMDocumentFragment *fragment = kit(_private->coreFrame->document()->createDocumentFragment().get());
+ DOMDocumentFragment *fragment = kit(_private->coreFrame->document()->createDocumentFragment().ptr());
[fragment appendChild:node];
[self _replaceSelectionWithFragment:fragment selectReplacement:selectReplacement smartReplace:smartReplace matchStyle:matchStyle];
}
Modified: trunk/Source/WebKit2/ChangeLog (177558 => 177559)
--- trunk/Source/WebKit2/ChangeLog 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-19 03:11:36 UTC (rev 177559)
@@ -1,3 +1,13 @@
+2014-12-18 Andreas Kling <[email protected]>
+
+ Ref-ify various Document-related things.
+ <https://webkit.org/b/139796>
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
+ (-[WKDOMDocument createTextNode:]):
+
2014-12-18 Beth Dakin <[email protected]>
Speculative build fix.
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm (177558 => 177559)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm 2014-12-19 03:04:53 UTC (rev 177558)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm 2014-12-19 03:11:36 UTC (rev 177559)
@@ -44,7 +44,7 @@
- (WKDOMText *)createTextNode:(NSString *)data
{
- return WebKit::toWKDOMText(downcast<WebCore::Document>(*_impl).createTextNode(data).get());
+ return WebKit::toWKDOMText(downcast<WebCore::Document>(*_impl).createTextNode(data).ptr());
}
- (WKDOMElement *)body
