Title: [177597] trunk/Source/_javascript_Core
Revision
177597
Author
[email protected]
Date
2014-12-19 14:14:20 -0800 (Fri, 19 Dec 2014)

Log Message

Plug leak below LLVMCopyStringRepOfTargetData().
<https://webkit.org/b/139832>

Reviewed by Michael Saboff.

LLVMCopyStringRepOfTargetData() returns a strdup()'ed string, so make sure
to free() it after we're done using it.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (177596 => 177597)


--- trunk/Source/_javascript_Core/ChangeLog	2014-12-19 22:09:58 UTC (rev 177596)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-12-19 22:14:20 UTC (rev 177597)
@@ -1,3 +1,16 @@
+2014-12-19  Andreas Kling  <[email protected]>
+
+        Plug leak below LLVMCopyStringRepOfTargetData().
+        <https://webkit.org/b/139832>
+
+        Reviewed by Michael Saboff.
+
+        LLVMCopyStringRepOfTargetData() returns a strdup()'ed string, so make sure
+        to free() it after we're done using it.
+
+        * ftl/FTLCompile.cpp:
+        (JSC::FTL::mmAllocateDataSection):
+
 2014-12-19  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html

Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (177596 => 177597)


--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-12-19 22:09:58 UTC (rev 177596)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-12-19 22:14:20 UTC (rev 177597)
@@ -644,7 +644,9 @@
         // it to the module.
         LLVMTargetMachineRef targetMachine = llvm->GetExecutionEngineTargetMachine(engine);
         LLVMTargetDataRef targetData = llvm->GetExecutionEngineTargetData(engine);
-        llvm->SetDataLayout(state.module, llvm->CopyStringRepOfTargetData(targetData));
+        char* stringRepOfTargetData = llvm->CopyStringRepOfTargetData(targetData);
+        llvm->SetDataLayout(state.module, stringRepOfTargetData);
+        free(stringRepOfTargetData);
 
         LLVMPassManagerRef functionPasses = 0;
         LLVMPassManagerRef modulePasses;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to