Title: [177599] trunk/Source/WebCore
- Revision
- 177599
- Author
- [email protected]
- Date
- 2014-12-19 15:53:37 -0800 (Fri, 19 Dec 2014)
Log Message
TextIndicator's window can be pushed down if it intersects the menu bar
https://bugs.webkit.org/show_bug.cgi?id=139841
<rdar://problem/19311017>
Reviewed by Anders Carlsson.
* page/mac/TextIndicatorWindow.mm:
(WebCore::TextIndicatorWindow::setTextIndicator):
Ensure that the textIndicatorWindow sits above the menubar, and re-set
its frame so that it moves under the menubar if required.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177598 => 177599)
--- trunk/Source/WebCore/ChangeLog 2014-12-19 23:25:46 UTC (rev 177598)
+++ trunk/Source/WebCore/ChangeLog 2014-12-19 23:53:37 UTC (rev 177599)
@@ -1,3 +1,16 @@
+2014-12-19 Timothy Horton <[email protected]>
+
+ TextIndicator's window can be pushed down if it intersects the menu bar
+ https://bugs.webkit.org/show_bug.cgi?id=139841
+ <rdar://problem/19311017>
+
+ Reviewed by Anders Carlsson.
+
+ * page/mac/TextIndicatorWindow.mm:
+ (WebCore::TextIndicatorWindow::setTextIndicator):
+ Ensure that the textIndicatorWindow sits above the menubar, and re-set
+ its frame so that it moves under the menubar if required.
+
2014-12-19 Anders Carlsson <[email protected]>
Use WebCore::MachSendRights for the compositing render server port
Modified: trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm (177598 => 177599)
--- trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2014-12-19 23:25:46 UTC (rev 177598)
+++ trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2014-12-19 23:53:37 UTC (rev 177599)
@@ -454,6 +454,9 @@
[[m_targetView window] addChildWindow:m_textIndicatorWindow.get() ordered:NSWindowAbove];
[m_textIndicatorWindow setReleasedWhenClosed:NO];
+ [m_textIndicatorWindow setLevel:NSMainMenuWindowLevel + 1];
+ [m_textIndicatorWindow setFrame:windowContentRect display:NO];
+
if (m_textIndicator->presentationTransition() != TextIndicatorPresentationTransition::None)
[m_textIndicatorView present];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
