Title: [177638] trunk/Source/WebCore
- Revision
- 177638
- Author
- [email protected]
- Date
- 2014-12-22 11:21:54 -0800 (Mon, 22 Dec 2014)
Log Message
Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
https://bugs.webkit.org/show_bug.cgi?id=139867
Reviewed by Darin Adler.
Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.
* loader/FrameLoader.cpp:
(WebCore::logNavigationWithFeatureCounter):
* platform/FeatureCounterKeys.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177637 => 177638)
--- trunk/Source/WebCore/ChangeLog 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/ChangeLog 2014-12-22 19:21:54 UTC (rev 177638)
@@ -1,3 +1,16 @@
+2014-12-22 Chris Dumez <[email protected]>
+
+ Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
+ https://bugs.webkit.org/show_bug.cgi?id=139867
+
+ Reviewed by Darin Adler.
+
+ Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::logNavigationWithFeatureCounter):
+ * platform/FeatureCounterKeys.h:
+
2014-12-22 Antti Koivisto <[email protected]>
Generic font code should not know about SVG font missing glyph
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (177637 => 177638)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-22 19:21:54 UTC (rev 177638)
@@ -1383,25 +1383,25 @@
const char* key;
switch (type) {
case FrameLoadType::Standard:
- key = FeatureCounterNavigationStandard;
+ key = FeatureCounterNavigationStandardKey;
break;
case FrameLoadType::Back:
- key = FeatureCounterNavigationBack;
+ key = FeatureCounterNavigationBackKey;
break;
case FrameLoadType::Forward:
- key = FeatureCounterNavigationForward;
+ key = FeatureCounterNavigationForwardKey;
break;
case FrameLoadType::IndexedBackForward:
- key = FeatureCounterNavigationIndexedBackForward;
+ key = FeatureCounterNavigationIndexedBackForwardKey;
break;
case FrameLoadType::Reload:
- key = FeatureCounterNavigationReload;
+ key = FeatureCounterNavigationReloadKey;
break;
case FrameLoadType::Same:
- key = FeatureCounterNavigationSame;
+ key = FeatureCounterNavigationSameKey;
break;
case FrameLoadType::ReloadFromOrigin:
- key = FeatureCounterNavigationReloadFromOrigin;
+ key = FeatureCounterNavigationReloadFromOriginKey;
break;
case FrameLoadType::Replace:
case FrameLoadType::RedirectWithLockedBackForwardList:
Modified: trunk/Source/WebCore/platform/FeatureCounterKeys.h (177637 => 177638)
--- trunk/Source/WebCore/platform/FeatureCounterKeys.h 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/platform/FeatureCounterKeys.h 2014-12-22 19:21:54 UTC (rev 177638)
@@ -77,13 +77,13 @@
static const char FeatureCounterMediaAudioElementPlayedKey[] = "com.apple.WebKit.media.audio.played";
// Navigation types.
-static const char FeatureCounterNavigationStandard[] = "com.apple.WebKit.navigation.standard";
-static const char FeatureCounterNavigationBack[] = "com.apple.WebKit.navigation.back";
-static const char FeatureCounterNavigationForward[] = "com.apple.WebKit.navigation.forward";
-static const char FeatureCounterNavigationIndexedBackForward[] = "com.apple.WebKit.navigation.indexedBackForward";
-static const char FeatureCounterNavigationReload[] = "com.apple.WebKit.navigation.reload";
-static const char FeatureCounterNavigationSame[] = "com.apple.WebKit.navigation.same";
-static const char FeatureCounterNavigationReloadFromOrigin[] = "com.apple.WebKit.navigation.reloadFromOrigin";
+static const char FeatureCounterNavigationStandardKey[] = "com.apple.WebKit.navigation.standard";
+static const char FeatureCounterNavigationBackKey[] = "com.apple.WebKit.navigation.back";
+static const char FeatureCounterNavigationForwardKey[] = "com.apple.WebKit.navigation.forward";
+static const char FeatureCounterNavigationIndexedBackForwardKey[] = "com.apple.WebKit.navigation.indexedBackForward";
+static const char FeatureCounterNavigationReloadKey[] = "com.apple.WebKit.navigation.reload";
+static const char FeatureCounterNavigationSameKey[] = "com.apple.WebKit.navigation.same";
+static const char FeatureCounterNavigationReloadFromOriginKey[] = "com.apple.WebKit.navigation.reloadFromOrigin";
// Memory cache.
static const char FeatureCounterResourceRequestInMemoryCacheKey[] = "com.apple.WebKit.resourceRequest.inMemoryCache";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
