Title: [177641] trunk/Source/WebCore
- Revision
- 177641
- Author
- [email protected]
- Date
- 2014-12-22 11:56:38 -0800 (Mon, 22 Dec 2014)
Log Message
Adjust TextIndicator shadow parameters
https://bugs.webkit.org/show_bug.cgi?id=139871
<rdar://problem/19283300>
Reviewed by Sam Weinig.
* page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
Slightly adjust the shadow and bounce size.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177640 => 177641)
--- trunk/Source/WebCore/ChangeLog 2014-12-22 19:47:32 UTC (rev 177640)
+++ trunk/Source/WebCore/ChangeLog 2014-12-22 19:56:38 UTC (rev 177641)
@@ -1,3 +1,15 @@
+2014-12-22 Timothy Horton <[email protected]>
+
+ Adjust TextIndicator shadow parameters
+ https://bugs.webkit.org/show_bug.cgi?id=139871
+ <rdar://problem/19283300>
+
+ Reviewed by Sam Weinig.
+
+ * page/mac/TextIndicatorWindow.mm:
+ (-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
+ Slightly adjust the shadow and bounce size.
+
2014-12-22 Chris Dumez <[email protected]>
Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
Modified: trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm (177640 => 177641)
--- trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2014-12-22 19:47:32 UTC (rev 177640)
+++ trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2014-12-22 19:56:38 UTC (rev 177641)
@@ -49,15 +49,15 @@
const CGFloat dropShadowOffsetY = 1;
const CGFloat dropShadowBlurRadius = 1.5;
#else
-const CGFloat midBounceScale = 1.2;
+const CGFloat midBounceScale = 1.25;
const CGFloat horizontalBorder = 2;
const CGFloat verticalBorder = 1;
const CGFloat borderWidth = 0;
const CGFloat cornerRadius = 0;
const CGFloat dropShadowOffsetX = 0;
-const CGFloat dropShadowOffsetY = 5;
-const CGFloat dropShadowBlurRadius = 12;
-const CGFloat rimShadowBlurRadius = 2;
+const CGFloat dropShadowOffsetY = 1;
+const CGFloat dropShadowBlurRadius = 2;
+const CGFloat rimShadowBlurRadius = 1;
#endif
NSString *textLayerKey = @"TextLayer";
@@ -108,7 +108,7 @@
RetainPtr<NSMutableArray> bounceLayers = adoptNS([[NSMutableArray alloc] init]);
RetainPtr<CGColorRef> highlightColor = [NSColor colorWithDeviceRed:1 green:1 blue:0 alpha:1].CGColor;
- RetainPtr<CGColorRef> rimShadowColor = [NSColor colorWithDeviceWhite:0 alpha:0.15].CGColor;
+ RetainPtr<CGColorRef> rimShadowColor = [NSColor colorWithDeviceWhite:0 alpha:0.35].CGColor;
RetainPtr<CGColorRef> dropShadowColor = [NSColor colorWithDeviceWhite:0 alpha:0.2].CGColor;
RetainPtr<CGColorRef> borderColor = [NSColor colorWithDeviceRed:.96 green:.90 blue:0 alpha:1].CGColor;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
