Title: [177731] trunk/Tools
- Revision
- 177731
- Author
- [email protected]
- Date
- 2014-12-24 22:26:38 -0800 (Wed, 24 Dec 2014)
Log Message
Engineering builds of MiniBrowser ignore deprecated declaration warnings
https://bugs.webkit.org/show_bug.cgi?id=139941
Reviewed by Darin Adler.
* MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
* MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
to YES.
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
deprecated NSOKButton.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (177730 => 177731)
--- trunk/Tools/ChangeLog 2014-12-25 02:48:11 UTC (rev 177730)
+++ trunk/Tools/ChangeLog 2014-12-25 06:26:38 UTC (rev 177731)
@@ -1,3 +1,17 @@
+2014-12-24 Dan Bernstein <[email protected]>
+
+ Engineering builds of MiniBrowser ignore deprecated declaration warnings
+ https://bugs.webkit.org/show_bug.cgi?id=139941
+
+ Reviewed by Darin Adler.
+
+ * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
+ * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
+ to YES.
+ * MiniBrowser/mac/AppDelegate.m:
+ (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
+ deprecated NSOKButton.
+
2014-12-24 Youenn Fablet <[email protected]>
W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (177730 => 177731)
--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2014-12-25 02:48:11 UTC (rev 177730)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2014-12-25 06:26:38 UTC (rev 177731)
@@ -37,7 +37,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
-GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
+GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES
Modified: trunk/Tools/MiniBrowser/Configurations/DebugRelease.xcconfig (177730 => 177731)
--- trunk/Tools/MiniBrowser/Configurations/DebugRelease.xcconfig 2014-12-25 02:48:11 UTC (rev 177730)
+++ trunk/Tools/MiniBrowser/Configurations/DebugRelease.xcconfig 2014-12-25 06:26:38 UTC (rev 177731)
@@ -34,6 +34,8 @@
MACOSX_DEPLOYMENT_TARGET_101000 = 10.10;
MACOSX_DEPLOYMENT_TARGET_101100 = 10.11;
+GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
+
OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (177730 => 177731)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-12-25 02:48:11 UTC (rev 177730)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-12-25 06:26:38 UTC (rev 177731)
@@ -160,7 +160,7 @@
if (browserWindowController) {
NSOpenPanel *openPanel = [[NSOpenPanel openPanel] retain];
[openPanel beginSheetModalForWindow:browserWindowController.window completionHandler:^(NSInteger result) {
- if (result != NSOKButton)
+ if (result != NSFileHandlingPanelOKButton)
return;
NSURL *url = "" objectAtIndex:0];
@@ -171,7 +171,7 @@
NSOpenPanel *openPanel = [NSOpenPanel openPanel];
[openPanel beginWithCompletionHandler:^(NSInteger result) {
- if (result != NSOKButton)
+ if (result != NSFileHandlingPanelOKButton)
return;
BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@"BrowserWindow"];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
