Title: [177762] trunk/LayoutTests
- Revision
- 177762
- Author
- [email protected]
- Date
- 2014-12-27 11:33:47 -0800 (Sat, 27 Dec 2014)
Log Message
fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139960
Reviewed by Anders Carlsson.
* fast/css/hover-update-expected.txt:
* fast/css/hover-update.html:
Increased the timeout, and updated the test to properly use js-test harness.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (177761 => 177762)
--- trunk/LayoutTests/ChangeLog 2014-12-27 19:25:51 UTC (rev 177761)
+++ trunk/LayoutTests/ChangeLog 2014-12-27 19:33:47 UTC (rev 177762)
@@ -1,3 +1,14 @@
+2014-12-27 Alexey Proskuryakov <[email protected]>
+
+ fast/css/hover-update.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=139960
+
+ Reviewed by Anders Carlsson.
+
+ * fast/css/hover-update-expected.txt:
+ * fast/css/hover-update.html:
+ Increased the timeout, and updated the test to properly use js-test harness.
+
2014-12-27 Csaba Osztrogonác <[email protected]>
[Win] Fix test expectations after r177363 - part IV
Modified: trunk/LayoutTests/fast/css/hover-update-expected.txt (177761 => 177762)
--- trunk/LayoutTests/fast/css/hover-update-expected.txt 2014-12-27 19:25:51 UTC (rev 177761)
+++ trunk/LayoutTests/fast/css/hover-update-expected.txt 2014-12-27 19:33:47 UTC (rev 177762)
@@ -6,4 +6,7 @@
Hover color before test: rgb(255, 255, 0)
PASS window.getComputedStyle(document.getElementById('b'), null).backgroundColor is "rgb(0, 128, 0)"
PASS window.getComputedStyle(document.getElementById('a'), null).backgroundColor is "rgb(0, 128, 0)"
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/fast/css/hover-update.html (177761 => 177762)
--- trunk/LayoutTests/fast/css/hover-update.html 2014-12-27 19:25:51 UTC (rev 177761)
+++ trunk/LayoutTests/fast/css/hover-update.html 2014-12-27 19:33:47 UTC (rev 177762)
@@ -1,5 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
- "http://www.w3.org/TR/html4/strict.dtd">
+<!DOCTYPE html>
<html lang="en">
<head>
<style>
@@ -11,7 +10,7 @@
div#b:hover { background: green; }
span#c:hover { color: red; }
</style>
-<script src=""
+<script src=""
</head>
<body _onload_="runtest()">
<p><b>BUG ID:</b> <a href="" bug 6821</a> Fix for 5983 will not always update hover correctly.</p>
@@ -19,20 +18,22 @@
<p>To run manually, move your mouse over the black box. You should see a green box. If you see any other color, the test fails.</p>
<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
function finish()
{
var expectedBackgroundColor = "rgb(0, 128, 0)";
// This test was failing on slower machines, so we give it more time to try to apply the hover state.
var timeSinceStartedCheckingMs = Date.now() - window.startCheckingForHoverMs;
- if (timeSinceStartedCheckingMs < 200 && getComputedStyle(document.getElementById('b')).backgroundColor != expectedBackgroundColor) {
+ if (timeSinceStartedCheckingMs < 10000 && getComputedStyle(document.getElementById('b')).backgroundColor != expectedBackgroundColor) {
setTimeout(finish, 10);
return;
}
shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);
shouldBeEqualToString("window.getComputedStyle(document.getElementById('a'), null).backgroundColor", expectedBackgroundColor);
- if (window.testRunner)
- testRunner.notifyDone();
+ finishJSTest();
}
function hideC()
@@ -55,7 +56,6 @@
debug('Hover color before test: ' + getComputedStyle(document.getElementById("b")).backgroundColor);
- testRunner.waitUntilDone();
var target = document.getElementById('target');
var x = target.offsetParent.offsetLeft + target.offsetLeft + target.offsetWidth / 2;
var y = target.offsetParent.offsetTop + target.offsetTop + target.offsetHeight / 2;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
