Title: [178362] trunk/LayoutTests
Revision
178362
Author
[email protected]
Date
2015-01-13 05:14:09 -0800 (Tue, 13 Jan 2015)

Log Message

AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
https://bugs.webkit.org/show_bug.cgi?id=140355

Patch by Andrzej Badowski <[email protected]> on 2015-01-13
Reviewed by Chris Fleizach.

The test shows the text contents of an AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue.
In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT,
so the stringValue produces an empty string.
To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.

* accessibility/table-with-footer-section-above-body.html:
   This test is also suitable for EFL and GTK port.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (178361 => 178362)


--- trunk/LayoutTests/ChangeLog	2015-01-13 12:58:45 UTC (rev 178361)
+++ trunk/LayoutTests/ChangeLog	2015-01-13 13:14:09 UTC (rev 178362)
@@ -1,3 +1,20 @@
+2015-01-13  Andrzej Badowski  <[email protected]>
+
+        AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
+        https://bugs.webkit.org/show_bug.cgi?id=140355
+
+        Reviewed by Chris Fleizach.
+
+        The test shows the text contents of an AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue.
+        In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT,
+        so the stringValue produces an empty string.
+        To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.
+
+        * accessibility/table-with-footer-section-above-body.html:
+           This test is also suitable for EFL and GTK port.
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2015-01-13  Bartlomiej Gajda  <[email protected]>
 
         [EFL] Fix test expectations after r178310.

Modified: trunk/LayoutTests/accessibility/table-with-footer-section-above-body.html (178361 => 178362)


--- trunk/LayoutTests/accessibility/table-with-footer-section-above-body.html	2015-01-13 12:58:45 UTC (rev 178361)
+++ trunk/LayoutTests/accessibility/table-with-footer-section-above-body.html	2015-01-13 13:14:09 UTC (rev 178362)
@@ -47,20 +47,32 @@
      
         var table = accessibilityController.accessibleElementById("table1");
         var testCell = table.cellForColumnAndRow(0, 1);
-        debug("Table1 cell content at {0, 1}: " + testCell.childAtIndex(0).stringValue);
+        if (accessibilityController.platformName != "atk")
+            debug("Table1 cell content at {0, 1}: " + testCell.childAtIndex(0).stringValue);
+        else
+            debug("Table1 cell content at {0, 1}: " + testCell.stringValue);
         debug("Table1 cell range at {0, 1}: " + testCell.rowIndexRange());
 
         testCell = table.cellForColumnAndRow(0, 2);
-        debug("Table1 cell content at {0, 2}: " + testCell.childAtIndex(0).stringValue);
+        if (accessibilityController.platformName != "atk")
+            debug("Table1 cell content at {0, 2}: " + testCell.childAtIndex(0).stringValue);
+        else
+            debug("Table1 cell content at {0, 2}: " + testCell.stringValue);
         debug("Table1 cell range at {0, 2}: " + testCell.rowIndexRange());
 
         table = accessibilityController.accessibleElementById("table2");
         testCell = table.cellForColumnAndRow(0, 1);
-        debug("Table2 cell content at {0, 1}: " + testCell.childAtIndex(0).stringValue);
+        if (accessibilityController.platformName != "atk")
+            debug("Table2 cell content at {0, 1}: " + testCell.childAtIndex(0).stringValue);
+        else
+            debug("Table2 cell content at {0, 1}: " + testCell.stringValue);
         debug("Table2 cell range at {0, 1}: " + testCell.rowIndexRange());
 
         testCell = table.cellForColumnAndRow(0, 2);
-        debug("Table2 cell content at {0, 2}: " + testCell.childAtIndex(0).stringValue);
+        if (accessibilityController.platformName != "atk")
+            debug("Table2 cell content at {0, 2}: " + testCell.childAtIndex(0).stringValue);
+        else
+            debug("Table2 cell content at {0, 2}: " + testCell.stringValue);
         debug("Table2 cell range at {0, 2}: " + testCell.rowIndexRange());
 
         document.getElementById("content").style.visibility = "hidden";

Modified: trunk/LayoutTests/platform/efl/TestExpectations (178361 => 178362)


--- trunk/LayoutTests/platform/efl/TestExpectations	2015-01-13 12:58:45 UTC (rev 178361)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-01-13 13:14:09 UTC (rev 178362)
@@ -1991,7 +1991,6 @@
 
 # Failing at least from 2014-05-01, but cause unknown
 webkit.org/b/133507 accessibility/media-element.html [ Failure ]
-webkit.org/b/133509 accessibility/table-with-footer-section-above-body.html [ Failure ]
 
 webkit.org/b/130187 accessibility/aria-hidden-false-works-in-subtrees.html [ Missing ]
 

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (178361 => 178362)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-01-13 12:58:45 UTC (rev 178361)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-01-13 13:14:09 UTC (rev 178362)
@@ -2181,8 +2181,6 @@
 
 webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
 
-webkit.org/b/132909 accessibility/table-with-footer-section-above-body.html [ Failure ]
-
 webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]
 
 webkit.org/b/132914 http/tests/security/drag-drop-local-file.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to