Title: [178508] trunk/LayoutTests
Revision
178508
Author
[email protected]
Date
2015-01-15 04:20:45 -0800 (Thu, 15 Jan 2015)

Log Message

AX: [ATK] Mark accessibility/render-counter-text.html as a suitable test for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=140438

Patch by Andrzej Badowski <[email protected]> on 2015-01-15
Reviewed by Chris Fleizach.

The test shows the text contents of the <li> element with the counter inside <ol> using three childAtIndex().stringValue methods.
In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT,
so the stringValue produces an empty string.
To avoid this, the text content is obtained by direct reading of stringValue of <li> AccessibilityUIElement which is ATK_TEXT.

* accessibility/render-counter-text.html:
   This test is also suitable for EFL and GTK port.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (178507 => 178508)


--- trunk/LayoutTests/ChangeLog	2015-01-15 12:00:22 UTC (rev 178507)
+++ trunk/LayoutTests/ChangeLog	2015-01-15 12:20:45 UTC (rev 178508)
@@ -1,3 +1,20 @@
+2015-01-15  Andrzej Badowski  <[email protected]>
+
+        AX: [ATK] Mark accessibility/render-counter-text.html as a suitable test for EFL and GTK.
+        https://bugs.webkit.org/show_bug.cgi?id=140438
+
+        Reviewed by Chris Fleizach.
+
+        The test shows the text contents of the <li> element with the counter inside <ol> using three childAtIndex().stringValue methods.
+        In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT,
+        so the stringValue produces an empty string.
+        To avoid this, the text content is obtained by direct reading of stringValue of <li> AccessibilityUIElement which is ATK_TEXT.
+
+        * accessibility/render-counter-text.html:
+           This test is also suitable for EFL and GTK port.
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2015-01-14  Simon Fraser  <[email protected]>
 
         Graphics corruption after Find on some pages

Modified: trunk/LayoutTests/accessibility/render-counter-text.html (178507 => 178508)


--- trunk/LayoutTests/accessibility/render-counter-text.html	2015-01-15 12:00:22 UTC (rev 178507)
+++ trunk/LayoutTests/accessibility/render-counter-text.html	2015-01-15 12:20:45 UTC (rev 178508)
@@ -26,14 +26,22 @@
 if (window.testRunner && window.accessibilityController) {
     
     var line1 = accessibilityController.accessibleElementById("line1");
-    shouldBe("line1.childAtIndex(0).stringValue", "'AXValue: 1'");
-    shouldBe("line1.childAtIndex(1).stringValue", "'AXValue: :'");
-    shouldBe("line1.childAtIndex(2).stringValue", "'AXValue: line1'");
+    if (accessibilityController.platformName != "atk") {
+        shouldBe("line1.childAtIndex(0).stringValue", "'AXValue: 1'");
+        shouldBe("line1.childAtIndex(1).stringValue", "'AXValue: :'");
+        shouldBe("line1.childAtIndex(2).stringValue", "'AXValue: line1'");
+    }
+    else
+        shouldBe("line1.stringValue", "'AXValue: 1 : line1'");
 
     var line2 = accessibilityController.accessibleElementById("line2");
-    shouldBe("line2.childAtIndex(0).stringValue", "'AXValue: 2'");
-    shouldBe("line2.childAtIndex(1).stringValue", "'AXValue: :'");
-    shouldBe("line2.childAtIndex(2).stringValue", "'AXValue: line2'");
+    if (accessibilityController.platformName != "atk") {
+        shouldBe("line2.childAtIndex(0).stringValue", "'AXValue: 2'");
+        shouldBe("line2.childAtIndex(1).stringValue", "'AXValue: :'");
+        shouldBe("line2.childAtIndex(2).stringValue", "'AXValue: line2'");
+    }
+    else
+        shouldBe("line2.stringValue", "'AXValue: 2 : line2'");
 
     document.getElementById("container").style.display = "none";
 }

Modified: trunk/LayoutTests/platform/efl/TestExpectations (178507 => 178508)


--- trunk/LayoutTests/platform/efl/TestExpectations	2015-01-15 12:00:22 UTC (rev 178507)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-01-15 12:20:45 UTC (rev 178508)
@@ -1442,9 +1442,6 @@
 # Leaking state into the next test.
 webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ]
 
-# Newly added test at r139002 is failing.
-webkit.org/b/106316 accessibility/render-counter-text.html [ Failure ]
-
 # New accessibility test added in r149155 is failing. Has been moved to the mac port in r155603.
 webkit.org/b/115659 accessibility/meter-element.html [ Missing ]
 

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (178507 => 178508)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-01-15 12:00:22 UTC (rev 178507)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-01-15 12:20:45 UTC (rev 178508)
@@ -1876,8 +1876,6 @@
 # Leaking state into the next test.
 webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ]
 
-webkit.org/b/106316 accessibility/render-counter-text.html [ Failure ]
-
 webkit.org/b/128420 accessibility/roles-computedRoleString.html [ Skip ]
 
 webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to