Title: [178528] trunk/Tools
- Revision
- 178528
- Author
- [email protected]
- Date
- 2015-01-15 14:14:50 -0800 (Thu, 15 Jan 2015)
Log Message
Stop hardcoding mac-mountainlion in commit queue
https://bugs.webkit.org/show_bug.cgi?id=140492
Reviewed by Anders Carlsson.
Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
there should be no change in behavior, because:
1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
using it to create a port object.
2. Although it doesn't convert the name before using DeprecatedPort.port(), it
is actually correct to use "mac" for the name there. We only used to get the expected
behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
for unknown deprecated port names.
* Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (178527 => 178528)
--- trunk/Tools/ChangeLog 2015-01-15 21:52:11 UTC (rev 178527)
+++ trunk/Tools/ChangeLog 2015-01-15 22:14:50 UTC (rev 178528)
@@ -1,3 +1,21 @@
+2015-01-15 Alexey Proskuryakov <[email protected]>
+
+ Stop hardcoding mac-mountainlion in commit queue
+ https://bugs.webkit.org/show_bug.cgi?id=140492
+
+ Reviewed by Anders Carlsson.
+
+ Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
+ there should be no change in behavior, because:
+ 1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
+ using it to create a port object.
+ 2. Although it doesn't convert the name before using DeprecatedPort.port(), it
+ is actually correct to use "mac" for the name there. We only used to get the expected
+ behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
+ for unknown deprecated port names.
+
+ * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
+
2015-01-14 Jake Nielsen <[email protected]>
Create iOS-EWS server queue
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (178527 => 178528)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2015-01-15 21:52:11 UTC (rev 178527)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2015-01-15 22:14:50 UTC (rev 178528)
@@ -303,7 +303,7 @@
PatchProcessingQueue.__init__(self)
name = "commit-queue"
- port_name = "mac-mountainlion"
+ port_name = "mac"
# AbstractPatchQueue methods
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
