Title: [179046] trunk/Tools
- Revision
- 179046
- Author
- [email protected]
- Date
- 2015-01-23 17:05:32 -0800 (Fri, 23 Jan 2015)
Log Message
test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<http://webkit.org/b/140787>
Reviewed by Daniel Bates.
* Scripts/webkitpy/port/ios.py:
(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (179045 => 179046)
--- trunk/Tools/ChangeLog 2015-01-24 01:03:13 UTC (rev 179045)
+++ trunk/Tools/ChangeLog 2015-01-24 01:05:32 UTC (rev 179046)
@@ -1,3 +1,15 @@
+2015-01-23 David Kilzer <[email protected]>
+
+ test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
+ <http://webkit.org/b/140787>
+
+ Reviewed by Daniel Bates.
+
+ * Scripts/webkitpy/port/ios.py:
+ (IOSPort.determine_full_port_name): Instead of checking the type
+ of the current host, test if /usr/bin/xcrun exists before trying
+ to use it.
+
2015-01-23 Csaba Osztrogonác <[email protected]>
Fix the false positive build failures on the Windows buildbots
Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (179045 => 179046)
--- trunk/Tools/Scripts/webkitpy/port/ios.py 2015-01-24 01:03:13 UTC (rev 179045)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py 2015-01-24 01:05:32 UTC (rev 179046)
@@ -53,7 +53,9 @@
def determine_full_port_name(cls, host, options, port_name):
if port_name == cls.port_name:
sdk_version = '8.0'
- if host.platform.is_mac():
+ # FIXME: We should move the call to xcrun to the PlatformInfo object so that
+ # we can use MockPlatformInfo to set an expectation when running the unit tests.
+ if os.path.isfile('/usr/bin/xcrun'):
sdk_command_output = subprocess.check_output(['/usr/bin/xcrun', '--sdk', 'iphoneos', '--show-sdk-version'], stderr=None).rstrip()
if sdk_command_output:
sdk_version = sdk_command_output
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
