Title: [179102] trunk
- Revision
- 179102
- Author
- [email protected]
- Date
- 2015-01-25 20:04:53 -0800 (Sun, 25 Jan 2015)
Log Message
Setting HTMLMarqueeElement.trueSpeed doesn't work
https://bugs.webkit.org/show_bug.cgi?id=140863
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/html/marquee-set-truespeed.html
* html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):
Check the boolean attribute properly - an empty value is true.
LayoutTests:
Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.
* fast/html/marquee-set-truespeed-expected.html: Added.
* fast/html/marquee-set-truespeed.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (179101 => 179102)
--- trunk/LayoutTests/ChangeLog 2015-01-26 03:22:09 UTC (rev 179101)
+++ trunk/LayoutTests/ChangeLog 2015-01-26 04:04:53 UTC (rev 179102)
@@ -1,3 +1,15 @@
+2015-01-25 Alexey Proskuryakov <[email protected]>
+
+ Setting HTMLMarqueeElement.trueSpeed doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=140863
+
+ Reviewed by Darin Adler.
+
+ Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.
+
+ * fast/html/marquee-set-truespeed-expected.html: Added.
+ * fast/html/marquee-set-truespeed.html: Added.
+
2015-01-25 Chris Dumez <[email protected]>
Remove 'font' shorthand property special casing
Added: trunk/LayoutTests/fast/html/marquee-set-truespeed-expected.html (0 => 179102)
--- trunk/LayoutTests/fast/html/marquee-set-truespeed-expected.html (rev 0)
+++ trunk/LayoutTests/fast/html/marquee-set-truespeed-expected.html 2015-01-26 04:04:53 UTC (rev 179102)
@@ -0,0 +1,3 @@
+<body>
+<p>Verify that setting trueSpeed attribute works.</p>
+<div>Test</div>
Added: trunk/LayoutTests/fast/html/marquee-set-truespeed.html (0 => 179102)
--- trunk/LayoutTests/fast/html/marquee-set-truespeed.html (rev 0)
+++ trunk/LayoutTests/fast/html/marquee-set-truespeed.html 2015-01-26 04:04:53 UTC (rev 179102)
@@ -0,0 +1,23 @@
+<body>
+<p>Verify that setting trueSpeed attribute works.</p>
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+
+_onload_ = function()
+{
+ var marquee = document.createElement("marquee");
+ marquee.innerHTML = "Test";
+ marquee.width = "100px";
+ marquee.behavior = "slide";
+ marquee.trueSpeed = true;
+ marquee.scrollAmount = 100;
+ marquee.scrollDelay = 1;
+ document.body.appendChild(marquee);
+ marquee.offsetTop; // Force layout now, so that marquee 1 ms timer starts before notifyDone 10 ms one, and doesn't race.
+ setTimeout(function() {
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 10);
+}
+</script>
Modified: trunk/Source/WebCore/ChangeLog (179101 => 179102)
--- trunk/Source/WebCore/ChangeLog 2015-01-26 03:22:09 UTC (rev 179101)
+++ trunk/Source/WebCore/ChangeLog 2015-01-26 04:04:53 UTC (rev 179102)
@@ -1,3 +1,15 @@
+2015-01-25 Alexey Proskuryakov <[email protected]>
+
+ Setting HTMLMarqueeElement.trueSpeed doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=140863
+
+ Reviewed by Darin Adler.
+
+ Test: fast/html/marquee-set-truespeed.html
+
+ * html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):
+ Check the boolean attribute properly - an empty value is true.
+
2015-01-25 Darin Adler <[email protected]>
Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
Modified: trunk/Source/WebCore/html/HTMLMarqueeElement.cpp (179101 => 179102)
--- trunk/Source/WebCore/html/HTMLMarqueeElement.cpp 2015-01-26 03:22:09 UTC (rev 179101)
+++ trunk/Source/WebCore/html/HTMLMarqueeElement.cpp 2015-01-26 04:04:53 UTC (rev 179102)
@@ -51,7 +51,7 @@
int HTMLMarqueeElement::minimumDelay() const
{
- if (fastGetAttribute(truespeedAttr).isEmpty()) {
+ if (!fastHasAttribute(truespeedAttr)) {
// WinIE uses 60ms as the minimum delay by default.
return 60;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
