Title: [179105] trunk/Source/WebCore
Revision
179105
Author
[email protected]
Date
2015-01-25 23:10:31 -0800 (Sun, 25 Jan 2015)

Log Message

Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.

* css/CSSPrimitiveValue.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (179104 => 179105)


--- trunk/Source/WebCore/ChangeLog	2015-01-26 06:29:34 UTC (rev 179104)
+++ trunk/Source/WebCore/ChangeLog	2015-01-26 07:10:31 UTC (rev 179105)
@@ -1,3 +1,18 @@
+2015-01-25  Chris Dumez  <[email protected]>
+
+        Remove 'font' shorthand property special casing
+        https://bugs.webkit.org/show_bug.cgi?id=140577
+
+        Reviewed by Darin Adler.
+
+        Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
+        supposed to change. This also makes sure that m_value.fontFamily
+        gets copied instead of moved when constructing a clone in
+        CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
+        to fail on the bots.
+
+        * css/CSSPrimitiveValue.h:
+
 2015-01-25  Alexey Proskuryakov  <[email protected]>
 
         Setting HTMLMarqueeElement.trueSpeed doesn't work

Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (179104 => 179105)


--- trunk/Source/WebCore/css/CSSPrimitiveValue.h	2015-01-26 06:29:34 UTC (rev 179104)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h	2015-01-26 07:10:31 UTC (rev 179105)
@@ -441,7 +441,7 @@
         DashboardRegion* region;
         CSSBasicShape* shape;
         CSSCalcValue* calc;
-        CSSFontFamily* fontFamily;
+        const CSSFontFamily* fontFamily;
     } m_value;
 };
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to