Title: [179110] trunk
- Revision
- 179110
- Author
- [email protected]
- Date
- 2015-01-26 01:42:02 -0800 (Mon, 26 Jan 2015)
Log Message
[EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
https://bugs.webkit.org/show_bug.cgi?id=140609
Reviewed by Csaba Osztrogonác.
The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
compilation flags. Those were added after the jsCStack branch merge, but
can now be removed since the -ftree-dce issues were fixed in GCC, and
changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (179109 => 179110)
--- trunk/ChangeLog 2015-01-26 09:09:52 UTC (rev 179109)
+++ trunk/ChangeLog 2015-01-26 09:42:02 UTC (rev 179110)
@@ -1,3 +1,19 @@
+2015-01-26 Zan Dobersek <[email protected]>
+
+ [EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
+ https://bugs.webkit.org/show_bug.cgi?id=140609
+
+ Reviewed by Csaba Osztrogonác.
+
+ The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
+ run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
+ compilation flags. Those were added after the jsCStack branch merge, but
+ can now be removed since the -ftree-dce issues were fixed in GCC, and
+ changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.
+
+ * Source/cmake/OptionsEfl.cmake:
+ * Source/cmake/OptionsGTK.cmake:
+
2015-01-26 Commit Queue <[email protected]>
Unreviewed, rolling out r179107.
Modified: trunk/Source/cmake/OptionsEfl.cmake (179109 => 179110)
--- trunk/Source/cmake/OptionsEfl.cmake 2015-01-26 09:09:52 UTC (rev 179109)
+++ trunk/Source/cmake/OptionsEfl.cmake 2015-01-26 09:42:02 UTC (rev 179110)
@@ -260,8 +260,8 @@
# Optimize binary size for release builds by removing dead sections on unix/gcc.
# Push of rbp is needed after JSC JIT uses CStack.
if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
- set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fno-tree-dce")
- set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-rtti -fno-omit-frame-pointer -fno-tree-dce")
+ set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -ffunction-sections -fdata-sections")
+ set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-rtti")
set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -Wl,--gc-sections")
endif ()
Modified: trunk/Source/cmake/OptionsGTK.cmake (179109 => 179110)
--- trunk/Source/cmake/OptionsGTK.cmake 2015-01-26 09:09:52 UTC (rev 179109)
+++ trunk/Source/cmake/OptionsGTK.cmake 2015-01-26 09:42:02 UTC (rev 179110)
@@ -363,18 +363,6 @@
set(SHOULD_INSTALL_JS_SHELL ON)
-# Push of rbp is needed after JSC JIT uses CStack. See http://wkbug.com/127777.
-if (UNIX AND NOT APPLE)
- if (CMAKE_COMPILER_IS_GNUCXX)
- set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -fno-omit-frame-pointer -fno-tree-dce")
- set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-omit-frame-pointer -fno-tree-dce")
- endif ()
- if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
- set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -fno-omit-frame-pointer")
- set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-omit-frame-pointer")
- endif ()
-endif ()
-
# Add a typelib file to the list of all typelib dependencies. This makes it easy to
# expose a 'gir' target with all gobject-introspection files.
macro(ADD_TYPELIB typelib)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
